[PR #4721] [MERGED] fix: Twelve Hour parsing issue #6403

New issue

Closed

opened 2026-03-23 22:23:04 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:23:04 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4721
Author: @AnsahMohammad
Created: 2/23/2024
Status: ✅ Merged
Merged: 4/8/2024
Merged by: @LucasXu0

Base: main ← Head: time_parser

📝 Commits (6)

fcf66da fix: twelve hour time format fixed
e45b2ef fix: time format for 12hour
6017df5 feat: auto capitalize am-pm in formatter
e756d72 fix: time field placeholder based on user time format
b7f24ad chore: bugfix + improvements
b00de22 Merge branch 'main' into time_parser

📊 Changes

4 files changed (+119 additions, -78 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_date_block.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/appflowy_date_picker.dart (+80 -73)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/widgets/time_text_field.dart (+33 -2)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text_field.dart (+4 -1)

📄 Description

This PR closes the Issue #4720

Fix issue 4720
Fix 12hour format bug
Auto capitalize AM/PM in the formatter
Set placeholder according to user time format
Add tests

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4721 **Author:** [@AnsahMohammad](https://github.com/AnsahMohammad) **Created:** 2/23/2024 **Status:** ✅ Merged **Merged:** 4/8/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `time_parser` --- ### 📝 Commits (6) - [`fcf66da`](https://github.com/AppFlowy-IO/AppFlowy/commit/fcf66da30135ff1bd592aeeb16366c4911a8c328) fix: twelve hour time format fixed - [`e45b2ef`](https://github.com/AppFlowy-IO/AppFlowy/commit/e45b2efbf87afedd95e6a9324ac343f68678a4a7) fix: time format for 12hour - [`6017df5`](https://github.com/AppFlowy-IO/AppFlowy/commit/6017df5a97d4c768684f56e6818ae9d0992f64b5) feat: auto capitalize am-pm in formatter - [`e756d72`](https://github.com/AppFlowy-IO/AppFlowy/commit/e756d72e543a4bcdb06ba61912b7b2d34dc95d38) fix: time field placeholder based on user time format - [`b7f24ad`](https://github.com/AppFlowy-IO/AppFlowy/commit/b7f24ad3d9cc8127ebbed7846545a8eb28fec538) chore: bugfix + improvements - [`b00de22`](https://github.com/AppFlowy-IO/AppFlowy/commit/b00de2239fd01047366363b134538e4c1164d681) Merge branch 'main' into time_parser ### 📊 Changes **4 files changed** (+119 additions, -78 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_date_block.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/appflowy_date_picker.dart` (+80 -73) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/widgets/time_text_field.dart` (+33 -2) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text_field.dart` (+4 -1) </details> ### 📄 Description This PR closes the Issue #4720 - [X] Fix issue 4720 - [X] Fix 12hour format bug - [X] Auto capitalize AM/PM in the formatter - [x] Set placeholder according to user time format - [ ] Add tests ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>