[PR #4727] [MERGED] fix: mobile view and field list bottom sheets #6408

Closed
opened 2026-03-23 22:23:05 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4727
Author: @richardshiue
Created: 2/24/2024
Status: Merged
Merged: 2/25/2024
Merged by: @LucasXu0

Base: mainHead: fix/transition-sheet-overflow


📝 Commits (6)

  • 5efd762 fix: mobile bottom overflow in view and field list
  • 234fd4e fix: delete button color on mobile
  • fee0908 chore: add extension for calculating bottom padding
  • 82bfd1b style: improve code style
  • 9a34cab fix: ignoreAsciiLowerCase as the functionality is contains
  • c6b1379 Update frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/show_mobile_bottom_sheet.dart

📊 Changes

4 files changed (+44 additions, -16 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/show_mobile_bottom_sheet.dart (+22 -11)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_field_list.dart (+10 -2)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_view_list.dart (+7 -2)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/mobile_select_option_editor.dart (+5 -1)

📄 Description

bottom overflow
Screenshot 2024-02-24 at 9 38 27 PM

not enough padding
Screenshot 2024-02-24 at 9 38 48 PM

misc

  • change delete text and icon color for select option editor to red
  • improve code style in field name filter

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4727 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 2/24/2024 **Status:** ✅ Merged **Merged:** 2/25/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/transition-sheet-overflow` --- ### 📝 Commits (6) - [`5efd762`](https://github.com/AppFlowy-IO/AppFlowy/commit/5efd76237e5d43643dc9e5cac428e2e5e1597488) fix: mobile bottom overflow in view and field list - [`234fd4e`](https://github.com/AppFlowy-IO/AppFlowy/commit/234fd4e2555abbccb2c817fab96b130fd9fe069e) fix: delete button color on mobile - [`fee0908`](https://github.com/AppFlowy-IO/AppFlowy/commit/fee09089d8396194e3a90a759a704d9a501835bb) chore: add extension for calculating bottom padding - [`82bfd1b`](https://github.com/AppFlowy-IO/AppFlowy/commit/82bfd1b1e1693f85cff1741ef1c5dbee2dadf1ca) style: improve code style - [`9a34cab`](https://github.com/AppFlowy-IO/AppFlowy/commit/9a34caba45c26285383918c7b72d441226985959) fix: ignoreAsciiLowerCase as the functionality is contains - [`c6b1379`](https://github.com/AppFlowy-IO/AppFlowy/commit/c6b1379c1914f2fd22f5243d131af525c42d0c4c) Update frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/show_mobile_bottom_sheet.dart ### 📊 Changes **4 files changed** (+44 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/show_mobile_bottom_sheet.dart` (+22 -11) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_field_list.dart` (+10 -2) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_view_list.dart` (+7 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/mobile_select_option_editor.dart` (+5 -1) </details> ### 📄 Description bottom overflow ![Screenshot 2024-02-24 at 9 38 27 PM](https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/0e9b9aca-47ce-44ea-90e1-a79ce0e351b7) not enough padding ![Screenshot 2024-02-24 at 9 38 48 PM](https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/d00ea806-5f44-4116-bb3f-efc28c94272f) misc - change delete text and icon color for select option editor to red - improve code style in field name filter ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:23:05 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#6408
No description provided.