[PR #4738] [MERGED] fix: some mobile database bugs #6417

New issue

Closed

opened 2026-03-23 22:23:07 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:23:07 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4738
Author: @richardshiue
Created: 2/26/2024
Status: ✅ Merged
Merged: 2/26/2024
Merged by: @richardshiue

Base: main ← Head: chore/mobile-db-fixes

📝 Commits (7)

668e79b chore: no autofocus on field name
87b53ce refactor: one, two, many
98e3e44 chore: reduce spacing between tabbar header and grid header
c6cecee fix: update field type
65f4132 fix: cannot edit view name
60120e5 fix: title for select field type bottom sheet
cbcb8d2 fix: forget checks, just do it

📊 Changes

11 files changed (+237 additions, -222 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/mobile/presentation/database/card/card_detail/widgets/mobile_create_field_button.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/card/card_detail/widgets/option_text_field.dart (+28 -13)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_edit_field_screen.dart (+19 -3)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_bottom_sheets.dart (+40 -26)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_full_field_editor.dart (+17 -33)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_quick_field_editor.dart (+122 -139)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_field_list.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_view_quick_actions.dart (+5 -3)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/header/mobile_field_button.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/header/mobile_grid_header.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/tab_bar/mobile/mobile_tab_bar_header.dart (+1 -1)

📄 Description

no autofocus on name of field editor
tapping icon allows changing the type of the field
applies to both the bottom sheet popup and the full screen editor.
reduce spacing between toolbar and grid header
fix a bug where users can't update the name of a database view

screen recording TBD

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4738 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 2/26/2024 **Status:** ✅ Merged **Merged:** 2/26/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `chore/mobile-db-fixes` --- ### 📝 Commits (7) - [`668e79b`](https://github.com/AppFlowy-IO/AppFlowy/commit/668e79b22b4ab1b2b33ba80846b0507b6dd0f82d) chore: no autofocus on field name - [`87b53ce`](https://github.com/AppFlowy-IO/AppFlowy/commit/87b53ce97cff04a41b7454ad31e3d90c57378324) refactor: one, two, many - [`98e3e44`](https://github.com/AppFlowy-IO/AppFlowy/commit/98e3e44d1f21f211e87da47d076fdc606a854058) chore: reduce spacing between tabbar header and grid header - [`c6cecee`](https://github.com/AppFlowy-IO/AppFlowy/commit/c6cecee77f9c4ed121f0617b687ac0d085a46a10) fix: update field type - [`65f4132`](https://github.com/AppFlowy-IO/AppFlowy/commit/65f4132d3b9bc015ee2e6497746da7656c3fa04e) fix: cannot edit view name - [`60120e5`](https://github.com/AppFlowy-IO/AppFlowy/commit/60120e5f160b3616d80c88c22b7fa19b2228fa2f) fix: title for select field type bottom sheet - [`cbcb8d2`](https://github.com/AppFlowy-IO/AppFlowy/commit/cbcb8d2304460918c119a8186cc5970146ce109d) fix: forget checks, just do it ### 📊 Changes **11 files changed** (+237 additions, -222 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/card/card_detail/widgets/mobile_create_field_button.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/card/card_detail/widgets/option_text_field.dart` (+28 -13) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_edit_field_screen.dart` (+19 -3) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_bottom_sheets.dart` (+40 -26) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_full_field_editor.dart` (+17 -33) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_quick_field_editor.dart` (+122 -139) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_field_list.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_view_quick_actions.dart` (+5 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/header/mobile_field_button.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/header/mobile_grid_header.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/tab_bar/mobile/mobile_tab_bar_header.dart` (+1 -1) </details> ### 📄 Description - no autofocus on name of field editor - tapping icon allows changing the type of the field - applies to both the bottom sheet popup and the full screen editor. - reduce spacing between toolbar and grid header - fix a bug where users can't update the name of a database view screen recording TBD ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>