[PR #4784] [MERGED] feat: checklist UX improvement #6438

Closed
opened 2026-03-23 22:23:13 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4784
Author: @richardshiue
Created: 2/29/2024
Status: Merged
Merged: 3/2/2024
Merged by: @richardshiue

Base: mainHead: feat/checklist-editor-improvement


📝 Commits (1)

  • 13800d5 feat: checklist UX improvement

📊 Changes

8 files changed (+168 additions, -124 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/checklist_cell_bloc.dart (+20 -30)
frontend/appflowy_flutter/lib/plugins/database/application/cell/relation_cell_service.dart (+0 -0)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/card_cell_skeleton/checklist_card_cell.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_row_detail/desktop_row_detail_checklist_cell.dart (+13 -10)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/editable_cell_skeleton/checklist.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/checklist_cell_editor.dart (+122 -72)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/mobile_checklist_cell_editor.dart (+2 -2)
📝 frontend/appflowy_flutter/packages/appflowy_popover/lib/src/popover.dart (+9 -8)

📄 Description

Add keyboard navigation to checklist cell editor. text field refers to the place where the name of the task is changed. item refers to the entire checklist task, comprised of the checkbox, text field and delete button.

  • Space when item is focused to select/unselect
  • Delete when item is focused to delete
  • Enter when item is focused to start editing (give focus to the text field)
  • Cmd/Ctrl + Enter when item is focused OR text field is focused to select/unselect
  • Esc when text field is focused to stop editing

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4784 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 2/29/2024 **Status:** ✅ Merged **Merged:** 3/2/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `feat/checklist-editor-improvement` --- ### 📝 Commits (1) - [`13800d5`](https://github.com/AppFlowy-IO/AppFlowy/commit/13800d5efbe5cad515cba014e7e9ab9afdbe1dc0) feat: checklist UX improvement ### 📊 Changes **8 files changed** (+168 additions, -124 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/checklist_cell_bloc.dart` (+20 -30) ➖ `frontend/appflowy_flutter/lib/plugins/database/application/cell/relation_cell_service.dart` (+0 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/card_cell_skeleton/checklist_card_cell.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_row_detail/desktop_row_detail_checklist_cell.dart` (+13 -10) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/editable_cell_skeleton/checklist.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/checklist_cell_editor.dart` (+122 -72) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/mobile_checklist_cell_editor.dart` (+2 -2) 📝 `frontend/appflowy_flutter/packages/appflowy_popover/lib/src/popover.dart` (+9 -8) </details> ### 📄 Description Add keyboard navigation to checklist cell editor. `text field` refers to the place where the name of the task is changed. `item` refers to the entire checklist task, comprised of the checkbox, text field and delete button. - Space when item is focused to select/unselect - Delete when item is focused to delete - Enter when item is focused to start editing (give focus to the text field) - Cmd/Ctrl + Enter when item is focused OR text field is focused to select/unselect - Esc when text field is focused to stop editing ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:23:13 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#6438
No description provided.