AppFlowy-IO/AppFlowy

Fork 0

mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2026-03-24 04:46:56 +00:00

[GH-ISSUE #1678] [FR] Make behavior of deleting currently-viewed page consistent #644

New issue

Open

opened 2026-03-23 20:39:10 +00:00 by mirror · 9 comments

mirror commented

2026-03-23 20:39:10 +00:00

Owner

Originally created by @richardshiue on GitHub (Jan 7, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/1678

Originally assigned to: @mak2002 on GitHub.

Description

When the currently-viewed page is deleted, there are two possible behaviors. For documents, a banner appears at the top of the page indicating that the document has been moved to the trash. For database-related views, (i.e. table-view and kanban board), the current page closes and replaced by last previously opened page. It would be better if we chose one and roll with it for all views.

Impact

All users

Additional Context

No response

Originally created by @richardshiue on GitHub (Jan 7, 2023). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/1678 Originally assigned to: @mak2002 on GitHub. ### Description When the currently-viewed page is deleted, there are two possible behaviors. For documents, a banner appears at the top of the page indicating that the document has been moved to the trash. For database-related views, (i.e. table-view and kanban board), the current page closes and replaced by last previously opened page. It would be better if we chose one and roll with it for all views. ### Impact All users ### Additional Context _No response_

mirror added the

editor

2024

good first issue for devs

improvements

help wanted

labels

2026-03-23 20:39:10 +00:00

mirror commented

2026-03-23 20:39:11 +00:00

Author

Owner

@annieappflowy commented on GitHub (Jan 8, 2023):

v0.1 will integrate database views into the editor so let's check the consistency once it's released

@annieappflowy commented on GitHub (Jan 8, 2023): v0.1 will integrate database views into the editor so let's check the consistency once it's released

mirror commented

2026-03-23 20:39:11 +00:00

Author

Owner

@bijaykumarpun commented on GitHub (Mar 20, 2023):

@annieappflowy The behaviour is inconsistent even in v1.0.0.

Btw what's the expected behaviour here? Do we expect the same dialog like in the Document to appear for Grid and Board as well?

Recording

https://user-images.githubusercontent.com/13991373/226326205-565ab6b3-ae10-4e05-a998-90993e1b054e.mov

Thanks!

@bijaykumarpun commented on GitHub (Mar 20, 2023): @annieappflowy The behaviour is inconsistent even in v1.0.0. Btw what's the expected behaviour here? Do we expect the same dialog like in the `Document` to appear for `Grid` and `Board` as well? > Recording https://user-images.githubusercontent.com/13991373/226326205-565ab6b3-ae10-4e05-a998-90993e1b054e.mov <br> Thanks!

mirror commented

2026-03-23 20:39:12 +00:00

Author

Owner

@annieappflowy commented on GitHub (Mar 20, 2023):

Expected behavior: After deleting a document, the current page closes and is replaced by last previously opened page

@annieappflowy commented on GitHub (Mar 20, 2023): Expected behavior: After deleting a document, the current page closes and is replaced by last previously opened page

mirror commented

2026-03-23 20:39:12 +00:00

Author

Owner

@bijaykumarpun commented on GitHub (Mar 20, 2023):

@annieappflowy Does this behaviour apply to all page types ? Or for Grid and Board only (?), since Document already has the dialog implemented.

@bijaykumarpun commented on GitHub (Mar 20, 2023): @annieappflowy Does this behaviour apply to all page types ? Or for `Grid` and `Board` only (?), since `Document` already has the dialog implemented.

mirror commented

2026-03-23 20:39:12 +00:00

Author

Owner

@annieappflowy commented on GitHub (Jul 11, 2023):

Sorry for missing your comment. Would you like to continue to work on it?
Expected:
after the deletion, a banner shows up at the top for a few seconds then the deleted page should be replaced by last previously opened page. This applies to all types (Grid, Board, and Document)

@annieappflowy commented on GitHub (Jul 11, 2023): Sorry for missing your comment. Would you like to continue to work on it? Expected: after the deletion, a banner shows up at the top for a few seconds then the deleted page should be replaced by last previously opened page. This applies to all types (Grid, Board, and Document)

mirror commented

2026-03-23 20:39:12 +00:00

Author

Owner

@mak2002 commented on GitHub (Dec 9, 2023):

Hey there, I would love to fix this issue!

@mak2002 commented on GitHub (Dec 9, 2023): Hey there, I would love to fix this issue!

mirror commented

2026-03-23 20:39:13 +00:00

Author

Owner

@annieappflowy commented on GitHub (Dec 16, 2023):

Hi @mak2002 , thanks for the help! You can ask @richardshiue or @Xazin for help

@annieappflowy commented on GitHub (Dec 16, 2023): Hi @mak2002 , thanks for the help! You can ask @richardshiue or @Xazin for help

mirror commented

2026-03-23 20:39:13 +00:00

Author

Owner

@mak2002 commented on GitHub (Dec 24, 2023):

Hey there @Xazin , I am a new contributor in AppFlowy 😄

As of now after we delete a document, it loads the last document instead of previously opened page. We are emitting an event for this here: deletion event. I'm curious if we store the ID of the previously opened page somewhere in our code. Could you provide some pointers on how to address this issue?

Thank you!

@mak2002 commented on GitHub (Dec 24, 2023): Hey there @Xazin , I am a new contributor in AppFlowy 😄 As of now after we delete a document, it loads the last document instead of previously opened page. We are emitting an event for this here: [deletion event](https://github.com/AppFlowy-IO/AppFlowy/blob/main/frontend/appflowy_flutter/lib/plugins/document/application/doc_bloc.dart#L99-L103). I'm curious if we store the ID of the previously opened page somewhere in our code. Could you provide some pointers on how to address this issue? Thank you!

mirror commented

2026-03-23 20:39:13 +00:00

Author

Owner

@rileyhawk1417 commented on GitHub (Jan 23, 2025):

As of 0.8.1 when deleting a grid/kanban the delete banner does not show, it only shows up in the document. Instead the pages are still visible but the user is just moved to the trash section.

https://github.com/user-attachments/assets/b0b1277a-2e2d-474b-9657-d27d91d105b0

@rileyhawk1417 commented on GitHub (Jan 23, 2025): As of 0.8.1 when deleting a grid/kanban the delete banner does not show, it only shows up in the document. Instead the pages are still visible but the user is just moved to the trash section. https://github.com/user-attachments/assets/b0b1277a-2e2d-474b-9657-d27d91d105b0

mirror referenced this issue

2026-03-23 21:37:01 +00:00

[PR #644] [MERGED] Feat: insert text at cursor #4257