[PR #4797] [MERGED] fix: launch url on all platforms #6449

New issue

Closed

opened 2026-03-23 22:23:16 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:23:16 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4797
Author: @Xazin
Created: 3/3/2024
Status: ✅ Merged
Merged: 3/3/2024
Merged by: @Xazin

Base: main ← Head: fix/launch-url

📝 Commits (3)

f4a45cd fix: error handled launchUrl
9dc7f3a chore: update links to use new subdomain
8c0bba1 feat: show toast if onFailure is not provided

📊 Changes

24 files changed (+179 additions, -152 deletions)

View changed files

➕ frontend/appflowy_flutter/lib/core/helpers/url_launcher.dart (+50 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/setting/about/about_setting_group.dart (+5 -4)
📝 frontend/appflowy_flutter/lib/mobile/presentation/setting/support_setting_group.dart (+5 -4)
📝 frontend/appflowy_flutter/lib/mobile/presentation/widgets/flowy_mobile_state_container.dart (+5 -4)
📝 frontend/appflowy_flutter/lib/plugins/database/application/cell/cell_cache.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/application/row/row_cache.dart (+4 -2)
📝 frontend/appflowy_flutter/lib/plugins/database/application/view/view_cache.dart (+4 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_grid/desktop_grid_url_cell.dart (+6 -5)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_grid/mobile_grid_url_cell.dart (+5 -4)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_row_detail/mobile_row_detail_url_cell.dart (+5 -4)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/link_preview/custom_link_preview.dart (+4 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/openai/util/learn_more_action.dart (+5 -7)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_style.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/user/application/auth/af_cloud_auth_service.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/user/presentation/screens/skip_log_in_screen.dart (+7 -15)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/errors/workspace_failed_screen.dart (+5 -4)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/toast.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/setting_appflowy_cloud.dart (+6 -14)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/setting_file_import_appflowy_data_view.dart (+6 -14)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/setting_supabase_cloud.dart (+7 -15)

...and 4 more files

📄 Description

Closes: #3060

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

I haven't been able to test that this will work on Fedora / running AF in Flatpak.

Previously we used a helper function imported via appflowy_editor, this helper function should made private and only be used in the editor itself. It's safeLaunchUrl.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4797 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 3/3/2024 **Status:** ✅ Merged **Merged:** 3/3/2024 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `fix/launch-url` --- ### 📝 Commits (3) - [`f4a45cd`](https://github.com/AppFlowy-IO/AppFlowy/commit/f4a45cd42177be88a79df8f464c23285440f236e) fix: error handled launchUrl - [`9dc7f3a`](https://github.com/AppFlowy-IO/AppFlowy/commit/9dc7f3a0cdaf68377f68ad3360eb56a9f655679f) chore: update links to use new subdomain - [`8c0bba1`](https://github.com/AppFlowy-IO/AppFlowy/commit/8c0bba1011a291c7c8b3a7cdefffd224a3296fd1) feat: show toast if onFailure is not provided ### 📊 Changes **24 files changed** (+179 additions, -152 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/lib/core/helpers/url_launcher.dart` (+50 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/setting/about/about_setting_group.dart` (+5 -4) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/setting/support_setting_group.dart` (+5 -4) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/widgets/flowy_mobile_state_container.dart` (+5 -4) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/cell/cell_cache.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/row/row_cache.dart` (+4 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/view/view_cache.dart` (+4 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_grid/desktop_grid_url_cell.dart` (+6 -5) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_grid/mobile_grid_url_cell.dart` (+5 -4) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_row_detail/mobile_row_detail_url_cell.dart` (+5 -4) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/link_preview/custom_link_preview.dart` (+4 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/openai/util/learn_more_action.dart` (+5 -7) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_style.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/user/application/auth/af_cloud_auth_service.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/user/presentation/screens/skip_log_in_screen.dart` (+7 -15) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/errors/workspace_failed_screen.dart` (+5 -4) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/toast.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/setting_appflowy_cloud.dart` (+6 -14) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/setting_file_import_appflowy_data_view.dart` (+6 -14) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/setting_supabase_cloud.dart` (+7 -15) _...and 4 more files_ </details> ### 📄 Description Closes: #3060 #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- I haven't been able to test that this will work on Fedora / running AF in Flatpak. Previously we used a helper function imported via appflowy_editor, this helper function should made private and only be used in the editor itself. It's `safeLaunchUrl`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>