[PR #4802] [MERGED] fix: inline page reference update on workspace changes #6453

New issue

Closed

opened 2026-03-23 22:23:17 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:23:17 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4802
Author: @Xazin
Created: 3/3/2024
Status: ✅ Merged
Merged: 3/4/2024
Merged by: @Xazin

Base: main ← Head: feat/inline-page-ref-improvement

📝 Commits (1)

acb5e3a feat: implement disposal logic + workspace listener

📊 Changes

11 files changed (+111 additions, -38 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/link_to_page_widget.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/page_reference_commands.dart (+4 -3)
📝 frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/date_reference.dart (+6 -3)
📝 frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/inline_page_reference.dart (+63 -14)
📝 frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/reminder_reference.dart (+6 -3)
📝 frontend/appflowy_flutter/lib/plugins/inline_actions/inline_actions_command.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/inline_actions/inline_actions_service.dart (+5 -5)
➕ frontend/appflowy_flutter/lib/plugins/inline_actions/service_handler.dart (+7 -0)
📝 frontend/appflowy_flutter/lib/plugins/inline_actions/widgets/inline_actions_handler.dart (+4 -3)
📝 frontend/rust-lib/flowy-folder/src/manager.rs (+10 -1)

📄 Description

Closes: #3641

Feature Preview

https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/38b56061-9437-47a4-b358-45130e0f3da5

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4802 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 3/3/2024 **Status:** ✅ Merged **Merged:** 3/4/2024 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `feat/inline-page-ref-improvement` --- ### 📝 Commits (1) - [`acb5e3a`](https://github.com/AppFlowy-IO/AppFlowy/commit/acb5e3a7c33f80aa31dbfe61358fbdbfa0792003) feat: implement disposal logic + workspace listener ### 📊 Changes **11 files changed** (+111 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/link_to_page_widget.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/page_reference_commands.dart` (+4 -3) 📝 `frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/date_reference.dart` (+6 -3) 📝 `frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/inline_page_reference.dart` (+63 -14) 📝 `frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/reminder_reference.dart` (+6 -3) 📝 `frontend/appflowy_flutter/lib/plugins/inline_actions/inline_actions_command.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/inline_actions/inline_actions_service.dart` (+5 -5) ➕ `frontend/appflowy_flutter/lib/plugins/inline_actions/service_handler.dart` (+7 -0) 📝 `frontend/appflowy_flutter/lib/plugins/inline_actions/widgets/inline_actions_handler.dart` (+4 -3) 📝 `frontend/rust-lib/flowy-folder/src/manager.rs` (+10 -1) </details> ### 📄 Description Closes: #3641 ### Feature Preview https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/38b56061-9437-47a4-b358-45130e0f3da5 #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>