[PR #4807] [MERGED] refactor: create row workflow #6456

New issue

Closed

opened 2026-03-23 22:23:18 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:23:18 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4807
Author: @richardshiue
Created: 3/4/2024
Status: ✅ Merged
Merged: 3/14/2024
Merged by: @appflowy

Base: main ← Head: feat/fill-row-cells-with-filter-data

📝 Commits (1)

3baa432 refactor: streamline create row logic

📊 Changes

21 files changed (+155 additions, -200 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database/application/row/row_service.dart (+1 -7)
📝 frontend/appflowy_tauri/src/appflowy_app/application/database/row/row_service.ts (+1 -1)
📝 frontend/rust-lib/event-integration/src/database_event.rs (+3 -2)
📝 frontend/rust-lib/flowy-database2/src/entities/row_entities.rs (+10 -29)
📝 frontend/rust-lib/flowy-database2/src/event_handler.rs (+5 -23)
📝 frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs (+43 -27)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs (+44 -28)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_filter.rs (+1 -1)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_group.rs (+1 -1)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_operation.rs (+1 -1)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_sort.rs (+1 -1)
📝 frontend/rust-lib/flowy-database2/src/services/filter/controller.rs (+7 -11)
📝 frontend/rust-lib/flowy-database2/src/services/group/configuration.rs (+2 -2)
📝 frontend/rust-lib/flowy-database2/src/services/group/controller.rs (+1 -2)
📝 frontend/rust-lib/flowy-database2/src/services/group/controller_impls/default_controller.rs (+1 -3)
📝 frontend/rust-lib/flowy-database2/src/services/group/group_builder.rs (+3 -6)
📝 frontend/rust-lib/flowy-database2/src/services/sort/controller.rs (+5 -7)
📝 frontend/rust-lib/flowy-database2/tests/database/block_test/script.rs (+4 -11)
📝 frontend/rust-lib/flowy-database2/tests/database/group_test/date_group_test.rs (+8 -14)
📝 frontend/rust-lib/flowy-database2/tests/database/group_test/script.rs (+8 -13)

...and 1 more files

📄 Description

requires https://github.com/AppFlowy-IO/AppFlowy/pull/4688

Move some fragmented create row logic from event handler to database editor
Streamline row duplication logic
Remove unnecessary Arc<Field>. The filter, sort and group controllers already are Arcs, and in the instances where we use the struct field, we are just referencing it. So we probably don't need to put it in an Arc.

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4807 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 3/4/2024 **Status:** ✅ Merged **Merged:** 3/14/2024 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `feat/fill-row-cells-with-filter-data` --- ### 📝 Commits (1) - [`3baa432`](https://github.com/AppFlowy-IO/AppFlowy/commit/3baa432309277efe32a9952adeba99316300778e) refactor: streamline create row logic ### 📊 Changes **21 files changed** (+155 additions, -200 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database/application/row/row_service.dart` (+1 -7) 📝 `frontend/appflowy_tauri/src/appflowy_app/application/database/row/row_service.ts` (+1 -1) 📝 `frontend/rust-lib/event-integration/src/database_event.rs` (+3 -2) 📝 `frontend/rust-lib/flowy-database2/src/entities/row_entities.rs` (+10 -29) 📝 `frontend/rust-lib/flowy-database2/src/event_handler.rs` (+5 -23) 📝 `frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs` (+43 -27) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs` (+44 -28) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_filter.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_group.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_operation.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_sort.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/filter/controller.rs` (+7 -11) 📝 `frontend/rust-lib/flowy-database2/src/services/group/configuration.rs` (+2 -2) 📝 `frontend/rust-lib/flowy-database2/src/services/group/controller.rs` (+1 -2) 📝 `frontend/rust-lib/flowy-database2/src/services/group/controller_impls/default_controller.rs` (+1 -3) 📝 `frontend/rust-lib/flowy-database2/src/services/group/group_builder.rs` (+3 -6) 📝 `frontend/rust-lib/flowy-database2/src/services/sort/controller.rs` (+5 -7) 📝 `frontend/rust-lib/flowy-database2/tests/database/block_test/script.rs` (+4 -11) 📝 `frontend/rust-lib/flowy-database2/tests/database/group_test/date_group_test.rs` (+8 -14) 📝 `frontend/rust-lib/flowy-database2/tests/database/group_test/script.rs` (+8 -13) _...and 1 more files_ </details> ### 📄 Description requires https://github.com/AppFlowy-IO/AppFlowy/pull/4688 - Move some fragmented create row logic from event handler to database editor - Streamline row duplication logic - Remove unnecessary Arc\<Field>. The filter, sort and group controllers already are Arcs, and in the instances where we use the struct field, we are just referencing it. So we probably don't need to put it in an Arc. ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>