[PR #4826] [MERGED] fix: image url check for embed link #6471

New issue

Closed

opened 2026-03-23 22:23:22 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:23:22 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4826
Author: @Xazin
Created: 3/5/2024
Status: ✅ Merged
Merged: 3/6/2024
Merged by: @Xazin

Base: main ← Head: fix/embed-link-validation

📝 Commits (3)

1f562c3 fix: image url check in for embed link
2d1a53e chore: move all patterns to shared
72f1f17 test: prefer enterText over manipulating widget

📊 Changes

13 files changed (+104 additions, -75 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/shared/editor_test_operations.dart (+4 -4)
📝 frontend/appflowy_flutter/lib/mobile/presentation/setting/font/font_picker_screen.dart (+9 -14)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/calculations/calculate_cell.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/copy_and_paste/paste_from_plain_text.dart (+3 -6)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/embed_image_url_widget.dart (+23 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/_font_item.dart (+2 -1)
➕ frontend/appflowy_flutter/lib/shared/patterns/common_patterns.dart (+23 -0)
➕ frontend/appflowy_flutter/lib/shared/patterns/date_time_patterns.dart (+19 -0)
📝 frontend/appflowy_flutter/lib/util/google_font_family_extension.dart (+4 -5)
📝 frontend/appflowy_flutter/lib/util/string_extension.dart (+4 -4)
📝 frontend/appflowy_flutter/lib/workspace/application/settings/application_data_storage.dart (+4 -2)
➖ frontend/appflowy_flutter/lib/workspace/application/settings/date_time/time_patterns.dart (+0 -18)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/font_family_setting.dart (+6 -15)

📄 Description

Closes: #2294

Feature Preview

https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/d8f5b348-8839-4861-9464-c59680cc4d32

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4826 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 3/5/2024 **Status:** ✅ Merged **Merged:** 3/6/2024 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `fix/embed-link-validation` --- ### 📝 Commits (3) - [`1f562c3`](https://github.com/AppFlowy-IO/AppFlowy/commit/1f562c3a4df76a5d904b7b110a5db39e3f16191f) fix: image url check in for embed link - [`2d1a53e`](https://github.com/AppFlowy-IO/AppFlowy/commit/2d1a53e7a20fc116e815456ba7638cf60a871db0) chore: move all patterns to shared - [`72f1f17`](https://github.com/AppFlowy-IO/AppFlowy/commit/72f1f171222db878e9e3a36d43a4dbe72f510351) test: prefer enterText over manipulating widget ### 📊 Changes **13 files changed** (+104 additions, -75 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/shared/editor_test_operations.dart` (+4 -4) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/setting/font/font_picker_screen.dart` (+9 -14) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/calculations/calculate_cell.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/copy_and_paste/paste_from_plain_text.dart` (+3 -6) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/embed_image_url_widget.dart` (+23 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/_font_item.dart` (+2 -1) ➕ `frontend/appflowy_flutter/lib/shared/patterns/common_patterns.dart` (+23 -0) ➕ `frontend/appflowy_flutter/lib/shared/patterns/date_time_patterns.dart` (+19 -0) 📝 `frontend/appflowy_flutter/lib/util/google_font_family_extension.dart` (+4 -5) 📝 `frontend/appflowy_flutter/lib/util/string_extension.dart` (+4 -4) 📝 `frontend/appflowy_flutter/lib/workspace/application/settings/application_data_storage.dart` (+4 -2) ➖ `frontend/appflowy_flutter/lib/workspace/application/settings/date_time/time_patterns.dart` (+0 -18) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/font_family_setting.dart` (+6 -15) </details> ### 📄 Description Closes: #2294 ### Feature Preview https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/d8f5b348-8839-4861-9464-c59680cc4d32 #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>