[PR #4855] [MERGED] fix: launch review 0.5.1 #6490

New issue

Closed

opened 2026-03-23 22:23:27 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:23:27 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4855
Author: @Xazin
Created: 3/8/2024
Status: ✅ Merged
Merged: 3/11/2024
Merged by: @Xazin

Base: main ← Head: fix/launch-review-0.5.1

📝 Commits (10+)

7da9f90 feat: floating calculations row
1f77214 fix: calculate cell overflow + tooltip
8f00103 fix: empty text cell should be counted as empty
8d14e70 fix: empty text cell sohuld not be counted as not empty
7c8f89d fix: conversion of some field types for calculations
5a7c600 fix: tooltip + size of duplicate event button
8942904 fix: minor view meta info changes
c861c6e fix: apply number format on word/char count
120acca fix: dart format
040829b fix: hide arrow for calc values

📊 Changes

12 files changed (+399 additions, -227 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database/calendar/presentation/calendar_event_editor.dart (+16 -9)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/application/calculations/field_type_calc_ext.dart (+9 -3)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/grid_page.dart (+133 -50)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/calculations/calculate_cell.dart (+83 -26)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/calculations/calculations_row.dart (+8 -2)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/more_view_actions/more_view_actions.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/more_view_actions/widgets/view_meta_info.dart (+11 -2)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/scrolling/styled_scroll_bar.dart (+59 -48)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/scrolling/styled_scrollview.dart (+24 -54)
📝 frontend/resources/translations/en.json (+6 -5)
📝 frontend/rust-lib/flowy-database2/src/entities/calculation/calculation_entities.rs (+6 -1)
📝 frontend/rust-lib/flowy-database2/src/services/calculations/service.rs (+43 -26)

📄 Description

Floating calculations so that they're always visible / available (see preview)
Wrapped Calculate cell in a Horizontal ScrollView to avoid overflow, for reference see Notions implementation (see preview)
Fixed issues with count (not) empty calculations
Made some changes to the duplicate calendar event icon button
Improved readability of the View Meta Info (see preview)
Hid the "arrow down" on calculation cells that already have a chosen calculation (UI Gimmick, you can still select another calculation type by pressing on the cell)

Feature Preview

Floating calculations

https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/1a356725-b1c8-481b-96b9-c464aff2d242

Calculate cell improvement

The tooltip is only showing if some of the calculate cell is hidden/obscured, notice that you can't scroll in the calculate cell, it's purely a UI gimmick.

https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/4475cb5a-0af0-4558-b622-93bf6e1923aa

View meta info

Hide arrow for calc values

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4855 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 3/8/2024 **Status:** ✅ Merged **Merged:** 3/11/2024 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `fix/launch-review-0.5.1` --- ### 📝 Commits (10+) - [`7da9f90`](https://github.com/AppFlowy-IO/AppFlowy/commit/7da9f90f6a0fad8cdcf4baa9d1b128d31891f3d6) feat: floating calculations row - [`1f77214`](https://github.com/AppFlowy-IO/AppFlowy/commit/1f77214965bfe9102a373793231f8142870a4663) fix: calculate cell overflow + tooltip - [`8f00103`](https://github.com/AppFlowy-IO/AppFlowy/commit/8f00103886b54bc71feb85246f2363995bcdb165) fix: empty text cell should be counted as empty - [`8d14e70`](https://github.com/AppFlowy-IO/AppFlowy/commit/8d14e70f33467f08dd1e500081bd3c2bc9db35ce) fix: empty text cell sohuld not be counted as not empty - [`7c8f89d`](https://github.com/AppFlowy-IO/AppFlowy/commit/7c8f89dbd4f745f4e550b01532564f4a6997ad28) fix: conversion of some field types for calculations - [`5a7c600`](https://github.com/AppFlowy-IO/AppFlowy/commit/5a7c600d0a9875cca1f5a70c5965f565786b7d6d) fix: tooltip + size of duplicate event button - [`8942904`](https://github.com/AppFlowy-IO/AppFlowy/commit/8942904ab6eaff6c9ee3678575e093b719c41b47) fix: minor view meta info changes - [`c861c6e`](https://github.com/AppFlowy-IO/AppFlowy/commit/c861c6eb4e122076c2fe7be4120c08ea1740b9ff) fix: apply number format on word/char count - [`120acca`](https://github.com/AppFlowy-IO/AppFlowy/commit/120accaa43581e44bd4f687bc3a3939078165c95) fix: dart format - [`040829b`](https://github.com/AppFlowy-IO/AppFlowy/commit/040829ba4050861f598c884a10be65407f330bb1) fix: hide arrow for calc values ### 📊 Changes **12 files changed** (+399 additions, -227 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database/calendar/presentation/calendar_event_editor.dart` (+16 -9) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/application/calculations/field_type_calc_ext.dart` (+9 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/grid_page.dart` (+133 -50) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/calculations/calculate_cell.dart` (+83 -26) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/calculations/calculations_row.dart` (+8 -2) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/more_view_actions/more_view_actions.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/more_view_actions/widgets/view_meta_info.dart` (+11 -2) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/scrolling/styled_scroll_bar.dart` (+59 -48) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/scrolling/styled_scrollview.dart` (+24 -54) 📝 `frontend/resources/translations/en.json` (+6 -5) 📝 `frontend/rust-lib/flowy-database2/src/entities/calculation/calculation_entities.rs` (+6 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/calculations/service.rs` (+43 -26) </details> ### 📄 Description - Floating calculations so that they're always visible / available _(see preview)_ - Wrapped Calculate cell in a Horizontal ScrollView to avoid overflow, for reference see Notions implementation _(see preview)_ - Fixed issues with count (not) empty calculations - Made some changes to the duplicate calendar event icon button - Improved readability of the View Meta Info _(see preview)_ - Hid the "arrow down" on calculation cells that already have a chosen calculation _(UI Gimmick, you can still select another calculation type by pressing on the cell)_ ## Feature Preview ### Floating calculations https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/1a356725-b1c8-481b-96b9-c464aff2d242 ### Calculate cell improvement The tooltip is only showing if some of the calculate cell is hidden/obscured, notice that you _can't_ scroll in the calculate cell, it's purely a UI gimmick. https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/4475cb5a-0af0-4558-b622-93bf6e1923aa ### View meta info <img width="234" alt="Screenshot 2024-03-08 at 18 54 46" src="https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/53351be4-a6aa-48b9-be76-5d6a5f0a02f6"> ### Hide arrow for calc values <img width="518" alt="Screenshot 2024-03-08 at 21 43 14" src="https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/a0dd6743-8ed4-4349-a49d-868eb63bbb68"> --- ## PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>