[PR #4854] [MERGED] feat: pre-fill row cells with filter data before row creation #6492

New issue

Closed

opened 2026-03-23 22:23:28 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:23:28 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4854
Author: @richardshiue
Created: 3/8/2024
Status: ✅ Merged
Merged: 3/16/2024
Merged by: @richardshiue

Base: main ← Head: feat/fill-row-cells-with-filter-data3

📝 Commits (7)

002ad03 feat: fill cells according to active filters
d11e753 chore: short circuit filter_row function
cf149df chore: delete corresponding filters when filtered filter is deleted
f96010c chore: validate filters when loading
192a056 chore: remove unnecessary tuple in return
238e1c4 chore: use trait
c81c763 chore: add tests

📊 Changes

23 files changed (+1546 additions, -173 deletions)

View changed files

📝 frontend/rust-lib/flowy-database2/src/entities/filter_entities/checklist_filter.rs (+2 -3)
📝 frontend/rust-lib/flowy-database2/src/entities/filter_entities/relation_filter.rs (+8 -1)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs (+9 -3)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_filter.rs (+4 -2)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/checkbox_type_option/checkbox_filter.rs (+18 -0)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/checklist_type_option/checklist_filter.rs (+10 -0)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_filter.rs (+39 -3)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/number_type_option/number_filter.rs (+37 -0)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/selection_type_option/select_filter.rs (+40 -1)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/text_type_option/text_filter.rs (+24 -0)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/type_option.rs (+2 -2)
📝 frontend/rust-lib/flowy-database2/src/services/filter/controller.rs (+245 -121)
📝 frontend/rust-lib/flowy-database2/src/services/filter/entities.rs (+63 -10)
📝 frontend/rust-lib/flowy-database2/src/services/sort/controller.rs (+1 -0)
📝 frontend/rust-lib/flowy-database2/tests/database/database_editor.rs (+4 -3)
📝 frontend/rust-lib/flowy-database2/tests/database/field_test/test.rs (+14 -16)
📝 frontend/rust-lib/flowy-database2/tests/database/filter_test/select_option_filter_test.rs (+2 -2)
📝 frontend/rust-lib/flowy-database2/tests/database/mock_data/grid_mock_data.rs (+0 -4)
📝 frontend/rust-lib/flowy-database2/tests/database/mod.rs (+2 -2)
➕ frontend/rust-lib/flowy-database2/tests/database/pre_fill_cell_test/mod.rs (+3 -0)

...and 3 more files

📄 Description

a tech design write up is in the gantt

resolves https://github.com/AppFlowy-IO/AppFlowy/issues/4468
resolves https://github.com/AppFlowy-IO/AppFlowy/issues/4330

https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/94aab595-9a22-45aa-a688-fae4dccf4053

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4854 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 3/8/2024 **Status:** ✅ Merged **Merged:** 3/16/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `feat/fill-row-cells-with-filter-data3` --- ### 📝 Commits (7) - [`002ad03`](https://github.com/AppFlowy-IO/AppFlowy/commit/002ad033165ff54a98d5a201483357be389d3686) feat: fill cells according to active filters - [`d11e753`](https://github.com/AppFlowy-IO/AppFlowy/commit/d11e753e21ae6a38efc5d2ae7a685dc06dadada8) chore: short circuit filter_row function - [`cf149df`](https://github.com/AppFlowy-IO/AppFlowy/commit/cf149dfbee7e07647e2f9436ce667e2900aa8568) chore: delete corresponding filters when filtered filter is deleted - [`f96010c`](https://github.com/AppFlowy-IO/AppFlowy/commit/f96010cd4c2a616fd785e100d7b6ff449cddb3ff) chore: validate filters when loading - [`192a056`](https://github.com/AppFlowy-IO/AppFlowy/commit/192a05629fc521539c1dcfa9bd4bae3d727d38f2) chore: remove unnecessary tuple in return - [`238e1c4`](https://github.com/AppFlowy-IO/AppFlowy/commit/238e1c42ebbbd4010769d7e78ef7a539562156da) chore: use trait - [`c81c763`](https://github.com/AppFlowy-IO/AppFlowy/commit/c81c763d58145a89dda58e5717cd33e486ba009d) chore: add tests ### 📊 Changes **23 files changed** (+1546 additions, -173 deletions) <details> <summary>View changed files</summary> 📝 `frontend/rust-lib/flowy-database2/src/entities/filter_entities/checklist_filter.rs` (+2 -3) 📝 `frontend/rust-lib/flowy-database2/src/entities/filter_entities/relation_filter.rs` (+8 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs` (+9 -3) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_filter.rs` (+4 -2) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/checkbox_type_option/checkbox_filter.rs` (+18 -0) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/checklist_type_option/checklist_filter.rs` (+10 -0) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_filter.rs` (+39 -3) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/number_type_option/number_filter.rs` (+37 -0) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/selection_type_option/select_filter.rs` (+40 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/text_type_option/text_filter.rs` (+24 -0) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/type_option.rs` (+2 -2) 📝 `frontend/rust-lib/flowy-database2/src/services/filter/controller.rs` (+245 -121) 📝 `frontend/rust-lib/flowy-database2/src/services/filter/entities.rs` (+63 -10) 📝 `frontend/rust-lib/flowy-database2/src/services/sort/controller.rs` (+1 -0) 📝 `frontend/rust-lib/flowy-database2/tests/database/database_editor.rs` (+4 -3) 📝 `frontend/rust-lib/flowy-database2/tests/database/field_test/test.rs` (+14 -16) 📝 `frontend/rust-lib/flowy-database2/tests/database/filter_test/select_option_filter_test.rs` (+2 -2) 📝 `frontend/rust-lib/flowy-database2/tests/database/mock_data/grid_mock_data.rs` (+0 -4) 📝 `frontend/rust-lib/flowy-database2/tests/database/mod.rs` (+2 -2) ➕ `frontend/rust-lib/flowy-database2/tests/database/pre_fill_cell_test/mod.rs` (+3 -0) _...and 3 more files_ </details> ### 📄 Description a tech design write up is in the gantt resolves https://github.com/AppFlowy-IO/AppFlowy/issues/4468 resolves https://github.com/AppFlowy-IO/AppFlowy/issues/4330 https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/94aab595-9a22-45aa-a688-fae4dccf4053 ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>