[PR #4871] [MERGED] fix: only adding http(s) scheme if needed #6504

New issue

Closed

opened 2026-03-23 22:23:31 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:23:31 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4871
Author: @LucasXu0
Created: 3/11/2024
Status: ✅ Merged
Merged: 3/11/2024
Merged by: @LucasXu0

Base: main ← Head: fix_login_issue

📝 Commits (1)

2cc4b9d fix: only adding http(s) scheme if needed

📊 Changes

2 files changed (+30 additions, -11 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/core/helpers/url_launcher.dart (+24 -7)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_style.dart (+6 -4)

📄 Description

Feature Preview

Remove the logic that automatically adds the HTTP(S) scheme, because the launchUrl function will return false even when it successfully opens a URL the file:// scheme.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4871 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 3/11/2024 **Status:** ✅ Merged **Merged:** 3/11/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_login_issue` --- ### 📝 Commits (1) - [`2cc4b9d`](https://github.com/AppFlowy-IO/AppFlowy/commit/2cc4b9d41cc67d5aaa57643c3a0c1a52164cdd61) fix: only adding http(s) scheme if needed ### 📊 Changes **2 files changed** (+30 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/core/helpers/url_launcher.dart` (+24 -7) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_style.dart` (+6 -4) </details> ### 📄 Description   ### Feature Preview Remove the logic that automatically adds the HTTP(S) scheme, because the `launchUrl` function will return **false** even when it successfully opens a URL the `file://` scheme.  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>