[PR #4881] [MERGED] fix: fixed error while importing table from markdown #6511

New issue

Closed

opened 2026-03-23 22:23:33 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:23:33 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4881
Author: @Mukund-Tandon
Created: 3/12/2024
Status: ✅ Merged
Merged: 3/20/2024
Merged by: @LucasXu0

Base: main ← Head: importing_table_giving_error_markdown_3383

📝 Commits (6)

b4a5e49 fix: fixed error while importing table from markdown
012e164 test: added test for the changes made
453b0de Merge branch 'main' into importing_table_giving_error_markdown_3383
b59b358 fix: made changes from code review
c5d0cc9 Merge branch 'main' into importing_table_giving_error_markdown_3383
e5c5d9d chore: remove the force unwrap code

📊 Changes

3 files changed (+56 additions, -5 deletions)

View changed files

➕ frontend/appflowy_flutter/assets/test/workspaces/markdowns/markdown_with_table.md (+11 -0)
📝 frontend/appflowy_flutter/integration_test/desktop/uncategorized/import_files_test.dart (+40 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/application/document_data_pb_extension.dart (+5 -5)

📄 Description

Solves - #3383

Feature Preview

Before changes -

https://github.com/AppFlowy-IO/AppFlowy/assets/71614009/eed5d14e-a932-4de0-9267-7ade5558b057

After Changes -

https://github.com/AppFlowy-IO/AppFlowy/assets/71614009/4a367214-b73f-49a7-875f-3ae45b398559

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4881 **Author:** [@Mukund-Tandon](https://github.com/Mukund-Tandon) **Created:** 3/12/2024 **Status:** ✅ Merged **Merged:** 3/20/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `importing_table_giving_error_markdown_3383` --- ### 📝 Commits (6) - [`b4a5e49`](https://github.com/AppFlowy-IO/AppFlowy/commit/b4a5e49433ba11997e78c534621213c3871d0265) fix: fixed error while importing table from markdown - [`012e164`](https://github.com/AppFlowy-IO/AppFlowy/commit/012e16410680c9b4f93268aee27e3c62ac25f1a5) test: added test for the changes made - [`453b0de`](https://github.com/AppFlowy-IO/AppFlowy/commit/453b0deea300d58e1be1c30e1fea7a9ebee2f8be) Merge branch 'main' into importing_table_giving_error_markdown_3383 - [`b59b358`](https://github.com/AppFlowy-IO/AppFlowy/commit/b59b3583618d1fb6187ed019415f23fc9c12cae8) fix: made changes from code review - [`c5d0cc9`](https://github.com/AppFlowy-IO/AppFlowy/commit/c5d0cc9d70c193920856533abe8c722f7b54fd22) Merge branch 'main' into importing_table_giving_error_markdown_3383 - [`e5c5d9d`](https://github.com/AppFlowy-IO/AppFlowy/commit/e5c5d9d46219efc6e86b59795dc44f0768737505) chore: remove the force unwrap code ### 📊 Changes **3 files changed** (+56 additions, -5 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/assets/test/workspaces/markdowns/markdown_with_table.md` (+11 -0) 📝 `frontend/appflowy_flutter/integration_test/desktop/uncategorized/import_files_test.dart` (+40 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/application/document_data_pb_extension.dart` (+5 -5) </details> ### 📄 Description   Solves - #3383 ### Feature Preview Before changes - https://github.com/AppFlowy-IO/AppFlowy/assets/71614009/eed5d14e-a932-4de0-9267-7ade5558b057 After Changes - https://github.com/AppFlowy-IO/AppFlowy/assets/71614009/4a367214-b73f-49a7-875f-3ae45b398559  ---  #### PR Checklist - [X] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [X] I've listed at least one issue that this PR fixes in the description above. - [X] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>