[PR #4927] [MERGED] fix: legacy bugs on mobile #6535

Closed
opened 2026-03-23 22:23:39 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4927
Author: @LucasXu0
Created: 3/17/2024
Status: Merged
Merged: 3/18/2024
Merged by: @LucasXu0

Base: mainHead: main


📝 Commits (5)

  • 9bf1027 fix: close button and done button padding
  • e9404ce fix: color items padding
  • 986887d feat: customize floating toolbar actions on mobile
  • 030adb9 fix: close keyboard when click the ... button
  • db183e5 chore: update setting item padding

📊 Changes

15 files changed (+286 additions, -85 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/mobile/presentation/base/app_bar_actions.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/mobile/presentation/base/mobile_view_page.dart (+5 -5)
frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_buttons.dart (+82 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_header.dart (+4 -17)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/show_mobile_bottom_sheet.dart (+5 -5)
📝 frontend/appflowy_flutter/lib/mobile/presentation/setting/widgets/mobile_setting_item_widget.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/document_page.dart (+27 -32)
frontend/appflowy_flutter/lib/plugins/document/presentation/editor_notification.dart (+46 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+7 -14)
frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_floating_toolbar/custom_mobile_floating_toolbar.dart (+84 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/_color_list.dart (+9 -9)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/plugins.dart (+1 -0)
frontend/resources/flowy_icons/16x/m_bottom_sheet_close.svg (+5 -0)
frontend/resources/flowy_icons/24x/m_bottom_sheet_close.svg (+5 -0)
📝 frontend/resources/translations/en.json (+2 -0)

📄 Description

Feature Preview

  • customize floating toolbar actions on mobile
Screenshot 2024-03-16 at 23 14 40 Screenshot 2024-03-16 at 23 14 43
  • optimize color items and background color items
Screenshot 2024-03-16 at 23 14 57
  • optimize bottom sheet header
Screenshot 2024-03-17 at 16 59 43
  • settings page
Screenshot 2024-03-18 at 12 02 17

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4927 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 3/17/2024 **Status:** ✅ Merged **Merged:** 3/18/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (5) - [`9bf1027`](https://github.com/AppFlowy-IO/AppFlowy/commit/9bf102771eb527a9eca3a17b1fc97405435b1de6) fix: close button and done button padding - [`e9404ce`](https://github.com/AppFlowy-IO/AppFlowy/commit/e9404ce3aa7d09828acc3707b0a1c7ac00cd4137) fix: color items padding - [`986887d`](https://github.com/AppFlowy-IO/AppFlowy/commit/986887d64ca02fe445a6c711c5ac4a3eefb5aefa) feat: customize floating toolbar actions on mobile - [`030adb9`](https://github.com/AppFlowy-IO/AppFlowy/commit/030adb97a6b23df0faaaa38ad71f3342f4866e56) fix: close keyboard when click the ... button - [`db183e5`](https://github.com/AppFlowy-IO/AppFlowy/commit/db183e59cb3c86a856c2ad828f1e9905a673b32e) chore: update setting item padding ### 📊 Changes **15 files changed** (+286 additions, -85 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/mobile/presentation/base/app_bar_actions.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/base/mobile_view_page.dart` (+5 -5) ➕ `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_buttons.dart` (+82 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_header.dart` (+4 -17) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/show_mobile_bottom_sheet.dart` (+5 -5) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/setting/widgets/mobile_setting_item_widget.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/document_page.dart` (+27 -32) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_notification.dart` (+46 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+7 -14) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_floating_toolbar/custom_mobile_floating_toolbar.dart` (+84 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/_color_list.dart` (+9 -9) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/plugins.dart` (+1 -0) ➕ `frontend/resources/flowy_icons/16x/m_bottom_sheet_close.svg` (+5 -0) ➕ `frontend/resources/flowy_icons/24x/m_bottom_sheet_close.svg` (+5 -0) 📝 `frontend/resources/translations/en.json` (+2 -0) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview - customize floating toolbar actions on mobile <img width="546" alt="Screenshot 2024-03-16 at 23 14 40" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/f08d3abf-302a-4c90-9488-8b974e14554e"> <img width="546" alt="Screenshot 2024-03-16 at 23 14 43" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/28091617-8994-4c26-9295-16f24f68eb42"> - optimize color items and background color items <img width="546" alt="Screenshot 2024-03-16 at 23 14 57" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/5c4d2fee-04ac-4ad0-aa7b-9af016849a9b"> - optimize bottom sheet header <img width="401" alt="Screenshot 2024-03-17 at 16 59 43" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/ed18645a-fa8c-44b0-a342-c38475eab6de"> - settings page <img width="546" alt="Screenshot 2024-03-18 at 12 02 17" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/254a3b48-6d4e-4f3c-a1bd-1dafba4621ed"> <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:23:39 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#6535
No description provided.