[PR #4960] [MERGED] fix: launch review issues #6552

New issue

Closed

opened 2026-03-23 22:23:43 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:23:43 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4960
Author: @richardshiue
Created: 3/21/2024
Status: ✅ Merged
Merged: 3/22/2024
Merged by: @richardshiue

Base: main ← Head: fix/launch-review-issues

📝 Commits (3)

3ab68d7 fix: i18n for multi select condition list
5129a73 fix: lookup url cell content to assert validity
9ae3f3c fix: compromise checkmark color

📊 Changes

6 files changed (+66 additions, -25 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/url_cell_bloc.dart (+38 -6)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/filter/choicechip/select_option/condition_list.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/header/type_option/relation.dart (+1 -2)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/editable_cell_skeleton/url.dart (+21 -13)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/relation_cell_editor.dart (+1 -2)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text_field.dart (+3 -0)

📄 Description

https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/18c918a6-5e6a-4f24-9ef9-6dcd298545ac

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4960 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 3/21/2024 **Status:** ✅ Merged **Merged:** 3/22/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `fix/launch-review-issues` --- ### 📝 Commits (3) - [`3ab68d7`](https://github.com/AppFlowy-IO/AppFlowy/commit/3ab68d7ae1f44cb07965f98aed2af3ddf545a162) fix: i18n for multi select condition list - [`5129a73`](https://github.com/AppFlowy-IO/AppFlowy/commit/5129a73d15ab833ef993881c31a9e2db260363ff) fix: lookup url cell content to assert validity - [`9ae3f3c`](https://github.com/AppFlowy-IO/AppFlowy/commit/9ae3f3cdcc103ff1e1f4d0f161c509d05e13f7cc) fix: compromise checkmark color ### 📊 Changes **6 files changed** (+66 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/url_cell_bloc.dart` (+38 -6) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/filter/choicechip/select_option/condition_list.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/header/type_option/relation.dart` (+1 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/editable_cell_skeleton/url.dart` (+21 -13) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/relation_cell_editor.dart` (+1 -2) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text_field.dart` (+3 -0) </details> ### 📄 Description ![image](https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/b568ba8d-7681-4254-803c-5bfcea4ab556) https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/18c918a6-5e6a-4f24-9ef9-6dcd298545ac ![image](https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/4eedd75d-cf08-4719-a4c0-369938a94033) ### Feature Preview  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>