[PR #5062] [MERGED] fix: import panel exits on esc key (#4259) #6614

New issue

Closed

opened 2026-03-23 23:15:47 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:15:47 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5062
Author: @vishwa-0-karthik
Created: 4/4/2024
Status: ✅ Merged
Merged: 4/10/2024
Merged by: @LucasXu0

Base: main ← Head: main

📝 Commits (2)

1f8f1d5 fix: import panel exits on esc key (#4259)
16ceb7c Merge branch 'AppFlowy-IO:main' into main

📊 Changes

1 file changed (+54 additions, -32 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/import/import_panel.dart (+54 -32)

📄 Description

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added instructions to check how the fix works

Steps to check if the fix works:

Hover over a page in the side bar
Click on the + icon
Click on import, which causes a page to pop up
Now press the esc key to close the pop up

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5062 **Author:** [@vishwa-0-karthik](https://github.com/vishwa-0-karthik) **Created:** 4/4/2024 **Status:** ✅ Merged **Merged:** 4/10/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`1f8f1d5`](https://github.com/AppFlowy-IO/AppFlowy/commit/1f8f1d583e742a755c25c9234ce3ccd7769ae901) fix: import panel exits on esc key (#4259) - [`16ceb7c`](https://github.com/AppFlowy-IO/AppFlowy/commit/16ceb7cb4204f8c7654607de7ddbd7ddabd60ab8) Merge branch 'AppFlowy-IO:main' into main ### 📊 Changes **1 file changed** (+54 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/import/import_panel.dart` (+54 -32) </details> ### 📄 Description - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added instructions to check how the fix works Steps to check if the fix works: 1. Hover over a page in the side bar 2. Click on the + icon 3. Click on import, which causes a page to pop up 4. Now press the esc key to close the pop up --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>