[PR #5113] [MERGED] chore: remove single field listener #6652

New issue

Closed

opened 2026-03-23 23:16:03 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:16:03 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5113
Author: @richardshiue
Created: 4/11/2024
Status: ✅ Merged
Merged: 4/11/2024
Merged by: @richardshiue

Base: main ← Head: chore/remove-single-field-listener

📝 Commits (2)

6c8d4e0 chore: remove single field listener
e37012f chore: init field editor bloc

📊 Changes

16 files changed (+109 additions, -100 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/mobile/presentation/database/card/card_detail/mobile_card_detail_screen.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_quick_field_editor.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/relation_cell_bloc.dart (+5 -9)
📝 frontend/appflowy_flutter/lib/plugins/database/application/cell/cell_controller.dart (+6 -11)
📝 frontend/appflowy_flutter/lib/plugins/database/application/field/field_controller.dart (+45 -0)
📝 frontend/appflowy_flutter/lib/plugins/database/application/field/field_editor_bloc.dart (+34 -20)
📝 frontend/appflowy_flutter/lib/plugins/database/application/row/row_banner_bloc.dart (+6 -8)
📝 frontend/appflowy_flutter/lib/plugins/database/domain/field_listener.dart (+0 -43)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/field/field_editor.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/row/row_banner.dart (+4 -0)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/row/row_detail.dart (+1 -0)
📝 frontend/appflowy_flutter/test/bloc_test/board_test/create_or_edit_field_test.dart (+1 -1)
📝 frontend/appflowy_flutter/test/bloc_test/board_test/group_by_unsupport_field_test.dart (+1 -1)
📝 frontend/appflowy_flutter/test/bloc_test/board_test/util.dart (+1 -2)
📝 frontend/appflowy_flutter/test/bloc_test/grid_test/field/edit_field_test.dart (+1 -1)
📝 frontend/appflowy_flutter/test/bloc_test/grid_test/util.dart (+1 -2)

📄 Description

Remove SingleFieldListener and replace usage with FieldController's addSingleFieldListener callback which gets triggered on FieldInfo changes instead of only FieldPB changes

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5113 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 4/11/2024 **Status:** ✅ Merged **Merged:** 4/11/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `chore/remove-single-field-listener` --- ### 📝 Commits (2) - [`6c8d4e0`](https://github.com/AppFlowy-IO/AppFlowy/commit/6c8d4e01ab1d2c59155c83ee550547fad4c90c74) chore: remove single field listener - [`e37012f`](https://github.com/AppFlowy-IO/AppFlowy/commit/e37012f922f20a2494cae450858475a01399e977) chore: init field editor bloc ### 📊 Changes **16 files changed** (+109 additions, -100 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/card/card_detail/mobile_card_detail_screen.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_quick_field_editor.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/relation_cell_bloc.dart` (+5 -9) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/cell/cell_controller.dart` (+6 -11) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/field/field_controller.dart` (+45 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/field/field_editor_bloc.dart` (+34 -20) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/row/row_banner_bloc.dart` (+6 -8) 📝 `frontend/appflowy_flutter/lib/plugins/database/domain/field_listener.dart` (+0 -43) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/field/field_editor.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/row/row_banner.dart` (+4 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/row/row_detail.dart` (+1 -0) 📝 `frontend/appflowy_flutter/test/bloc_test/board_test/create_or_edit_field_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/test/bloc_test/board_test/group_by_unsupport_field_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/test/bloc_test/board_test/util.dart` (+1 -2) 📝 `frontend/appflowy_flutter/test/bloc_test/grid_test/field/edit_field_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/test/bloc_test/grid_test/util.dart` (+1 -2) </details> ### 📄 Description Remove `SingleFieldListener` and replace usage with `FieldController`'s `addSingleFieldListener` callback which gets triggered on `FieldInfo` changes instead of only `FieldPB` changes ### Feature Preview  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>