[PR #5163] [MERGED] feat: use font name instead of fontname_regular #6677

New issue

Closed

opened 2026-03-23 23:16:10 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:16:10 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5163
Author: @LucasXu0
Created: 4/19/2024
Status: ✅ Merged
Merged: 4/29/2024
Merged by: @LucasXu0

Base: main ← Head: font_name

📝 Commits (2)

afa5faa feat: use font name instead of name_regular
9f4e2e2 Merge branch 'main' into font_name

📊 Changes

3 files changed (+15 additions, -9 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/aa_menu/_font_item.dart (+1 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_style.dart (+12 -4)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/font_family_setting.dart (+2 -3)

📄 Description

Feature Preview

Previously, we were using 'fontname_regular' as the value for the font key, but it could not be parsed on the web. Now, we are using the real font name instead of 'fontname_regular'.

For example, 'ADLaMDisplay_regular' should be 'ADLa MDisplay'.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5163 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 4/19/2024 **Status:** ✅ Merged **Merged:** 4/29/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `font_name` --- ### 📝 Commits (2) - [`afa5faa`](https://github.com/AppFlowy-IO/AppFlowy/commit/afa5faa28b920c0bccbb69d383e94b0e603af825) feat: use font name instead of name_regular - [`9f4e2e2`](https://github.com/AppFlowy-IO/AppFlowy/commit/9f4e2e260e29ebb4fb82de1ecb3c6eab22df6a8e) Merge branch 'main' into font_name ### 📊 Changes **3 files changed** (+15 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/aa_menu/_font_item.dart` (+1 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_style.dart` (+12 -4) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/font_family_setting.dart` (+2 -3) </details> ### 📄 Description   ### Feature Preview Previously, we were using 'fontname_regular' as the value for the font key, but it could not be parsed on the web. Now, we are using the real font name instead of 'fontname_regular'. For example, 'ADLaMDisplay_regular' should be 'ADLa MDisplay'.  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>