[PR #5169] [MERGED] fix: search launch review #6682

New issue

Closed

opened 2026-03-23 23:16:11 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:16:11 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5169
Author: @Xazin
Created: 4/20/2024
Status: ✅ Merged
Merged: 4/23/2024
Merged by: @appflowy

Base: main ← Head: fix/search-launch-review

📝 Commits (10+)

84d0e9a fix: support filtering results by workspace
4b35aa9 feat: add search button to sidebar
5679787 fix: reduce view/recent view fetching across application
0912946 feat: add channel to search listener
00f77af Merge branch 'main' into fix/search-launch-review
4af21dd feat: clean + localization
54cf2c1 chore: remove redundant code
3016cbd fix: disable search
4c1a9b1 chore: trigger ci
90e81e5 chore: disable search in backend

📊 Changes

91 files changed (+1053 additions, -844 deletions)

View changed files

📝 .github/workflows/android_ci.yaml.bak (+1 -1)
📝 .github/workflows/flutter_ci.yaml (+14 -14)
📝 .github/workflows/ios_ci.yaml (+5 -5)
📝 .github/workflows/release.yml (+11 -11)
📝 .github/workflows/rust_ci.yaml (+1 -1)
📝 .github/workflows/rust_coverage.yml (+1 -1)
📝 .github/workflows/tauri2_ci.yaml (+1 -1)
📝 .github/workflows/tauri_ci.yaml (+2 -2)
📝 .github/workflows/tauri_release.yml (+1 -1)
📝 .github/workflows/web_ci.yaml (+1 -1)
📝 frontend/appflowy_flutter/lib/core/notification/search_notification.dart (+11 -4)
📝 frontend/appflowy_flutter/lib/mobile/application/mobile_router.dart (+5 -3)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/recent_folder/mobile_home_recent_views.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+1 -4)
📝 frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/inline_page_reference.dart (+103 -121)
📝 frontend/appflowy_flutter/lib/plugins/inline_actions/widgets/inline_actions_handler.dart (+7 -1)
📝 frontend/appflowy_flutter/lib/shared/feature_flags.dart (+7 -4)
📝 frontend/appflowy_flutter/lib/startup/deps_resolver.dart (+10 -8)
📝 frontend/appflowy_flutter/lib/startup/startup.dart (+4 -2)
📝 frontend/appflowy_flutter/lib/startup/tasks/app_widget.dart (+20 -10)

...and 71 more files

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5169 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 4/20/2024 **Status:** ✅ Merged **Merged:** 4/23/2024 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `fix/search-launch-review` --- ### 📝 Commits (10+) - [`84d0e9a`](https://github.com/AppFlowy-IO/AppFlowy/commit/84d0e9ae2bb2b5043a4b9200368e519a4ed1275c) fix: support filtering results by workspace - [`4b35aa9`](https://github.com/AppFlowy-IO/AppFlowy/commit/4b35aa981656210a2c3309f458b1376507530e87) feat: add search button to sidebar - [`5679787`](https://github.com/AppFlowy-IO/AppFlowy/commit/5679787b507782f9393c5ba66e17b558e7b88e88) fix: reduce view/recent view fetching across application - [`0912946`](https://github.com/AppFlowy-IO/AppFlowy/commit/0912946659294858d85ae48405bce99cd3ec8dcf) feat: add channel to search listener - [`00f77af`](https://github.com/AppFlowy-IO/AppFlowy/commit/00f77af301dedc892586ed57f29793200d8aa947) Merge branch 'main' into fix/search-launch-review - [`4af21dd`](https://github.com/AppFlowy-IO/AppFlowy/commit/4af21dd2e46849f25b2218ffec8c6c1cee9f143c) feat: clean + localization - [`54cf2c1`](https://github.com/AppFlowy-IO/AppFlowy/commit/54cf2c16ce67df7fd814b875130c4b2afc6491d0) chore: remove redundant code - [`3016cbd`](https://github.com/AppFlowy-IO/AppFlowy/commit/3016cbd69eb2a94dbf6205251cd661d1ae21efd5) fix: disable search - [`4c1a9b1`](https://github.com/AppFlowy-IO/AppFlowy/commit/4c1a9b1956dd076ccaba1347c06fb0c8fafdac1b) chore: trigger ci - [`90e81e5`](https://github.com/AppFlowy-IO/AppFlowy/commit/90e81e53322cbc0240bc691413a3d27ab3e88041) chore: disable search in backend ### 📊 Changes **91 files changed** (+1053 additions, -844 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/android_ci.yaml.bak` (+1 -1) 📝 `.github/workflows/flutter_ci.yaml` (+14 -14) 📝 `.github/workflows/ios_ci.yaml` (+5 -5) 📝 `.github/workflows/release.yml` (+11 -11) 📝 `.github/workflows/rust_ci.yaml` (+1 -1) 📝 `.github/workflows/rust_coverage.yml` (+1 -1) 📝 `.github/workflows/tauri2_ci.yaml` (+1 -1) 📝 `.github/workflows/tauri_ci.yaml` (+2 -2) 📝 `.github/workflows/tauri_release.yml` (+1 -1) 📝 `.github/workflows/web_ci.yaml` (+1 -1) 📝 `frontend/appflowy_flutter/lib/core/notification/search_notification.dart` (+11 -4) 📝 `frontend/appflowy_flutter/lib/mobile/application/mobile_router.dart` (+5 -3) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/recent_folder/mobile_home_recent_views.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+1 -4) 📝 `frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/inline_page_reference.dart` (+103 -121) 📝 `frontend/appflowy_flutter/lib/plugins/inline_actions/widgets/inline_actions_handler.dart` (+7 -1) 📝 `frontend/appflowy_flutter/lib/shared/feature_flags.dart` (+7 -4) 📝 `frontend/appflowy_flutter/lib/startup/deps_resolver.dart` (+10 -8) 📝 `frontend/appflowy_flutter/lib/startup/startup.dart` (+4 -2) 📝 `frontend/appflowy_flutter/lib/startup/tasks/app_widget.dart` (+20 -10) _...and 71 more files_ </details> ### 📄 Description ### Feature Preview #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>