[PR #5210] [MERGED] fix: some database bugs #6706

Closed
opened 2026-03-23 23:16:18 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5210
Author: @richardshiue
Created: 4/26/2024
Status: Merged
Merged: 4/29/2024
Merged by: @richardshiue

Base: mainHead: fix/url-open


📝 Commits (4)

  • d9a4eba fix: open logic for url cell in database
  • 08684b3 fix: row date created not working
  • b7b21be fix: help my toasts are burnt
  • 4c77fed chore: quote style and add comment

📊 Changes

3 files changed (+19 additions, -28 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/editable_cell_skeleton/url.dart (+12 -21)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/toast.dart (+1 -2)
📝 frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs (+6 -5)

📄 Description

support

image

resolves #5209

also fix another bug where all the toasts in the app aren't working.

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5210 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 4/26/2024 **Status:** ✅ Merged **Merged:** 4/29/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `fix/url-open` --- ### 📝 Commits (4) - [`d9a4eba`](https://github.com/AppFlowy-IO/AppFlowy/commit/d9a4ebadc92f19405832e3fcfc5bdb0127755b78) fix: open logic for url cell in database - [`08684b3`](https://github.com/AppFlowy-IO/AppFlowy/commit/08684b380f1cfbafcaf266ed86f4de036f3a2833) fix: row date created not working - [`b7b21be`](https://github.com/AppFlowy-IO/AppFlowy/commit/b7b21be506c9bdbc357ce9959354bf9dbd5fac57) fix: help my toasts are burnt - [`4c77fed`](https://github.com/AppFlowy-IO/AppFlowy/commit/4c77fed9edfde7a46442a77771b1671d3b329a06) chore: quote style and add comment ### 📊 Changes **3 files changed** (+19 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/editable_cell_skeleton/url.dart` (+12 -21) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/toast.dart` (+1 -2) 📝 `frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs` (+6 -5) </details> ### 📄 Description support ![image](https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/a9ad59b2-6590-404d-a58e-b1ea143b230f) resolves #5209 also fix another bug where all the toasts in the app aren't working. ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:16:18 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#6706
No description provided.