[PR #5254] [MERGED] fix: open row as full page launch review issues #6731

New issue

Closed

opened 2026-03-23 23:16:24 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:16:24 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5254
Author: @richardshiue
Created: 5/2/2024
Status: ✅ Merged
Merged: 5/2/2024
Merged by: @richardshiue

Base: main ← Head: perf/improve-get-row-data-speed

📝 Commits (3)

177dac9 perf: improve getting database speed
86d84c4 fix: navigate to incorrect origin database view from full-width row
e32a9ce fix: import row detail page action placement

📊 Changes

6 files changed (+131 additions, -113 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database/application/database_controller.dart (+4 -4)
📝 frontend/appflowy_flutter/lib/plugins/database/application/row/related_row_detail_bloc.dart (+4 -8)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/row/row_banner.dart (+23 -75)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/row/row_detail.dart (+80 -26)
📝 frontend/rust-lib/flowy-database2/src/event_handler.rs (+16 -0)
📝 frontend/rust-lib/flowy-database2/src/event_map.rs (+4 -0)

📄 Description

In collaborative sessions, the row property will now be displayed almost instantaneously upon expanding a row as a full page.
Fix a case where using the breadcrumbs to navigate back to the original database view didn't bring the user to the correct database view.
Fix the row detail actions to the top of the row detail dialog.
Move the expand icon to the top-right corner of the row detail dialog.

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5254 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 5/2/2024 **Status:** ✅ Merged **Merged:** 5/2/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `perf/improve-get-row-data-speed` --- ### 📝 Commits (3) - [`177dac9`](https://github.com/AppFlowy-IO/AppFlowy/commit/177dac95b94d19100fffe9d4ff7e61a982192f06) perf: improve getting database speed - [`86d84c4`](https://github.com/AppFlowy-IO/AppFlowy/commit/86d84c436c97c256111293dfada6f7f6bd581df6) fix: navigate to incorrect origin database view from full-width row - [`e32a9ce`](https://github.com/AppFlowy-IO/AppFlowy/commit/e32a9cee417d2ea742e3de62eb85cb21fe8c0a1f) fix: import row detail page action placement ### 📊 Changes **6 files changed** (+131 additions, -113 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database/application/database_controller.dart` (+4 -4) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/row/related_row_detail_bloc.dart` (+4 -8) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/row/row_banner.dart` (+23 -75) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/row/row_detail.dart` (+80 -26) 📝 `frontend/rust-lib/flowy-database2/src/event_handler.rs` (+16 -0) 📝 `frontend/rust-lib/flowy-database2/src/event_map.rs` (+4 -0) </details> ### 📄 Description 1. In collaborative sessions, the row property will now be displayed almost instantaneously upon expanding a row as a full page. 2. Fix a case where using the breadcrumbs to navigate back to the original database view didn't bring the user to the correct database view. 3. Fix the row detail actions to the top of the row detail dialog. 4. Move the expand icon to the top-right corner of the row detail dialog. ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>