[PR #5279] [MERGED] feat: support system default font family on desktop #6748

New issue

Closed

opened 2026-03-23 23:16:29 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:16:29 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5279
Author: @LucasXu0
Created: 5/7/2024
Status: ✅ Merged
Merged: 5/7/2024
Merged by: @LucasXu0

Base: main ← Head: add_permission_request_for_image_block

📝 Commits (4)

9a6fcd5 fix: add permission check before selecting image in image block
8b24be4 feat: use system default font on desktop
9a3afaf fix: set appbar icon size to 30
d2ab322 feat: add default font family on desktop

📊 Changes

23 files changed (+233 additions, -190 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/uncategorized/appearance_settings_test.dart (+5 -2)
📝 frontend/appflowy_flutter/lib/mobile/application/page_style/document_page_style_bloc.dart (+2 -3)
📝 frontend/appflowy_flutter/lib/mobile/presentation/base/mobile_view_page.dart (+55 -38)
📝 frontend/appflowy_flutter/lib/mobile/presentation/setting/font/font_picker_screen.dart (+5 -9)
📝 frontend/appflowy_flutter/lib/mobile/presentation/setting/font/font_setting.dart (+2 -4)
📝 frontend/appflowy_flutter/lib/plugins/document/application/document_appearance_cubit.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/cover/document_immersive_cover.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/upload_image_file_widget.dart (+26 -12)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/aa_menu/_font_item.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/page_style/_page_style_cover_image.dart (+4 -56)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/page_style/_page_style_layout.dart (+5 -7)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_style.dart (+5 -4)
➕ frontend/appflowy_flutter/lib/shared/permission/permission_checker.dart (+64 -0)
➕ frontend/appflowy_flutter/lib/util/font_family_extension.dart (+15 -0)
➖ frontend/appflowy_flutter/lib/util/google_font_family_extension.dart (+0 -6)
📝 frontend/appflowy_flutter/lib/workspace/application/appearance_defaults.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/workspace/application/settings/appearance/base_appearance.dart (+11 -22)
📝 frontend/appflowy_flutter/lib/workspace/application/settings/appearance/desktop_appearance.dart (+1 -3)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/font_family_setting.dart (+15 -12)
📝 frontend/appflowy_flutter/test/bloc_test/app_setting_test/appearance_test.dart (+1 -1)

...and 3 more files

📄 Description

Feature Preview

Using system default font instead of Poppins.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5279 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 5/7/2024 **Status:** ✅ Merged **Merged:** 5/7/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `add_permission_request_for_image_block` --- ### 📝 Commits (4) - [`9a6fcd5`](https://github.com/AppFlowy-IO/AppFlowy/commit/9a6fcd5a208f7541cd50428611f9e02363358ee1) fix: add permission check before selecting image in image block - [`8b24be4`](https://github.com/AppFlowy-IO/AppFlowy/commit/8b24be46a063d3c9cb95a03434197d803a7b6c42) feat: use system default font on desktop - [`9a3afaf`](https://github.com/AppFlowy-IO/AppFlowy/commit/9a3afaf7cab1f75e1176a9a826afccc4baec68a9) fix: set appbar icon size to 30 - [`d2ab322`](https://github.com/AppFlowy-IO/AppFlowy/commit/d2ab3229b17f9f5fc9beca058e28c26f1bf83a01) feat: add default font family on desktop ### 📊 Changes **23 files changed** (+233 additions, -190 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/uncategorized/appearance_settings_test.dart` (+5 -2) 📝 `frontend/appflowy_flutter/lib/mobile/application/page_style/document_page_style_bloc.dart` (+2 -3) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/base/mobile_view_page.dart` (+55 -38) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/setting/font/font_picker_screen.dart` (+5 -9) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/setting/font/font_setting.dart` (+2 -4) 📝 `frontend/appflowy_flutter/lib/plugins/document/application/document_appearance_cubit.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/cover/document_immersive_cover.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/upload_image_file_widget.dart` (+26 -12) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/aa_menu/_font_item.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/page_style/_page_style_cover_image.dart` (+4 -56) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/page_style/_page_style_layout.dart` (+5 -7) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_style.dart` (+5 -4) ➕ `frontend/appflowy_flutter/lib/shared/permission/permission_checker.dart` (+64 -0) ➕ `frontend/appflowy_flutter/lib/util/font_family_extension.dart` (+15 -0) ➖ `frontend/appflowy_flutter/lib/util/google_font_family_extension.dart` (+0 -6) 📝 `frontend/appflowy_flutter/lib/workspace/application/appearance_defaults.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/workspace/application/settings/appearance/base_appearance.dart` (+11 -22) 📝 `frontend/appflowy_flutter/lib/workspace/application/settings/appearance/desktop_appearance.dart` (+1 -3) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/font_family_setting.dart` (+15 -12) 📝 `frontend/appflowy_flutter/test/bloc_test/app_setting_test/appearance_test.dart` (+1 -1) _...and 3 more files_ </details> ### 📄 Description   ### Feature Preview Using system default font instead of Poppins. <img width="181" alt="Screenshot 2024-05-07 at 15 37 49" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/328573fe-a7db-4668-91cf-d0330c7ef130">  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>