[GH-ISSUE #1761] [Bug] Numbered list #678

Closed
opened 2026-03-23 20:39:39 +00:00 by mirror · 16 comments
Owner

Originally created by @annieappflowy on GitHub (Jan 30, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/1761

Originally assigned to: @LucasXu0 on GitHub.

Bug Description

No line between numbered list items is allowed

image

How to Reproduce

  1. Create three numbered list items
  2. Try to add an empty line between 1. and 2.
  3. The numbers shown are not incremental from 1 to 3

Expected Behavior

Like Google Docs, I can add empty lines in between a numbered list
image

Operating System

Windows 10

AppFlowy Version(s)

0.0.9.1

Screenshots

No response

Additional Context

No response

Originally created by @annieappflowy on GitHub (Jan 30, 2023). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/1761 Originally assigned to: @LucasXu0 on GitHub. ### Bug Description No line between numbered list items is allowed <img width="166" alt="image" src="https://user-images.githubusercontent.com/12026239/215458336-5a310057-bdd7-442f-ac1b-10036fb8a365.png"> ### How to Reproduce 1. Create three numbered list items 2. Try to add an empty line between 1. and 2. 3. The numbers shown are not incremental from 1 to 3 ### Expected Behavior Like Google Docs, I can add empty lines in between a numbered list <img width="99" alt="image" src="https://user-images.githubusercontent.com/12026239/215459139-d2410b11-210b-4054-b0b9-9e5fabbff9f2.png"> ### Operating System Windows 10 ### AppFlowy Version(s) 0.0.9.1 ### Screenshots _No response_ ### Additional Context _No response_
Author
Owner

@LucasXu0 commented on GitHub (Jan 31, 2023):

It's by design. If we press the enter between numbered lists, the below part will re-sort from 1.

Please take a look at this video if you'd like to insert an empty line between the incremental numbered list.

https://user-images.githubusercontent.com/11863087/215662798-01d549ba-e657-4e15-bf0a-617d1e217103.mov

Or using shift+enter to add a new line at the same node.

<!-- gh-comment-id:1409734594 --> @LucasXu0 commented on GitHub (Jan 31, 2023): It's by design. If we press the enter between numbered lists, the below part will re-sort from 1. Please take a look at this video if you'd like to insert an empty line between the incremental numbered list. https://user-images.githubusercontent.com/11863087/215662798-01d549ba-e657-4e15-bf0a-617d1e217103.mov Or using shift+enter to add a new line at the same node.
Author
Owner

@richardshiue commented on GitHub (Jan 31, 2023):

I didn't know about shift+enter, maybe that's what Annie wants. In google docs, the shift+enter to add a new line in the same node is a single enter followed a backspace, and a subsequent enter/backspace will trigger AppFlowy's usual backspace behavior that splits the number list into two.

<!-- gh-comment-id:1409954993 --> @richardshiue commented on GitHub (Jan 31, 2023): I didn't know about shift+enter, maybe that's what Annie wants. In google docs, the shift+enter to add a new line in the same node is a single enter followed a backspace, and a subsequent enter/backspace will trigger AppFlowy's usual backspace behavior that splits the number list into two.
Author
Owner

@annieappflowy commented on GitHub (Jan 31, 2023):

Ok I see. I didn't figure out the trick.
I suppose Shift + enter should be added to our shortcuts guide (which doesn't exist yet)

<!-- gh-comment-id:1410372734 --> @annieappflowy commented on GitHub (Jan 31, 2023): Ok I see. I didn't figure out the trick. I suppose Shift + enter should be added to our shortcuts guide (which doesn't exist yet)
Author
Owner

@MayurSMahajan commented on GitHub (Feb 1, 2023):

Okay, so we just want to add documentation for the shift+enter, in our shortcuts guide(which I will be happy to make), right? Or am I missing something? I did not understand what Richard meant.

<!-- gh-comment-id:1411991626 --> @MayurSMahajan commented on GitHub (Feb 1, 2023): Okay, so we just want to add documentation for the shift+enter, in our shortcuts guide(which I will be happy to make), right? Or am I missing something? I did not understand what Richard meant.
Author
Owner

@annieappflowy commented on GitHub (Feb 1, 2023):

Based on my understanding, what Richard means is that in Google Docs both ways (shift+enter or enter+backspace) can achieve adding lines between numbered item without breaking the existing number order. AppFlowy only supports shift+enter at the moment.

I think we should write documentation to list out all the shortcuts we support. In addition, we can add an entry to the "?" list at the bottom right of the editing area to direct users to view the shortcut guide.

<!-- gh-comment-id:1412005852 --> @annieappflowy commented on GitHub (Feb 1, 2023): Based on my understanding, what Richard means is that in Google Docs both ways (shift+enter or enter+backspace) can achieve adding lines between numbered item without breaking the existing number order. AppFlowy only supports shift+enter at the moment. I think we should write documentation to list out all the shortcuts we support. In addition, we can add an entry to the "?" list at the bottom right of the editing area to direct users to view the shortcut guide.
Author
Owner

@MayurSMahajan commented on GitHub (Feb 1, 2023):

Okay understood! Thanks.

<!-- gh-comment-id:1412010608 --> @MayurSMahajan commented on GitHub (Feb 1, 2023): Okay understood! Thanks.
Author
Owner

@MayurSMahajan commented on GitHub (Feb 1, 2023):

So the objective of the PR solving this issue will facilitate the redirection of the user to a documentation page that enlists all the existing predefined shortcuts. This link can be accessed by clicking on the "?" button
image
I can get this done, but this seems a perfect choice for a "good first issue" for any newcomers. If no one claims it I will work on it.

<!-- gh-comment-id:1412019607 --> @MayurSMahajan commented on GitHub (Feb 1, 2023): So the objective of the PR solving this issue will facilitate the redirection of the user to a documentation page that enlists all the existing predefined shortcuts. This link can be accessed by clicking on the "?" button ![image](https://user-images.githubusercontent.com/47064215/216049565-8f45d890-75a7-48f6-9edf-532b828091a5.png) I can get this done, but this seems a perfect choice for a "good first issue" for any newcomers. If no one claims it I will work on it.
Author
Owner

@AmanNegi commented on GitHub (Feb 15, 2023):

Hey there can I work on this?

<!-- gh-comment-id:1430980819 --> @AmanNegi commented on GitHub (Feb 15, 2023): Hey there can I work on this?
Author
Owner

@MayurSMahajan commented on GitHub (Feb 15, 2023):

Hey @AmanNegi! Go ahead, you can start working on this.

<!-- gh-comment-id:1431179534 --> @MayurSMahajan commented on GitHub (Feb 15, 2023): Hey @AmanNegi! Go ahead, you can start working on this.
Author
Owner

@AmanNegi commented on GitHub (Feb 15, 2023):

Hey there, do we already have a list of Shortcuts listed somewhere? If not are we supposed to create a Flutter Page or a SHORTCUTS.md in the GitHub Repository?

<!-- gh-comment-id:1431254920 --> @AmanNegi commented on GitHub (Feb 15, 2023): Hey there, do we already have a list of Shortcuts listed somewhere? If not are we supposed to create a Flutter Page or a `SHORTCUTS.md` in the GitHub Repository?
Author
Owner

@annieappflowy commented on GitHub (Feb 15, 2023):

Hi @AmanNegi , we should create a documentation page to list the shortcuts we support and build a link in the app so people can be directed to that page.

Just created a page for you to fill good stuff in: https://github.com/AppFlowy-IO/AppFlowy-Docs/blob/main/essential-documentation/shortcuts.md
You can work on it and submit a PR for review.
Meanwhile, you can also work on adding a link to "?"

<!-- gh-comment-id:1431300203 --> @annieappflowy commented on GitHub (Feb 15, 2023): Hi @AmanNegi , we should create a documentation page to list the shortcuts we support and build a link in the app so people can be directed to that page. Just created a page for you to fill good stuff in: https://github.com/AppFlowy-IO/AppFlowy-Docs/blob/main/essential-documentation/shortcuts.md You can work on it and submit a PR for review. Meanwhile, you can also work on adding a link to "?"
Author
Owner

@MayurSMahajan commented on GitHub (Feb 15, 2023):

Hey @AmanNegi, you can find the list of existing shortcuts here.
AppFlowy\frontend\app_flowy\packages\appflowy_editor\lib\src\service\shortcut_event\built_in_shortcut_events.dart

<!-- gh-comment-id:1431480454 --> @MayurSMahajan commented on GitHub (Feb 15, 2023): Hey @AmanNegi, you can find the list of existing shortcuts here. `AppFlowy\frontend\app_flowy\packages\appflowy_editor\lib\src\service\shortcut_event\built_in_shortcut_events.dart`
Author
Owner

@AmanNegi commented on GitHub (Feb 15, 2023):

Thanks, 😊 @MayurSMahajan That helps a lot!

<!-- gh-comment-id:1431492790 --> @AmanNegi commented on GitHub (Feb 15, 2023): Thanks, 😊 @MayurSMahajan That helps a lot!
Author
Owner

@AmanNegi commented on GitHub (Feb 17, 2023):

Hey there, I had a question. If I add some text, do I need to add translation in each language?

  "questionBubble": {
    "shortcuts": "Shortcuts", 
    "whatsNew": "What's new?", 
    "help": "Help & Support",
    "debug": {
      "name": "Debug Info",
      "success": "Copied debug info to clipboard!",
      "fail": "Unable to copy debug info to clipboard"
    }
  }

Added "shortcuts": "Shortcuts" above in en.json.

PS: I have added all the shortcuts and made a PR here.

<!-- gh-comment-id:1434287659 --> @AmanNegi commented on GitHub (Feb 17, 2023): Hey there, I had a question. If I add some text, do I need to add translation in each language? ``` json "questionBubble": { "shortcuts": "Shortcuts", "whatsNew": "What's new?", "help": "Help & Support", "debug": { "name": "Debug Info", "success": "Copied debug info to clipboard!", "fail": "Unable to copy debug info to clipboard" } } ``` > Added `"shortcuts": "Shortcuts"` above in `en.json`. PS: I have added all the shortcuts and made a PR [here](https://github.com/AppFlowy-IO/AppFlowy-Docs/pull/50).
Author
Owner

@MayurSMahajan commented on GitHub (Feb 18, 2023):

No just English is fine, if you want to add a translation for any other language, you can create a new PR for that.

<!-- gh-comment-id:1435481235 --> @MayurSMahajan commented on GitHub (Feb 18, 2023): No just English is fine, if you **want** to add a translation for any other language, you can create a new PR for that.
Author
Owner

@AmanNegi commented on GitHub (Feb 18, 2023):

Okay great :)

<!-- gh-comment-id:1435497360 --> @AmanNegi commented on GitHub (Feb 18, 2023): Okay great :)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#678
No description provided.