mirror of
https://github.com/AppFlowy-IO/AppFlowy.git
synced 2026-03-24 21:00:19 +00:00
[GH-ISSUE #1761] [Bug] Numbered list #678
Labels
No labels
2024
2025
2026
acct mgmt
AI
automation
bug
calendar
ci
CJK
cloud
code-block
collaboration
copy-paste
database
data migration
data sync
deploy
desktop
develop
develop
documentation
duplicate
editor
editor-plugin
emoji
export
files
flutter-only
follow-up
formula
good first issue for devs
good first issue for experienced devs
grid
hacktoberfest
HACKTOBERFEST-ACCEPTED
help wanted
i18n
icons
images
importer
improvements
infra
install
integrations
IR
kanban board
login
look and joy
mentorship
mobile
mobile
needs design
new feature
new feature
non-coding
notes
notifications
onboarding
organization
P0+
permission
platform-linux
platform-mac
platform-windows
plugins
program
pull-request
Q1 25
Q1 26
Q2 24
Q2 25
Q3 24
Q3 25
Q4 24
Q4 25
react
regression
rust
rust
Rust-only
Rust-only
Rust-starter
Rust-starter
self-hosted
shortcuts
side panel
slash-menu
sync v2
table
tablet
task
tauri
templates
tests
themes
translation
v0.5.6
v0.5.8
v0.5.9
v0.6.0
v0.6.1
v0.6.4
v0.6.7
v0.6.8
v0.7.1
v0.7.4
v0.7.4
v0.7.5
v0.7.6
v0.7.7
v0.7.8
v0.8.0
v0.8.4
v0.8.5
v0.8.9
web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
AppFlowy-IO/AppFlowy#678
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @annieappflowy on GitHub (Jan 30, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/1761
Originally assigned to: @LucasXu0 on GitHub.
Bug Description
No line between numbered list items is allowed
How to Reproduce
Expected Behavior
Like Google Docs, I can add empty lines in between a numbered list

Operating System
Windows 10
AppFlowy Version(s)
0.0.9.1
Screenshots
No response
Additional Context
No response
@LucasXu0 commented on GitHub (Jan 31, 2023):
It's by design. If we press the enter between numbered lists, the below part will re-sort from 1.
Please take a look at this video if you'd like to insert an empty line between the incremental numbered list.
https://user-images.githubusercontent.com/11863087/215662798-01d549ba-e657-4e15-bf0a-617d1e217103.mov
Or using shift+enter to add a new line at the same node.
@richardshiue commented on GitHub (Jan 31, 2023):
I didn't know about shift+enter, maybe that's what Annie wants. In google docs, the shift+enter to add a new line in the same node is a single enter followed a backspace, and a subsequent enter/backspace will trigger AppFlowy's usual backspace behavior that splits the number list into two.
@annieappflowy commented on GitHub (Jan 31, 2023):
Ok I see. I didn't figure out the trick.
I suppose Shift + enter should be added to our shortcuts guide (which doesn't exist yet)
@MayurSMahajan commented on GitHub (Feb 1, 2023):
Okay, so we just want to add documentation for the shift+enter, in our shortcuts guide(which I will be happy to make), right? Or am I missing something? I did not understand what Richard meant.
@annieappflowy commented on GitHub (Feb 1, 2023):
Based on my understanding, what Richard means is that in Google Docs both ways (shift+enter or enter+backspace) can achieve adding lines between numbered item without breaking the existing number order. AppFlowy only supports shift+enter at the moment.
I think we should write documentation to list out all the shortcuts we support. In addition, we can add an entry to the "?" list at the bottom right of the editing area to direct users to view the shortcut guide.
@MayurSMahajan commented on GitHub (Feb 1, 2023):
Okay understood! Thanks.
@MayurSMahajan commented on GitHub (Feb 1, 2023):
So the objective of the PR solving this issue will facilitate the redirection of the user to a documentation page that enlists all the existing predefined shortcuts. This link can be accessed by clicking on the "?" button

I can get this done, but this seems a perfect choice for a "good first issue" for any newcomers. If no one claims it I will work on it.
@AmanNegi commented on GitHub (Feb 15, 2023):
Hey there can I work on this?
@MayurSMahajan commented on GitHub (Feb 15, 2023):
Hey @AmanNegi! Go ahead, you can start working on this.
@AmanNegi commented on GitHub (Feb 15, 2023):
Hey there, do we already have a list of Shortcuts listed somewhere? If not are we supposed to create a Flutter Page or a
SHORTCUTS.mdin the GitHub Repository?@annieappflowy commented on GitHub (Feb 15, 2023):
Hi @AmanNegi , we should create a documentation page to list the shortcuts we support and build a link in the app so people can be directed to that page.
Just created a page for you to fill good stuff in: https://github.com/AppFlowy-IO/AppFlowy-Docs/blob/main/essential-documentation/shortcuts.md
You can work on it and submit a PR for review.
Meanwhile, you can also work on adding a link to "?"
@MayurSMahajan commented on GitHub (Feb 15, 2023):
Hey @AmanNegi, you can find the list of existing shortcuts here.
AppFlowy\frontend\app_flowy\packages\appflowy_editor\lib\src\service\shortcut_event\built_in_shortcut_events.dart@AmanNegi commented on GitHub (Feb 15, 2023):
Thanks, 😊 @MayurSMahajan That helps a lot!
@AmanNegi commented on GitHub (Feb 17, 2023):
Hey there, I had a question. If I add some text, do I need to add translation in each language?
PS: I have added all the shortcuts and made a PR here.
@MayurSMahajan commented on GitHub (Feb 18, 2023):
No just English is fine, if you want to add a translation for any other language, you can create a new PR for that.
@AmanNegi commented on GitHub (Feb 18, 2023):
Okay great :)