[PR #5405] [MERGED] fix: default text direction not synced #6803

New issue

Closed

opened 2026-03-23 23:16:45 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:16:45 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5405
Author: @zoli
Created: 5/24/2024
Status: ✅ Merged
Merged: 5/24/2024
Merged by: @Xazin

Base: main ← Head: fix/text-direction-setting

📝 Commits (2)

6fde91c fix: default text direction not synced
c204b4a test: annotate visibleForTesting

📊 Changes

2 files changed (+172 additions, -7 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_workspace_view.dart (+13 -7)
➕ frontend/appflowy_flutter/test/widget_test/direction_setting_test.dart (+159 -0)

📄 Description

resolves #5402

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5405 **Author:** [@zoli](https://github.com/zoli) **Created:** 5/24/2024 **Status:** ✅ Merged **Merged:** 5/24/2024 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `fix/text-direction-setting` --- ### 📝 Commits (2) - [`6fde91c`](https://github.com/AppFlowy-IO/AppFlowy/commit/6fde91c28b758be615f22a2cbe5c86d459c1aeae) fix: default text direction not synced - [`c204b4a`](https://github.com/AppFlowy-IO/AppFlowy/commit/c204b4adf0ff7a31dd17a13350bb56aac396e0ba) test: annotate visibleForTesting ### 📊 Changes **2 files changed** (+172 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_workspace_view.dart` (+13 -7) ➕ `frontend/appflowy_flutter/test/widget_test/direction_setting_test.dart` (+159 -0) </details> ### 📄 Description resolves #5402 #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>