[PR #5414] [MERGED] fix: accept multi-key combination for customizing shortcuts & removes duplicates #6804

New issue

Closed

opened 2026-03-23 23:16:45 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:16:45 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5414
Author: @MayurSMahajan
Created: 5/26/2024
Status: ✅ Merged
Merged: 5/27/2024
Merged by: @LucasXu0

Base: main ← Head: fix_duplicate_shortcut_entries_5355

📝 Commits (4)

3e27797 fix: remove duplicate shortcuts
057df0f fix: listen on for keydown events
0c35108 fix: remove duplicate toggle todo command
2c64889 fix: sort shortcuts by lowercase

📊 Changes

3 files changed (+57 additions, -29 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+16 -13)
📝 frontend/appflowy_flutter/lib/workspace/application/settings/shortcuts/settings_shortcuts_cubit.dart (+8 -5)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_customize_shortcuts_view.dart (+33 -11)

📄 Description

Solves:

#5413
Partially solves: #5355

Feature Preview

https://github.com/AppFlowy-IO/AppFlowy/assets/47064215/90961fcc-8d20-4684-8784-e20ba2f72d3d

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5414 **Author:** [@MayurSMahajan](https://github.com/MayurSMahajan) **Created:** 5/26/2024 **Status:** ✅ Merged **Merged:** 5/27/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_duplicate_shortcut_entries_5355` --- ### 📝 Commits (4) - [`3e27797`](https://github.com/AppFlowy-IO/AppFlowy/commit/3e27797107f464f1cf0a6256b40703ddd27c5caf) fix: remove duplicate shortcuts - [`057df0f`](https://github.com/AppFlowy-IO/AppFlowy/commit/057df0f6b629d03c25573a55e738ebe5501dcbcb) fix: listen on for keydown events - [`0c35108`](https://github.com/AppFlowy-IO/AppFlowy/commit/0c351086d3c302588a71374b30697400627caaf2) fix: remove duplicate toggle todo command - [`2c64889`](https://github.com/AppFlowy-IO/AppFlowy/commit/2c64889205423543e40da6145fecaa420bf189cb) fix: sort shortcuts by lowercase ### 📊 Changes **3 files changed** (+57 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+16 -13) 📝 `frontend/appflowy_flutter/lib/workspace/application/settings/shortcuts/settings_shortcuts_cubit.dart` (+8 -5) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_customize_shortcuts_view.dart` (+33 -11) </details> ### 📄 Description  ### Solves: #5413 Partially solves: #5355  ### Feature Preview https://github.com/AppFlowy-IO/AppFlowy/assets/47064215/90961fcc-8d20-4684-8784-e20ba2f72d3d  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>