[PR #5431] [MERGED] fix: sidebar issues on Windows and Linux #6812

New issue

Closed

opened 2026-03-23 23:16:47 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:16:47 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5431
Author: @LucasXu0
Created: 5/29/2024
Status: ✅ Merged
Merged: 5/29/2024
Merged by: @LucasXu0

Base: main ← Head: fix_windows_sidebar_issues

📝 Commits (5)

7a8628d fix: workspace icon overflow
d372807 fix: notification button doesn't have same effect as settings button
4087433 fix: open-sidebar button wasn't replaced in the Windows title bar
cd0411c fix: workspace name overflow on Linux
fc55b56 fix: appflowy logo align issue

📊 Changes

14 files changed (+127 additions, -81 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/core/frameless_window.dart (+20 -7)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/header/sidebar_top_menu.dart (+10 -8)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/header/sidebar_user.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_icon.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_menu.dart (+1 -2)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/sidebar_workspace.dart (+23 -25)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart (+4 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/navigation.dart (+35 -19)
📝 frontend/appflowy_flutter/lib/workspace/presentation/notifications/widgets/notification_button.dart (+14 -11)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/view_title_bar.dart (+1 -0)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text.dart (+9 -1)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/widget/flowy_tooltip.dart (+5 -0)
📝 frontend/resources/flowy_icons/16x/show_menu.svg (+3 -5)

📄 Description

Feature Preview

The workspace icon is scrunched up
The notification button doesn't have same effect as settings button
The Open-sidebar button wasn't replaced in the Windows title bar
The Close-sidebar button doesn't align with the AppFlowy logo on Windows
The workspace menu has a bottom overflow

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5431 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 5/29/2024 **Status:** ✅ Merged **Merged:** 5/29/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_windows_sidebar_issues` --- ### 📝 Commits (5) - [`7a8628d`](https://github.com/AppFlowy-IO/AppFlowy/commit/7a8628d106322c2c0db64c7efcf1a22714101afe) fix: workspace icon overflow - [`d372807`](https://github.com/AppFlowy-IO/AppFlowy/commit/d37280764d13af0857cacf5d3b199aeb5f44e555) fix: notification button doesn't have same effect as settings button - [`4087433`](https://github.com/AppFlowy-IO/AppFlowy/commit/40874335909000e250a02536f4e15eb92f94578d) fix: open-sidebar button wasn't replaced in the Windows title bar - [`cd0411c`](https://github.com/AppFlowy-IO/AppFlowy/commit/cd0411c92150ccac8cc4c7c830e82fd0615efd4a) fix: workspace name overflow on Linux - [`fc55b56`](https://github.com/AppFlowy-IO/AppFlowy/commit/fc55b5620d427cae12ba3d96cb3a9a03950b8331) fix: appflowy logo align issue ### 📊 Changes **14 files changed** (+127 additions, -81 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/core/frameless_window.dart` (+20 -7) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/header/sidebar_top_menu.dart` (+10 -8) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/header/sidebar_user.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_icon.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_menu.dart` (+1 -2) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/sidebar_workspace.dart` (+23 -25) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart` (+4 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/navigation.dart` (+35 -19) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/notifications/widgets/notification_button.dart` (+14 -11) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/view_title_bar.dart` (+1 -0) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text.dart` (+9 -1) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/widget/flowy_tooltip.dart` (+5 -0) 📝 `frontend/resources/flowy_icons/16x/show_menu.svg` (+3 -5) </details> ### 📄 Description   ### Feature Preview - [x] The workspace icon is scrunched up - [x] The notification button doesn't have same effect as settings button - [x] The Open-sidebar button wasn't replaced in the Windows title bar - [x] The Close-sidebar button doesn't align with the AppFlowy logo on Windows - [x] The workspace menu has a bottom overflow ![image](https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/191e8235-14c7-428e-8c31-1b1067ad8346)  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>