[PR #5466] [CLOSED] fix: incorrect window size after hiding title bar on Windows #6833

New issue

Closed

opened 2026-03-23 23:16:53 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:16:53 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5466
Author: @LucasXu0
Created: 6/4/2024
Status: ❌ Closed

Base: main ← Head: revert_windows_hide_title_bar

📝 Commits (4)

1041372 fix: incorrect window size after hiding titlebar on Windows
cdf8dcb chore: update window.cpp
ed19862 Merge branch 'main' into revert_windows_hide_title_bar
b4a39a6 chore: add missing function

📊 Changes

6 files changed (+167 additions, -201 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/startup/tasks/windows.dart (+2 -6)
📝 frontend/appflowy_flutter/pubspec.lock (+2 -2)
📝 frontend/appflowy_flutter/pubspec.yaml (+1 -1)
📝 frontend/appflowy_flutter/windows/runner/flutter_window.cpp (+10 -0)
📝 frontend/appflowy_flutter/windows/runner/win32_window.cpp (+133 -170)
📝 frontend/appflowy_flutter/windows/runner/win32_window.h (+19 -22)

📄 Description

Feature Preview

Revert the code will cause an incorrect window size on Windows.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5466 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 6/4/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `revert_windows_hide_title_bar` --- ### 📝 Commits (4) - [`1041372`](https://github.com/AppFlowy-IO/AppFlowy/commit/1041372c37e8998c5a0bb925387b9846b92ae09b) fix: incorrect window size after hiding titlebar on Windows - [`cdf8dcb`](https://github.com/AppFlowy-IO/AppFlowy/commit/cdf8dcb0af33c253a3a70c0d128d8d5de736964e) chore: update window.cpp - [`ed19862`](https://github.com/AppFlowy-IO/AppFlowy/commit/ed198622512f4c2aa0172f675412a240b486c478) Merge branch 'main' into revert_windows_hide_title_bar - [`b4a39a6`](https://github.com/AppFlowy-IO/AppFlowy/commit/b4a39a6ae451ac5fef98eafca0b46d83fc55d5a6) chore: add missing function ### 📊 Changes **6 files changed** (+167 additions, -201 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/startup/tasks/windows.dart` (+2 -6) 📝 `frontend/appflowy_flutter/pubspec.lock` (+2 -2) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+1 -1) 📝 `frontend/appflowy_flutter/windows/runner/flutter_window.cpp` (+10 -0) 📝 `frontend/appflowy_flutter/windows/runner/win32_window.cpp` (+133 -170) 📝 `frontend/appflowy_flutter/windows/runner/win32_window.h` (+19 -22) </details> ### 📄 Description   ### Feature Preview Revert the code will cause an incorrect window size on Windows. ![Screenshot 2024-06-04 215618](https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/310c58f0-07a7-4c9c-9433-182ab727ac17)  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>