[PR #5477] [MERGED] fix: use bitsdojo_window on windows #6842

Closed
opened 2026-03-23 23:16:55 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5477
Author: @Xazin
Created: 6/5/2024
Status: Merged
Merged: 6/5/2024
Merged by: @LucasXu0

Base: mainHead: fix/workaround-window-manager


📝 Commits (2)

  • 389fe97 fix: use bitsdojo_window on windows
  • 5476ff8 Merge branch 'main' into fix/workaround-window-manager

📊 Changes

4 files changed (+91 additions, -25 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/startup/tasks/windows.dart (+39 -22)
📝 frontend/appflowy_flutter/pubspec.lock (+42 -2)
📝 frontend/appflowy_flutter/pubspec.yaml (+7 -1)
📝 frontend/appflowy_flutter/windows/runner/main.cpp (+3 -0)

📄 Description

This is a workaround for an issue where window_manager improperly renders the window on Windows.


We don't have a listener on Size of Window in bitsdojo, so we still rely on window_manager, the only difference is that we use Bitsdojo to render the frameless window instead of window_manager


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5477 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 6/5/2024 **Status:** ✅ Merged **Merged:** 6/5/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/workaround-window-manager` --- ### 📝 Commits (2) - [`389fe97`](https://github.com/AppFlowy-IO/AppFlowy/commit/389fe972ec73a06c826cf90ba6265835ed32f264) fix: use bitsdojo_window on windows - [`5476ff8`](https://github.com/AppFlowy-IO/AppFlowy/commit/5476ff85c7badf9fedb76cc87cdd5d8bbca44fcf) Merge branch 'main' into fix/workaround-window-manager ### 📊 Changes **4 files changed** (+91 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/startup/tasks/windows.dart` (+39 -22) 📝 `frontend/appflowy_flutter/pubspec.lock` (+42 -2) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+7 -1) 📝 `frontend/appflowy_flutter/windows/runner/main.cpp` (+3 -0) </details> ### 📄 Description This is a workaround for an issue where `window_manager` improperly renders the window on Windows. --- We don't have a listener on Size of Window in bitsdojo, so we still rely on `window_manager`, the only difference is that we use Bitsdojo to render the frameless window instead of window_manager --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:16:55 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#6842
No description provided.