[PR #5487] [MERGED] fix: board shortcuts conflict with textfield #6846

New issue

Closed

opened 2026-03-23 23:16:56 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:16:56 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5487
Author: @LucasXu0
Created: 6/7/2024
Status: ✅ Merged
Merged: 6/10/2024
Merged by: @LucasXu0

Base: main ← Head: fix_board_shortcuts

📝 Commits (3)

50ea9b4 fix: board shortcuts conflict with text field
8c4e119 fix: typo
1d00fdb fix: favorite icon issue in dark mode

📊 Changes

7 files changed (+165 additions, -156 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database/board/presentation/board_page.dart (+54 -59)
📝 frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_column_header.dart (+0 -8)
📝 frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_focus_scope.dart (+25 -17)
📝 frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_shortcut_container.dart (+77 -59)
📝 frontend/appflowy_flutter/lib/plugins/shared/callback_shortcuts.dart (+6 -11)
📝 frontend/appflowy_flutter/lib/workspace/application/favorite/favorite_bloc.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/favorite_button.dart (+1 -1)

📄 Description

Feature Preview

closes https://github.com/AppFlowy-IO/AppFlowy/issues/5485

Known issue: The header name fails to update after a new header is created.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5487 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 6/7/2024 **Status:** ✅ Merged **Merged:** 6/10/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_board_shortcuts` --- ### 📝 Commits (3) - [`50ea9b4`](https://github.com/AppFlowy-IO/AppFlowy/commit/50ea9b4c04a97dd95abe018e8435c26ef2c57015) fix: board shortcuts conflict with text field - [`8c4e119`](https://github.com/AppFlowy-IO/AppFlowy/commit/8c4e1195e5ed1ad83b6249192f1a2dd40fc10c4c) fix: typo - [`1d00fdb`](https://github.com/AppFlowy-IO/AppFlowy/commit/1d00fdb65ca981f88f6e51c20980acbe244831b7) fix: favorite icon issue in dark mode ### 📊 Changes **7 files changed** (+165 additions, -156 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database/board/presentation/board_page.dart` (+54 -59) 📝 `frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_column_header.dart` (+0 -8) 📝 `frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_focus_scope.dart` (+25 -17) 📝 `frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_shortcut_container.dart` (+77 -59) 📝 `frontend/appflowy_flutter/lib/plugins/shared/callback_shortcuts.dart` (+6 -11) 📝 `frontend/appflowy_flutter/lib/workspace/application/favorite/favorite_bloc.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/favorite_button.dart` (+1 -1) </details> ### 📄 Description   ### Feature Preview closes https://github.com/AppFlowy-IO/AppFlowy/issues/5485 Known issue: The header name fails to update after a new header is created.  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>