[PR #5567] [MERGED] feat: shortcuts page remake #6893

New issue

Closed

opened 2026-03-23 23:17:09 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:17:09 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5567
Author: @Xazin
Created: 6/18/2024
Status: ✅ Merged
Merged: 6/19/2024
Merged by: @Xazin

Base: main ← Head: feat/shortcuts-page

📝 Commits (6)

5751c0d feat: settings shortcuts page remake
5a592f5 chore: merge branch 'upstream/main' into feat/shortcuts-page
9398e7f test: add shortcut test
3ed0e92 fix: physics on listview
55e1072 fix: menu icon
e27b9cf chore: merge branch 'upstream/main' into feat/shortcuts-page

📊 Changes

22 files changed (+1105 additions, -327 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/settings/settings_runner.dart (+2 -0)
➕ frontend/appflowy_flutter/integration_test/desktop/settings/shortcuts_settings_test.dart (+90 -0)
📝 frontend/appflowy_flutter/integration_test/shared/common_operations.dart (+18 -4)
📝 frontend/appflowy_flutter/integration_test/shared/settings.dart (+9 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+9 -8)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/align_toolbar_item/custom_text_align_command.dart (+5 -4)
📝 frontend/appflowy_flutter/lib/workspace/application/settings/shortcuts/settings_shortcuts_cubit.dart (+36 -25)
➕ frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_shortcuts_view.dart (+751 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/settings_dialog.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/shared/settings_body.dart (+1 -0)
➖ frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_customize_shortcuts_view.dart (+0 -261)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_menu.dart (+2 -2)
➕ frontend/resources/flowy_icons/16x/keyboard_arrow_down.svg (+8 -0)
➕ frontend/resources/flowy_icons/16x/keyboard_arrow_left.svg (+8 -0)
➕ frontend/resources/flowy_icons/16x/keyboard_arrow_right.svg (+8 -0)
➕ frontend/resources/flowy_icons/16x/keyboard_arrow_up.svg (+8 -0)
➕ frontend/resources/flowy_icons/16x/keyboard_meta.svg (+8 -0)
➕ frontend/resources/flowy_icons/16x/keyboard_option.svg (+8 -0)
➕ frontend/resources/flowy_icons/16x/keyboard_return.svg (+8 -0)
➕ frontend/resources/flowy_icons/16x/keyboard_shift.svg (+8 -0)

...and 2 more files

📄 Description

Closes: #5355 - Duplicates were removed earlier, and we can now translate all of the current shortcuts.
Closes: #3122

UI Redesign
Supports having commands without a keybinding (If overwritten due to a conflict)
Supports localizing the command by it's unique key

Feature Preview

To come...

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5567 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 6/18/2024 **Status:** ✅ Merged **Merged:** 6/19/2024 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `feat/shortcuts-page` --- ### 📝 Commits (6) - [`5751c0d`](https://github.com/AppFlowy-IO/AppFlowy/commit/5751c0d6e2fb61e7e005246906f6359331056926) feat: settings shortcuts page remake - [`5a592f5`](https://github.com/AppFlowy-IO/AppFlowy/commit/5a592f5b5266322679ef65aae60ee3420f5aa8b7) chore: merge branch 'upstream/main' into feat/shortcuts-page - [`9398e7f`](https://github.com/AppFlowy-IO/AppFlowy/commit/9398e7f06710ce9e9e93595328a1d47927497671) test: add shortcut test - [`3ed0e92`](https://github.com/AppFlowy-IO/AppFlowy/commit/3ed0e925c1c2ae0958f8259bfb8dc089434bd7e7) fix: physics on listview - [`55e1072`](https://github.com/AppFlowy-IO/AppFlowy/commit/55e1072980a60efe1a4677127358650e5e74e326) fix: menu icon - [`e27b9cf`](https://github.com/AppFlowy-IO/AppFlowy/commit/e27b9cf0193374e1466c6b5d5637fbf3a22bc5b9) chore: merge branch 'upstream/main' into feat/shortcuts-page ### 📊 Changes **22 files changed** (+1105 additions, -327 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/settings/settings_runner.dart` (+2 -0) ➕ `frontend/appflowy_flutter/integration_test/desktop/settings/shortcuts_settings_test.dart` (+90 -0) 📝 `frontend/appflowy_flutter/integration_test/shared/common_operations.dart` (+18 -4) 📝 `frontend/appflowy_flutter/integration_test/shared/settings.dart` (+9 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+9 -8) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/align_toolbar_item/custom_text_align_command.dart` (+5 -4) 📝 `frontend/appflowy_flutter/lib/workspace/application/settings/shortcuts/settings_shortcuts_cubit.dart` (+36 -25) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_shortcuts_view.dart` (+751 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/settings_dialog.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/shared/settings_body.dart` (+1 -0) ➖ `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_customize_shortcuts_view.dart` (+0 -261) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_menu.dart` (+2 -2) ➕ `frontend/resources/flowy_icons/16x/keyboard_arrow_down.svg` (+8 -0) ➕ `frontend/resources/flowy_icons/16x/keyboard_arrow_left.svg` (+8 -0) ➕ `frontend/resources/flowy_icons/16x/keyboard_arrow_right.svg` (+8 -0) ➕ `frontend/resources/flowy_icons/16x/keyboard_arrow_up.svg` (+8 -0) ➕ `frontend/resources/flowy_icons/16x/keyboard_meta.svg` (+8 -0) ➕ `frontend/resources/flowy_icons/16x/keyboard_option.svg` (+8 -0) ➕ `frontend/resources/flowy_icons/16x/keyboard_return.svg` (+8 -0) ➕ `frontend/resources/flowy_icons/16x/keyboard_shift.svg` (+8 -0) _...and 2 more files_ </details> ### 📄 Description Closes: #5355 - Duplicates were removed earlier, and we can now translate all of the current shortcuts. Closes: #3122 - UI Redesign - Supports having commands without a keybinding _(If overwritten due to a conflict)_ - Supports localizing the command by it's unique `key` ### Feature Preview To come... #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>