[PR #5586] [MERGED] fix: duplicated spaces could be created when migrating #6901

Closed
opened 2026-03-23 23:17:11 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5586
Author: @LucasXu0
Created: 6/20/2024
Status: Merged
Merged: 6/20/2024
Merged by: @LucasXu0

Base: release/0.6.1Head: relesae/0.6.1


📝 Commits (5)

  • 605278e fix: duplicated spaces could be created when migrating
  • edc485e chore: bump version 0.6.1
  • fb6fc94 fix: use fixed uuid to generate space id
  • 9d46700 fix: rust ci
  • b9e2899 chore: remove libmpv dependency

📊 Changes

18 files changed (+167 additions, -127 deletions)

View changed files

📝 frontend/Makefile.toml (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/space/mobile_space.dart (+21 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/mobile_bottom_navigation_bar.dart (+5 -44)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/appflowy_mobile_toolbar.dart (+21 -33)
📝 frontend/appflowy_flutter/lib/workspace/application/sidebar/space/space_bloc.dart (+76 -41)
📝 frontend/appflowy_flutter/lib/workspace/application/view/view_service.dart (+5 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/workspace/workspace_service.dart (+5 -0)
📝 frontend/appflowy_flutter/packages/flowy_infra/lib/uuid.dart (+15 -1)
📝 frontend/appflowy_flutter/pubspec.lock (+2 -2)
📝 frontend/appflowy_flutter/pubspec.yaml (+2 -2)
📝 frontend/rust-lib/event-integration-test/src/chat_event.rs (+1 -0)
📝 frontend/rust-lib/event-integration-test/src/database_event.rs (+3 -0)
📝 frontend/rust-lib/event-integration-test/src/document/document_event.rs (+1 -0)
📝 frontend/rust-lib/event-integration-test/src/document_event.rs (+1 -0)
📝 frontend/rust-lib/event-integration-test/src/folder_event.rs (+2 -0)
📝 frontend/rust-lib/event-integration-test/tests/folder/local_test/script.rs (+1 -0)
📝 frontend/rust-lib/flowy-folder/src/entities/view.rs (+5 -1)
📝 frontend/scripts/linux_distribution/appimage/AppImageBuilder.yml (+0 -2)

📄 Description

Feature Preview

Ignore the private views with the 'space' tag when migrating to a new space to avoid duplicating.


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5586 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 6/20/2024 **Status:** ✅ Merged **Merged:** 6/20/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `release/0.6.1` ← **Head:** `relesae/0.6.1` --- ### 📝 Commits (5) - [`605278e`](https://github.com/AppFlowy-IO/AppFlowy/commit/605278e4e77ec05089ccab629f5de420fc6035bb) fix: duplicated spaces could be created when migrating - [`edc485e`](https://github.com/AppFlowy-IO/AppFlowy/commit/edc485ed36f8ef8594289de22aa116d9f6bbe3db) chore: bump version 0.6.1 - [`fb6fc94`](https://github.com/AppFlowy-IO/AppFlowy/commit/fb6fc948c4c4b1b9d0421a4710fbfaf3eafd7106) fix: use fixed uuid to generate space id - [`9d46700`](https://github.com/AppFlowy-IO/AppFlowy/commit/9d46700e674fcc8fa0fcfbe6721e9f894eb3ab34) fix: rust ci - [`b9e2899`](https://github.com/AppFlowy-IO/AppFlowy/commit/b9e28991f66feb033243eebcfcd8910d3220ca5d) chore: remove libmpv dependency ### 📊 Changes **18 files changed** (+167 additions, -127 deletions) <details> <summary>View changed files</summary> 📝 `frontend/Makefile.toml` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/space/mobile_space.dart` (+21 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/mobile_bottom_navigation_bar.dart` (+5 -44) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/appflowy_mobile_toolbar.dart` (+21 -33) 📝 `frontend/appflowy_flutter/lib/workspace/application/sidebar/space/space_bloc.dart` (+76 -41) 📝 `frontend/appflowy_flutter/lib/workspace/application/view/view_service.dart` (+5 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/workspace/workspace_service.dart` (+5 -0) 📝 `frontend/appflowy_flutter/packages/flowy_infra/lib/uuid.dart` (+15 -1) 📝 `frontend/appflowy_flutter/pubspec.lock` (+2 -2) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+2 -2) 📝 `frontend/rust-lib/event-integration-test/src/chat_event.rs` (+1 -0) 📝 `frontend/rust-lib/event-integration-test/src/database_event.rs` (+3 -0) 📝 `frontend/rust-lib/event-integration-test/src/document/document_event.rs` (+1 -0) 📝 `frontend/rust-lib/event-integration-test/src/document_event.rs` (+1 -0) 📝 `frontend/rust-lib/event-integration-test/src/folder_event.rs` (+2 -0) 📝 `frontend/rust-lib/event-integration-test/tests/folder/local_test/script.rs` (+1 -0) 📝 `frontend/rust-lib/flowy-folder/src/entities/view.rs` (+5 -1) 📝 `frontend/scripts/linux_distribution/appimage/AppImageBuilder.yml` (+0 -2) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview Ignore the private views with the 'space' tag when migrating to a new space to avoid duplicating. <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:17:11 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#6901
No description provided.