[PR #5590] [MERGED] fix: settings ui improvements #6904

New issue

Closed

opened 2026-03-23 23:17:12 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:17:12 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5590
Author: @Xazin
Created: 6/20/2024
Status: ✅ Merged
Merged: 6/20/2024
Merged by: @Xazin

Base: main ← Head: fix/setting-ui

📝 Commits (5)

911624c fix: settings ui improvements
cae6139 fix: replace placeholder + fix open folder
4591eb8 fix: collapse sidebar button on windows
da272a3 test: fix tests after changes
aaeca57 test: missed type cast

📊 Changes

21 files changed (+269 additions, -284 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/settings/notifications_settings_test.dart (+10 -10)
📝 frontend/appflowy_flutter/lib/core/frameless_window.dart (+17 -10)
📝 frontend/appflowy_flutter/lib/plugins/database/calendar/presentation/toolbar/calendar_layout_setting.dart (+2 -3)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/field/field_editor.dart (+2 -3)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/field/type_option_editor/date/date_time_format.dart (+2 -3)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/group/database_group.dart (+0 -2)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_manage_data_view.dart (+17 -61)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_plan_comparison_dialog.dart (+47 -44)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_plan_view.dart (+20 -20)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_workspace_view.dart (+0 -3)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/_restart_app_button.dart (+33 -14)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/setting_appflowy_cloud.dart (+0 -2)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/setting_cloud.dart (+60 -69)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_notifications_view.dart (+3 -6)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/widgets/end_time_button.dart (+2 -3)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/toggle/toggle.dart (+33 -5)
➖ frontend/appflowy_flutter/lib/workspace/presentation/widgets/toggle/toggle_style.dart (+0 -20)
📝 frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/default_colorscheme.dart (+1 -1)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/button.dart (+8 -2)
➕ frontend/resources/flowy_icons/16x/close_error.svg (+9 -0)

...and 1 more files

📄 Description

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5590 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 6/20/2024 **Status:** ✅ Merged **Merged:** 6/20/2024 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `fix/setting-ui` --- ### 📝 Commits (5) - [`911624c`](https://github.com/AppFlowy-IO/AppFlowy/commit/911624c07ca60585a15430daa347fca3fe80a025) fix: settings ui improvements - [`cae6139`](https://github.com/AppFlowy-IO/AppFlowy/commit/cae6139ff37d97e012b60b64922fb72ebb1bbcb6) fix: replace placeholder + fix open folder - [`4591eb8`](https://github.com/AppFlowy-IO/AppFlowy/commit/4591eb850f37eb25c4f3cc0ffefcf734805e2ec4) fix: collapse sidebar button on windows - [`da272a3`](https://github.com/AppFlowy-IO/AppFlowy/commit/da272a38c133c2d249128ea7a5b74b0e9a88f34e) test: fix tests after changes - [`aaeca57`](https://github.com/AppFlowy-IO/AppFlowy/commit/aaeca575556fc43695ede23016740c3426e420bb) test: missed type cast ### 📊 Changes **21 files changed** (+269 additions, -284 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/settings/notifications_settings_test.dart` (+10 -10) 📝 `frontend/appflowy_flutter/lib/core/frameless_window.dart` (+17 -10) 📝 `frontend/appflowy_flutter/lib/plugins/database/calendar/presentation/toolbar/calendar_layout_setting.dart` (+2 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/field/field_editor.dart` (+2 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/field/type_option_editor/date/date_time_format.dart` (+2 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/group/database_group.dart` (+0 -2) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_manage_data_view.dart` (+17 -61) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_plan_comparison_dialog.dart` (+47 -44) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_plan_view.dart` (+20 -20) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_workspace_view.dart` (+0 -3) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/_restart_app_button.dart` (+33 -14) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/setting_appflowy_cloud.dart` (+0 -2) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/setting_cloud.dart` (+60 -69) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_notifications_view.dart` (+3 -6) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/widgets/end_time_button.dart` (+2 -3) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/toggle/toggle.dart` (+33 -5) ➖ `frontend/appflowy_flutter/lib/workspace/presentation/widgets/toggle/toggle_style.dart` (+0 -20) 📝 `frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/default_colorscheme.dart` (+1 -1) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/button.dart` (+8 -2) ➕ `frontend/resources/flowy_icons/16x/close_error.svg` (+9 -0) _...and 1 more files_ </details> ### 📄 Description #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>