[PR #5598] [MERGED] fix: fill field_settings on creating linked view #6910

New issue

Closed

opened 2026-03-23 23:17:14 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:17:14 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5598
Author: @zoli
Created: 6/21/2024
Status: ✅ Merged
Merged: 6/27/2024
Merged by: @Xazin

Base: main ← Head: fix/linked-view-field-settings

📝 Commits (5)

03bf268 fix: fill field_settings on creating linked view
e686590 chore: merge branch 'upstream/main' into HEAD
fb625d0 chore: merge branch 'upstream/main' into HEAD
2fd1a1b fix: use params to reduce args
7f590ce fix: remove redundant meta arg

📊 Changes

5 files changed (+65 additions, -57 deletions)

View changed files

📝 frontend/rust-lib/flowy-core/src/deps_resolve/folder_deps.rs (+26 -30)
📝 frontend/rust-lib/flowy-database2/src/manager.rs (+7 -2)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/layout_deps.rs (+29 -10)
📝 frontend/rust-lib/flowy-folder/src/manager.rs (+2 -10)
📝 frontend/rust-lib/flowy-folder/src/view_operation.rs (+1 -5)

📄 Description

Create a grid
create a board view from that grid
Change group field of the board view

You will see that the cards are empty and if you click on the card it throws an error.

The problem is the field_settings in field_infos are empty. The root cause is that on creating linked view it doesn't add fields settings from the view we are linking to.
I fixed this by getting field settings from the parent view (the one we are linking new view) and adding it to the new view that is getting created.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5598 **Author:** [@zoli](https://github.com/zoli) **Created:** 6/21/2024 **Status:** ✅ Merged **Merged:** 6/27/2024 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `fix/linked-view-field-settings` --- ### 📝 Commits (5) - [`03bf268`](https://github.com/AppFlowy-IO/AppFlowy/commit/03bf268b1df33300e8c68f2ff8de743ae3e13187) fix: fill field_settings on creating linked view - [`e686590`](https://github.com/AppFlowy-IO/AppFlowy/commit/e686590e673d553ac117bbfcac4ce4e1399e459f) chore: merge branch 'upstream/main' into HEAD - [`fb625d0`](https://github.com/AppFlowy-IO/AppFlowy/commit/fb625d0eb40f37fa39858c0e97524ab1599d21a4) chore: merge branch 'upstream/main' into HEAD - [`2fd1a1b`](https://github.com/AppFlowy-IO/AppFlowy/commit/2fd1a1b98025d209808a6475c851bb6a03c97bb4) fix: use params to reduce args - [`7f590ce`](https://github.com/AppFlowy-IO/AppFlowy/commit/7f590ce9a6f16cfc25956aec48e308fcf96e3876) fix: remove redundant meta arg ### 📊 Changes **5 files changed** (+65 additions, -57 deletions) <details> <summary>View changed files</summary> 📝 `frontend/rust-lib/flowy-core/src/deps_resolve/folder_deps.rs` (+26 -30) 📝 `frontend/rust-lib/flowy-database2/src/manager.rs` (+7 -2) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/layout_deps.rs` (+29 -10) 📝 `frontend/rust-lib/flowy-folder/src/manager.rs` (+2 -10) 📝 `frontend/rust-lib/flowy-folder/src/view_operation.rs` (+1 -5) </details> ### 📄 Description 1. Create a grid 2. create a board view from that grid 3. Change group field of the board view You will see that the cards are empty and if you click on the card it throws an error. The problem is the `field_settings` in `field_infos` are empty. The root cause is that on creating linked view it doesn't add fields settings from the view we are linking to. I fixed this by getting field settings from the parent view (the one we are linking new view) and adding it to the new view that is getting created. #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>