[PR #5619] [MERGED] fix: prevent overfow of space name and view name #6919

Closed
opened 2026-03-23 23:17:16 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5619
Author: @LucasXu0
Created: 6/25/2024
Status: Merged
Merged: 6/25/2024
Merged by: @LucasXu0

Base: mainHead: space_name_overflow


📝 Commits (3)

  • 742f6ba fix: space name overflow
  • 08b9263 fix: space name overflow in space menu
  • cb61da0 fix: view name overflow in favorite menu

📊 Changes

4 files changed (+40 additions, -27 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/shared_widget.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/sidebar_space_header.dart (+32 -25)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/sidebar_space_menu.dart (+6 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart (+1 -1)

📄 Description

Feature Preview

closes https://github.com/AppFlowy-IO/AppFlowy/issues/5609
closes https://github.com/AppFlowy-IO/AppFlowy/issues/5607

space menu
Screenshot 2024-06-25 at 17 02 13

favorite menu
Screenshot 2024-06-25 at 17 02 36


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5619 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 6/25/2024 **Status:** ✅ Merged **Merged:** 6/25/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `space_name_overflow` --- ### 📝 Commits (3) - [`742f6ba`](https://github.com/AppFlowy-IO/AppFlowy/commit/742f6baa5c5d9a72165133ec8f5790b1b2bcc8b6) fix: space name overflow - [`08b9263`](https://github.com/AppFlowy-IO/AppFlowy/commit/08b9263dffe1bdd8cc1295946e187d6c290261e2) fix: space name overflow in space menu - [`cb61da0`](https://github.com/AppFlowy-IO/AppFlowy/commit/cb61da0554eb0f68bbd3dadc6c7ab1becacb7306) fix: view name overflow in favorite menu ### 📊 Changes **4 files changed** (+40 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/shared_widget.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/sidebar_space_header.dart` (+32 -25) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/sidebar_space_menu.dart` (+6 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart` (+1 -1) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview closes https://github.com/AppFlowy-IO/AppFlowy/issues/5609 closes https://github.com/AppFlowy-IO/AppFlowy/issues/5607 space menu <img width="278" alt="Screenshot 2024-06-25 at 17 02 13" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/9f4e04a3-383c-4ccc-a9c1-e7168ec1d3e2"> favorite menu <img width="337" alt="Screenshot 2024-06-25 at 17 02 36" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/fb4d1620-bbea-4905-8abd-e8fbcb239198"> <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:17:16 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#6919
No description provided.