[PR #5622] [MERGED] fix: maximized window optimization #6921

New issue

Closed

opened 2026-03-23 23:17:17 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:17:17 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5622
Author: @Xazin
Created: 6/25/2024
Status: ✅ Merged
Merged: 6/25/2024
Merged by: @Xazin

Base: main ← Head: fix/maximized-window

📝 Commits (1)

e7b203a fix: maximized window optimization

📊 Changes

3 files changed (+41 additions, -11 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/core/config/kv_keys.dart (+7 -0)
📝 frontend/appflowy_flutter/lib/startup/tasks/app_window_size_manager.dart (+15 -0)
📝 frontend/appflowy_flutter/lib/startup/tasks/windows.dart (+19 -11)

📄 Description

I've stopped saving the size of the window when it has been maximized, this means that when closing the application on Linux and MacOS from a maximized state, the application will open in it's previously regular state and size.

For Windows, I've added the previous maximized state to persistence, and maximize the window if it was previously maximized on application launch. This seems to be the standard behavior for Windows applications.

Relates: #3287
Closes: #2904 - PS. This is for windows only, applications on MacOS when closed will turn to regular state, so it cannot open maximized.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5622 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 6/25/2024 **Status:** ✅ Merged **Merged:** 6/25/2024 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `fix/maximized-window` --- ### 📝 Commits (1) - [`e7b203a`](https://github.com/AppFlowy-IO/AppFlowy/commit/e7b203aeadf31dd238d646d6b5e0e4da75a1a8f7) fix: maximized window optimization ### 📊 Changes **3 files changed** (+41 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/core/config/kv_keys.dart` (+7 -0) 📝 `frontend/appflowy_flutter/lib/startup/tasks/app_window_size_manager.dart` (+15 -0) 📝 `frontend/appflowy_flutter/lib/startup/tasks/windows.dart` (+19 -11) </details> ### 📄 Description I've stopped saving the size of the window when it has been maximized, this means that when closing the application on Linux and MacOS from a maximized state, the application will open in it's previously regular state and size. For Windows, I've added the previous maximized state to persistence, and maximize the window if it was previously maximized on application launch. This seems to be the standard behavior for Windows applications. Relates: #3287 Closes: #2904 - PS. This is for windows only, applications on MacOS when closed will turn to regular state, so it cannot open maximized. #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>