[PR #5620] [CLOSED] feat: add key '+'' as zoom-in key #6922

New issue

Closed

opened 2026-03-23 23:17:17 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:17:17 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5620
Author: @LucasXu0
Created: 6/25/2024
Status: ❌ Closed

Base: main ← Head: upgrade_hot_key_manager

📝 Commits (5)

9724219 feat: add key '+'' as zoom-in key
a64300d fix: only register hot key if it's not existing
8d123d5 chore: fix integration test
f41c03b chore: try to fix integration test
0e6d0c2 chore: try to fix integration test

📊 Changes

8 files changed (+122 additions, -47 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/uncategorized/hotkeys_test.dart (+8 -15)
📝 frontend/appflowy_flutter/integration_test/desktop/uncategorized/tabs_test.dart (+3 -0)
📝 frontend/appflowy_flutter/integration_test/desktop_runner_3.dart (+0 -1)
📝 frontend/appflowy_flutter/integration_test/shared/keyboard.dart (+2 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/hotkeys.dart (+60 -24)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/shared/sidebar_setting.dart (+6 -4)
📝 frontend/appflowy_flutter/pubspec.lock (+42 -2)
📝 frontend/appflowy_flutter/pubspec.yaml (+1 -1)

📄 Description

Feature Preview

closes https://github.com/AppFlowy-IO/AppFlowy/issues/5601

In some keyboards, the system returns equal as + keycode, while others may return add as + keycode, so add them both as zoom in key.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5620 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 6/25/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `upgrade_hot_key_manager` --- ### 📝 Commits (5) - [`9724219`](https://github.com/AppFlowy-IO/AppFlowy/commit/9724219452dfed0548487042f37417407efdef25) feat: add key '+'' as zoom-in key - [`a64300d`](https://github.com/AppFlowy-IO/AppFlowy/commit/a64300d42f130a0bff75a4581bd9b91777a72c5f) fix: only register hot key if it's not existing - [`8d123d5`](https://github.com/AppFlowy-IO/AppFlowy/commit/8d123d50a2ed87f7f5b53c64621f8f58c23d03ea) chore: fix integration test - [`f41c03b`](https://github.com/AppFlowy-IO/AppFlowy/commit/f41c03b5315b6cfab139ecbf57db8d010b4a79eb) chore: try to fix integration test - [`0e6d0c2`](https://github.com/AppFlowy-IO/AppFlowy/commit/0e6d0c2491844ba557b2a836e136af0dcdc4d77f) chore: try to fix integration test ### 📊 Changes **8 files changed** (+122 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/uncategorized/hotkeys_test.dart` (+8 -15) 📝 `frontend/appflowy_flutter/integration_test/desktop/uncategorized/tabs_test.dart` (+3 -0) 📝 `frontend/appflowy_flutter/integration_test/desktop_runner_3.dart` (+0 -1) 📝 `frontend/appflowy_flutter/integration_test/shared/keyboard.dart` (+2 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/hotkeys.dart` (+60 -24) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/shared/sidebar_setting.dart` (+6 -4) 📝 `frontend/appflowy_flutter/pubspec.lock` (+42 -2) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+1 -1) </details> ### 📄 Description   ### Feature Preview closes https://github.com/AppFlowy-IO/AppFlowy/issues/5601 In some keyboards, the system returns equal as + keycode, while others may return add as + keycode, so add them both as zoom in key.  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>