[PR #5677] [MERGED] FR: Users choose color from palette or picker #5041 #6949

Closed
opened 2026-03-23 23:17:24 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5677
Author: @gustamor
Created: 7/2/2024
Status: Merged
Merged: 7/10/2024
Merged by: @LucasXu0

Base: mainHead: feat/user_choose_color_from_palette_or_picker_5041


📝 Commits (5)

  • 050478f chore: show ai service error (#5675)
  • 19dcc46 feat: Implement color picker dialog for user color selection (#5041)
  • ad178d6 feat: Implement color picker dialog for user color selection (#5041)
  • e060d85 Merge branch 'main' into feat/user_choose_color_from_palette_or_picker_5041
  • bed68e9 chore: refactor code

📊 Changes

4 files changed (+204 additions, -20 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/shared/document_color_setting_button.dart (+184 -20)
📝 frontend/appflowy_flutter/pubspec.lock (+16 -0)
📝 frontend/appflowy_flutter/pubspec.yaml (+1 -0)
📝 frontend/resources/translations/en.json (+3 -0)

📄 Description

Feature Preview

https://github.com/AppFlowy-IO/AppFlowy/assets/131178967/ed977a87-a009-4a7a-a50f-12a22776af49

  • Added flex_color_picker dependency.
  • Implemented a new color picker dialog with the following features:
    • Display Material predefined colors.
    • Include primary, accent, and shade colors, as well as a color wheel for selection.
    • Add a graphical opacity selector.
    • Enhanced the previous dialog to include an icon in a text field for opening the palette.
  • Added suffixIcon parameter to the _ColorSettingTextField class, making it reactive to tap gestures.
  • Utilized ColorExtension on the Color class to avoid namespace conflicts when converting colors to hexadecimal strings.
  • Added translation strings to english

Addresses (https://github.com/AppFlowy-IO/appflowy/issues/5041): [FR] Let user pick from a list of predefined colors for selection and cursor colors.


Hand-made tests done on:

  • Linux (Pop_OS!)
  • Macos M2
  • Web application
  • Mobile

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5677 **Author:** [@gustamor](https://github.com/gustamor) **Created:** 7/2/2024 **Status:** ✅ Merged **Merged:** 7/10/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `feat/user_choose_color_from_palette_or_picker_5041` --- ### 📝 Commits (5) - [`050478f`](https://github.com/AppFlowy-IO/AppFlowy/commit/050478ff42c2413b9bfd469825c1a3486f221815) chore: show ai service error (#5675) - [`19dcc46`](https://github.com/AppFlowy-IO/AppFlowy/commit/19dcc46827389772bf77dabb8b8b23c09d23f44d) feat: Implement color picker dialog for user color selection (#5041) - [`ad178d6`](https://github.com/AppFlowy-IO/AppFlowy/commit/ad178d6d9c8e482fe47395803af2311954269b4e) feat: Implement color picker dialog for user color selection (#5041) - [`e060d85`](https://github.com/AppFlowy-IO/AppFlowy/commit/e060d851b93f2fc0988847b55a5c496bece02a9a) Merge branch 'main' into feat/user_choose_color_from_palette_or_picker_5041 - [`bed68e9`](https://github.com/AppFlowy-IO/AppFlowy/commit/bed68e96ff7ffc63ec2f27beab367fc3a4d4e160) chore: refactor code ### 📊 Changes **4 files changed** (+204 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/shared/document_color_setting_button.dart` (+184 -20) 📝 `frontend/appflowy_flutter/pubspec.lock` (+16 -0) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+1 -0) 📝 `frontend/resources/translations/en.json` (+3 -0) </details> ### 📄 Description ### Feature Preview https://github.com/AppFlowy-IO/AppFlowy/assets/131178967/ed977a87-a009-4a7a-a50f-12a22776af49 - Added `flex_color_picker` dependency. - Implemented a new color picker dialog with the following features: - Display Material predefined colors. - Include primary, accent, and shade colors, as well as a color wheel for selection. - Add a graphical opacity selector. - Enhanced the previous dialog to include an icon in a text field for opening the palette. - Added `suffixIcon` parameter to the `_ColorSettingTextField` class, making it reactive to tap gestures. - Utilized `ColorExtension` on the `Color` class to avoid namespace conflicts when converting colors to hexadecimal strings. - Added translation strings to english Addresses (https://github.com/AppFlowy-IO/appflowy/issues/5041): [FR] Let user pick from a list of predefined colors for selection and cursor colors. --- Hand-made tests done on: - [x] Linux (Pop_OS!) - [x] Macos M2 - [ ] Web application - [ ] Mobile #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:17:24 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#6949
No description provided.