[PR #5700] [MERGED] fix: take the max value of the keyboard height and the view insets bottom to make the toolbar visible #6955

New issue

Closed

opened 2026-03-23 23:17:27 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:17:27 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5700
Author: @LucasXu0
Created: 7/8/2024
Status: ✅ Merged
Merged: 7/8/2024
Merged by: @LucasXu0

Base: main ← Head: fix_android_toolbar_v2

📝 Commits (5)

fdfbeb9 fix: android toolbar will be blocked if the scroll bar is hidden
5d53d42 fix: last opened view is synced in same workspace
50c49ec fix: fallback to space if the section sidebar contains space
d8668f9 chore: revert last opened view code
a4d82d5 fix: integration tests

📊 Changes

6 files changed (+91 additions, -19 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/uncategorized/empty_test.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/appflowy_mobile_toolbar.dart (+21 -5)
📝 frontend/appflowy_flutter/lib/workspace/application/home/home_bloc.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/menu/sidebar_sections_bloc.dart (+12 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/sidebar/space/space_bloc.dart (+33 -10)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar.dart (+23 -4)

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5700 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 7/8/2024 **Status:** ✅ Merged **Merged:** 7/8/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_android_toolbar_v2` --- ### 📝 Commits (5) - [`fdfbeb9`](https://github.com/AppFlowy-IO/AppFlowy/commit/fdfbeb9766438d8201d7310969db1f271566f584) fix: android toolbar will be blocked if the scroll bar is hidden - [`5d53d42`](https://github.com/AppFlowy-IO/AppFlowy/commit/5d53d42d49c613824c85922643f2a05d3457df0b) fix: last opened view is synced in same workspace - [`50c49ec`](https://github.com/AppFlowy-IO/AppFlowy/commit/50c49ec2a77cde0dd2a21555845a73ec0ae95859) fix: fallback to space if the section sidebar contains space - [`d8668f9`](https://github.com/AppFlowy-IO/AppFlowy/commit/d8668f9025f129c73c1fb6d573affae3acb28ab1) chore: revert last opened view code - [`a4d82d5`](https://github.com/AppFlowy-IO/AppFlowy/commit/a4d82d58658cc32e3413e5f3c0dab7d4bf169b45) fix: integration tests ### 📊 Changes **6 files changed** (+91 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/uncategorized/empty_test.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/appflowy_mobile_toolbar.dart` (+21 -5) 📝 `frontend/appflowy_flutter/lib/workspace/application/home/home_bloc.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/menu/sidebar_sections_bloc.dart` (+12 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/sidebar/space/space_bloc.dart` (+33 -10) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar.dart` (+23 -4) </details> ### 📄 Description   ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>