[PR #5767] [MERGED] fix: Add retry for admin client sign in for test #6996

New issue

Closed

opened 2026-03-23 23:17:38 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:17:38 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5767
Author: @khorshuheng
Created: 7/20/2024
Status: ✅ Merged
Merged: 7/22/2024
Merged by: @appflowy

Base: main ← Head: retry-admin-sign-in

📝 Commits (1)

fa2890c fix: Add retry for admin client sign in for test

📊 Changes

1 file changed (+11 additions, -2 deletions)

View changed files

📝 frontend/rust-lib/flowy-server/src/af_cloud/impls/user/cloud_service_impl.rs (+11 -2)

📄 Description

Feature Preview

In https://github.com/AppFlowy-IO/AppFlowy-Cloud/pull/690 , the pg advisory lock has been removed. As a result, if there are concurrent requests to verify a new user's token, only the first request will succeed. In practice, this should rarely happen, and if they do, it's good to throw an error in such case, as concurrent requests like this could be a sign
that there is a bug on the client end.

However, this scenario can happen in test. Cargo execute tests in parallel. Even though unique users and emails are created for most cases, all of them still rely on the admin client to send a request to appflowy cloud in order to generate a sign in url. And all admin client instances share the same user name and email.

This can be resolved if we retry the admin sign in attempt once.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5767 **Author:** [@khorshuheng](https://github.com/khorshuheng) **Created:** 7/20/2024 **Status:** ✅ Merged **Merged:** 7/22/2024 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `retry-admin-sign-in` --- ### 📝 Commits (1) - [`fa2890c`](https://github.com/AppFlowy-IO/AppFlowy/commit/fa2890c5a9431a350cafa5190ac5a48251b81a24) fix: Add retry for admin client sign in for test ### 📊 Changes **1 file changed** (+11 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `frontend/rust-lib/flowy-server/src/af_cloud/impls/user/cloud_service_impl.rs` (+11 -2) </details> ### 📄 Description   ### Feature Preview In https://github.com/AppFlowy-IO/AppFlowy-Cloud/pull/690 , the pg advisory lock has been removed. As a result, if there are concurrent requests to verify a new user's token, only the first request will succeed. In practice, this should rarely happen, and if they do, it's good to throw an error in such case, as concurrent requests like this could be a sign that there is a bug on the client end. However, this scenario can happen in test. Cargo execute tests in parallel. Even though unique users and emails are created for most cases, all of them still rely on the admin client to send a request to appflowy cloud in order to generate a sign in url. And all admin client instances share the same user name and email. This can be resolved if we retry the admin sign in attempt once.  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>