[PR #5770] [MERGED] chore: remove unused step in rust CI, allow cache on failure, show container logs #6999

New issue

Closed

opened 2026-03-23 23:17:38 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:17:38 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5770
Author: @khorshuheng
Created: 7/21/2024
Status: ✅ Merged
Merged: 7/24/2024
Merged by: @appflowy

Base: main ← Head: remove-unused-step

📝 Commits (1)

cc5e374 chore: remove unused step in rust CI, allow cache on failure, show container logs

📊 Changes

1 file changed (+8 additions, -7 deletions)

View changed files

📝 .github/workflows/rust_ci.yaml (+8 -7)

📄 Description

Feature Preview

Cargo make is not necessary in rust CI as we do not invoke any Cargo make command at this stage. Similarly, we don't need duck script.
Cache on failure will help subsequent test run to be faster if it fails.
Add a step to show appflowy cloud container log in the event of CI failure to facilitate debugging.
Allow CI to be triggered on PR if rust_ci.yaml file changes.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5770 **Author:** [@khorshuheng](https://github.com/khorshuheng) **Created:** 7/21/2024 **Status:** ✅ Merged **Merged:** 7/24/2024 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `remove-unused-step` --- ### 📝 Commits (1) - [`cc5e374`](https://github.com/AppFlowy-IO/AppFlowy/commit/cc5e374b1af538333a16eaf70e055134f780049c) chore: remove unused step in rust CI, allow cache on failure, show container logs ### 📊 Changes **1 file changed** (+8 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/rust_ci.yaml` (+8 -7) </details> ### 📄 Description   ### Feature Preview 1. Cargo make is not necessary in rust CI as we do not invoke any Cargo make command at this stage. Similarly, we don't need duck script. 2. Cache on failure will help subsequent test run to be faster if it fails. 3. Add a step to show appflowy cloud container log in the event of CI failure to facilitate debugging. 4. Allow CI to be triggered on PR if rust_ci.yaml file changes.  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>