[GH-ISSUE #1800] [Bug] the data property including time default time #703

Closed
opened 2026-03-23 20:39:57 +00:00 by mirror · 3 comments
Owner

Originally created by @annieappflowy on GitHub (Feb 4, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/1800

Originally assigned to: @richardshiue on GitHub.

Bug Description

image

After toggling on "Include time", the time field is prefilled a time as a placeholder.
If the user doesn't enter the edit mode to update it, I feel it should just auto-fill time with this placeholder time rather than not updating the time?

As seen in the screenshot, if I don't edit the time field and close the menu instead, the property value should show Feb 07, 2023 13:00 rather than Feb 07, 2023. This is because I already toggled on "Include time" even though I have not edited the time field.

How to Reproduce

As described in the bug description

Expected Behavior

As described in the bug description

Operating System

Windows 10

AppFlowy Version(s)

main branch

Screenshots

No response

Additional Context

No response

Originally created by @annieappflowy on GitHub (Feb 4, 2023). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/1800 Originally assigned to: @richardshiue on GitHub. ### Bug Description <img width="270" alt="image" src="https://user-images.githubusercontent.com/12026239/216755433-f4b6dfa8-5a56-440f-99ac-f9b4e4acfdf8.png"> After toggling on "Include time", the time field is prefilled a time as a placeholder. If the user doesn't enter the edit mode to update it, I feel it should just auto-fill time with this placeholder time rather than not updating the time? As seen in the screenshot, if I don't edit the time field and close the menu instead, the property value should show Feb 07, 2023 13:00 rather than Feb 07, 2023. This is because I already toggled on "Include time" even though I have not edited the time field. ### How to Reproduce As described in the bug description ### Expected Behavior As described in the bug description ### Operating System Windows 10 ### AppFlowy Version(s) main branch ### Screenshots _No response_ ### Additional Context _No response_
mirror 2026-03-23 20:39:57 +00:00
  • closed this issue
  • added the
    calendar
    label
Author
Owner

@richardshiue commented on GitHub (Feb 9, 2023):

Currently, the placeholder text (13:00) is there to inform the user of the current time format (12h vs 24h), but as you pointed out, it's causing UX issues. I guess there are two choices to make here:

  • which default value should be automatically applied if "includeTime" is true. It's 00:00 in Notion (and AppFlowy too but is bugged, see below), but it can also be, for example, 8:00 am or the current time when includeTime is toggled.
  • don't show a placeholder at all vs showing a placeholder of the default value

Let's decide on the UX and create separate issues

should show Feb 07, 2023 13:00 rather than Feb 07, 2023

This is a bug. Time of 00:00 is being presented as an empty string.

<!-- gh-comment-id:1424175558 --> @richardshiue commented on GitHub (Feb 9, 2023): Currently, the placeholder text (13:00) is there to inform the user of the current time format (12h vs 24h), but as you pointed out, it's causing UX issues. I guess there are two choices to make here: - which default value should be automatically applied if "includeTime" is true. It's 00:00 in Notion (and AppFlowy too but is bugged, see below), but it can also be, for example, 8:00 am or the current time when includeTime is toggled. - don't show a placeholder at all vs showing a placeholder of the default value Let's decide on the UX and create separate issues > should show Feb 07, 2023 13:00 rather than Feb 07, 2023 This is a bug. Time of 00:00 is being presented as an empty string.
Author
Owner

@richardshiue commented on GitHub (Feb 23, 2023):

Gentle ping @annieappflowy

<!-- gh-comment-id:1441248813 --> @richardshiue commented on GitHub (Feb 23, 2023): Gentle ping @annieappflowy
Author
Owner

@annieappflowy commented on GitHub (Feb 23, 2023):

I'd prefer to set the current time when includeTime is toggled and the user doesn't enter the edit mode to change it. Well, this is just my preference as a user.

<!-- gh-comment-id:1441345648 --> @annieappflowy commented on GitHub (Feb 23, 2023): I'd prefer to set the current time when includeTime is toggled and the user doesn't enter the edit mode to change it. Well, this is just my preference as a user.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#703
No description provided.