[PR #5830] [MERGED] fix: photo gallery improvements + launch review fixes #7032

Closed
opened 2026-03-23 23:17:47 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5830
Author: @Xazin
Created: 7/29/2024
Status: Merged
Merged: 7/30/2024
Merged by: @LucasXu0

Base: mainHead: fix/photo-gallery-improvements


📝 Commits (4)

  • 93011ee fix: photo gallery improvements
  • d02cf4b fix: improve when to show billing/plan pages
  • 38d6814 feat: add grid photo gallery layout
  • 8f30559 fix: close inline actions menu

📊 Changes

25 files changed (+872 additions, -266 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/document/document_with_multi_image_block_test.dart (+2 -1)
frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/multi_image_block_component/image_render.dart (+42 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/multi_image_block_component/layouts/image_browser_layout.dart (+105 -148)
frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/multi_image_block_component/layouts/image_grid_layout.dart (+323 -0)
frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/multi_image_block_component/layouts/multi_image_layouts.dart (+79 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/multi_image_block_component/multi_image_block_component.dart (+48 -8)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/multi_image_block_component/multi_image_menu.dart (+121 -15)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/multi_image_block_component/multi_image_placeholder.dart (+6 -4)
📝 frontend/appflowy_flutter/lib/plugins/inline_actions/widgets/inline_actions_handler.dart (+6 -7)
📝 frontend/appflowy_flutter/lib/startup/deps_resolver.dart (+0 -5)
📝 frontend/appflowy_flutter/lib/workspace/application/settings/ai/settings_ai_bloc.dart (+3 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/settings/settings_dialog_bloc.dart (+55 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/setting_ai_view/local_ai_setting.dart (+14 -37)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/settings_dialog.dart (+4 -2)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/setting_appflowy_cloud.dart (+22 -21)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_menu.dart (+3 -6)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/image_viewer/interactive_image_toolbar.dart (+7 -5)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/image_viewer/interactive_image_viewer.dart (+8 -4)
📝 frontend/appflowy_flutter/pubspec.lock (+8 -0)
📝 frontend/appflowy_flutter/pubspec.yaml (+2 -0)

...and 5 more files

📄 Description

Closes: #5814
Closes: #5557
Closes: #2947
Closes: #5424

  • Close icon too small in interactive image viewer
  • Double tap to exit image in interactive image viewer
  • Upload image order
  • Center align image options in broser
  • Remove odd selection behavior when double tapping gallery block
  • Add Grid layout

Feature Preview

https://github.com/user-attachments/assets/51717931-138d-4da7-afc6-55a43445e072

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5830 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 7/29/2024 **Status:** ✅ Merged **Merged:** 7/30/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/photo-gallery-improvements` --- ### 📝 Commits (4) - [`93011ee`](https://github.com/AppFlowy-IO/AppFlowy/commit/93011eeb96d816af02db20bdccaa53beac347c9d) fix: photo gallery improvements - [`d02cf4b`](https://github.com/AppFlowy-IO/AppFlowy/commit/d02cf4b4b09f5aa9c12a71ab2a55791b49b16dfa) fix: improve when to show billing/plan pages - [`38d6814`](https://github.com/AppFlowy-IO/AppFlowy/commit/38d6814796a11abff5c1ced304b05746a9e7964e) feat: add grid photo gallery layout - [`8f30559`](https://github.com/AppFlowy-IO/AppFlowy/commit/8f305598a9a76d2900c0234355bb43d271617aef) fix: close inline actions menu ### 📊 Changes **25 files changed** (+872 additions, -266 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_with_multi_image_block_test.dart` (+2 -1) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/multi_image_block_component/image_render.dart` (+42 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/multi_image_block_component/layouts/image_browser_layout.dart` (+105 -148) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/multi_image_block_component/layouts/image_grid_layout.dart` (+323 -0) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/multi_image_block_component/layouts/multi_image_layouts.dart` (+79 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/multi_image_block_component/multi_image_block_component.dart` (+48 -8) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/multi_image_block_component/multi_image_menu.dart` (+121 -15) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/multi_image_block_component/multi_image_placeholder.dart` (+6 -4) 📝 `frontend/appflowy_flutter/lib/plugins/inline_actions/widgets/inline_actions_handler.dart` (+6 -7) 📝 `frontend/appflowy_flutter/lib/startup/deps_resolver.dart` (+0 -5) 📝 `frontend/appflowy_flutter/lib/workspace/application/settings/ai/settings_ai_bloc.dart` (+3 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/settings/settings_dialog_bloc.dart` (+55 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/setting_ai_view/local_ai_setting.dart` (+14 -37) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/settings_dialog.dart` (+4 -2) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/setting_appflowy_cloud.dart` (+22 -21) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_menu.dart` (+3 -6) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/image_viewer/interactive_image_toolbar.dart` (+7 -5) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/image_viewer/interactive_image_viewer.dart` (+8 -4) 📝 `frontend/appflowy_flutter/pubspec.lock` (+8 -0) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+2 -0) _...and 5 more files_ </details> ### 📄 Description Closes: #5814 Closes: #5557 Closes: #2947 Closes: #5424 - [x] Close icon too small in interactive image viewer - [x] Double tap to exit image in interactive image viewer - [x] Upload image order - [x] Center align image options in broser - [x] Remove odd selection behavior when double tapping gallery block - [x] Add Grid layout ### Feature Preview https://github.com/user-attachments/assets/51717931-138d-4da7-afc6-55a43445e072 #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:17:47 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7032
No description provided.