[PR #5834] [MERGED] feat: support global comment on publish #7035

New issue

Closed

opened 2026-03-23 23:17:48 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:17:48 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5834
Author: @qinluhe
Created: 7/30/2024
Status: ✅ Merged
Merged: 8/1/2024
Merged by: @qinluhe

Base: main ← Head: feat/support-global-comment-on-publish

📝 Commits (10+)

6fde3b9 feat: support duplicate UI on web
4976f87 fix: replace google svg
403fd2f fix: modified some copy
e0a70aa fix: adjust modal position
9d3a810 fix: upgrade wasm package
0ddabfa fix: text overflow
7280d07 fix: global comments
e323db2 Merge branch 'fix/publish-view-bugs' into feat/support-global-comment-on-web
49f8ae9 fix: replace appflowy icon
38784b9 fix: demond load outline

📊 Changes

116 files changed (+3789 additions, -236 deletions)

View changed files

📝 frontend/appflowy_web_app/index.html (+2 -4)
📝 frontend/appflowy_web_app/package.json (+2 -1)
📝 frontend/appflowy_web_app/pnpm-lock.yaml (+12 -4)
📝 frontend/appflowy_web_app/public/appflowy.svg (+8 -11)
➕ frontend/appflowy_web_app/src/application/comment.type.ts (+22 -0)
📝 frontend/appflowy_web_app/src/application/services/js-services/index.ts (+69 -0)
📝 frontend/appflowy_web_app/src/application/services/js-services/wasm/client_api.ts (+120 -1)
📝 frontend/appflowy_web_app/src/application/services/services.type.ts (+13 -0)
📝 frontend/appflowy_web_app/src/application/services/tauri-services/index.ts (+47 -5)
📝 frontend/appflowy_web_app/src/application/session/sign_in.ts (+0 -1)
➕ frontend/appflowy_web_app/src/application/types.ts (+40 -0)
➕ frontend/appflowy_web_app/src/assets/add_reaction.svg (+4 -0)
➕ frontend/appflowy_web_app/src/assets/check_circle.svg (+7 -0)
➕ frontend/appflowy_web_app/src/assets/clock_alarm.svg (+7 -0)
➕ frontend/appflowy_web_app/src/assets/close.svg (+6 -0)
➕ frontend/appflowy_web_app/src/assets/collapse.svg (+4 -0)
➕ frontend/appflowy_web_app/src/assets/corner_left_top.svg (+3 -0)
➕ frontend/appflowy_web_app/src/assets/double_arrow.svg (+8 -0)
➕ frontend/appflowy_web_app/src/assets/error.svg (+4 -0)
➕ frontend/appflowy_web_app/src/assets/error_outline.svg (+7 -0)

...and 80 more files

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5834 **Author:** [@qinluhe](https://github.com/qinluhe) **Created:** 7/30/2024 **Status:** ✅ Merged **Merged:** 8/1/2024 **Merged by:** [@qinluhe](https://github.com/qinluhe) **Base:** `main` ← **Head:** `feat/support-global-comment-on-publish` --- ### 📝 Commits (10+) - [`6fde3b9`](https://github.com/AppFlowy-IO/AppFlowy/commit/6fde3b9e3e8cfcda90625ddc9b8fc68bea289515) feat: support duplicate UI on web - [`4976f87`](https://github.com/AppFlowy-IO/AppFlowy/commit/4976f870c8e320d74428b6be3c69818c2ae4bba6) fix: replace google svg - [`403fd2f`](https://github.com/AppFlowy-IO/AppFlowy/commit/403fd2f5a0a28aa6629c27c40643dbe82ef5cc40) fix: modified some copy - [`e0a70aa`](https://github.com/AppFlowy-IO/AppFlowy/commit/e0a70aa4d901bba66a8681104ce2c0ea42191c4a) fix: adjust modal position - [`9d3a810`](https://github.com/AppFlowy-IO/AppFlowy/commit/9d3a8108472b2f0888d477af2572698ef2909456) fix: upgrade wasm package - [`0ddabfa`](https://github.com/AppFlowy-IO/AppFlowy/commit/0ddabfa217d2f778b411c006613999a7d34f33a2) fix: text overflow - [`7280d07`](https://github.com/AppFlowy-IO/AppFlowy/commit/7280d072f1f3bdaed912c8f0ebef8f7660217e38) fix: global comments - [`e323db2`](https://github.com/AppFlowy-IO/AppFlowy/commit/e323db27979caf6761785a9ba9d8d697a1385d2d) Merge branch 'fix/publish-view-bugs' into feat/support-global-comment-on-web - [`49f8ae9`](https://github.com/AppFlowy-IO/AppFlowy/commit/49f8ae93c749fcc0fcd79bb5221c16a3b15d5aa5) fix: replace appflowy icon - [`38784b9`](https://github.com/AppFlowy-IO/AppFlowy/commit/38784b9d73c64254b29a7d50a529fe90b8743436) fix: demond load outline ### 📊 Changes **116 files changed** (+3789 additions, -236 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_web_app/index.html` (+2 -4) 📝 `frontend/appflowy_web_app/package.json` (+2 -1) 📝 `frontend/appflowy_web_app/pnpm-lock.yaml` (+12 -4) 📝 `frontend/appflowy_web_app/public/appflowy.svg` (+8 -11) ➕ `frontend/appflowy_web_app/src/application/comment.type.ts` (+22 -0) 📝 `frontend/appflowy_web_app/src/application/services/js-services/index.ts` (+69 -0) 📝 `frontend/appflowy_web_app/src/application/services/js-services/wasm/client_api.ts` (+120 -1) 📝 `frontend/appflowy_web_app/src/application/services/services.type.ts` (+13 -0) 📝 `frontend/appflowy_web_app/src/application/services/tauri-services/index.ts` (+47 -5) 📝 `frontend/appflowy_web_app/src/application/session/sign_in.ts` (+0 -1) ➕ `frontend/appflowy_web_app/src/application/types.ts` (+40 -0) ➕ `frontend/appflowy_web_app/src/assets/add_reaction.svg` (+4 -0) ➕ `frontend/appflowy_web_app/src/assets/check_circle.svg` (+7 -0) ➕ `frontend/appflowy_web_app/src/assets/clock_alarm.svg` (+7 -0) ➕ `frontend/appflowy_web_app/src/assets/close.svg` (+6 -0) ➕ `frontend/appflowy_web_app/src/assets/collapse.svg` (+4 -0) ➕ `frontend/appflowy_web_app/src/assets/corner_left_top.svg` (+3 -0) ➕ `frontend/appflowy_web_app/src/assets/double_arrow.svg` (+8 -0) ➕ `frontend/appflowy_web_app/src/assets/error.svg` (+4 -0) ➕ `frontend/appflowy_web_app/src/assets/error_outline.svg` (+7 -0) _...and 80 more files_ </details> ### 📄 Description   ### Feature Preview  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>