[PR #5844] [MERGED] fix: try to reopen the first workspace if the workspace deletion failed #7040

New issue

Closed

opened 2026-03-23 23:17:50 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:17:50 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5844
Author: @LucasXu0
Created: 7/31/2024
Status: ✅ Merged
Merged: 7/31/2024
Merged by: @LucasXu0

Base: main ← Head: delete_workspace_error

📝 Commits (1)

9827d46 fix: try to reopen the first workspace if the workspace deletion failed

📊 Changes

2 files changed (+29 additions, -12 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/workspace/application/user/user_workspace_bloc.dart (+21 -10)
📝 frontend/rust-lib/flowy-core/src/deps_resolve/user_deps.rs (+8 -2)

📄 Description

Feature Preview

In some cases, the delete workspace API may return an error even though the deletion actually succeeded. Verify by checking the workspace list again to cover this case.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5844 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 7/31/2024 **Status:** ✅ Merged **Merged:** 7/31/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `delete_workspace_error` --- ### 📝 Commits (1) - [`9827d46`](https://github.com/AppFlowy-IO/AppFlowy/commit/9827d46974d69e10e7e91b28ca6419cbb326fa90) fix: try to reopen the first workspace if the workspace deletion failed ### 📊 Changes **2 files changed** (+29 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/workspace/application/user/user_workspace_bloc.dart` (+21 -10) 📝 `frontend/rust-lib/flowy-core/src/deps_resolve/user_deps.rs` (+8 -2) </details> ### 📄 Description   ### Feature Preview In some cases, the delete workspace API may return an error even though the deletion actually succeeded. Verify by checking the workspace list again to cover this case.  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>