[PR #5903] [MERGED] fix: launch review issues 067 #7075

Closed
opened 2026-03-23 23:18:00 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/5903
Author: @LucasXu0
Created: 8/8/2024
Status: Merged
Merged: 8/8/2024
Merged by: @LucasXu0

Base: mainHead: fix_launch_review_issues_067


📝 Commits (10+)

  • 8e59e20 feat: add capitalize extension for string and apply it in emoji picker header and icon picker
  • 828e3c0 fix: adjust tooltip height calculation
  • 7c11e98 feat: add Streamline open source icons notice and link
  • 7fd1d7e feat: enhance heading toolbar item to toggle heading level and cancel on same level selection
  • ef1dcc6 feat: use home-3 as default space icon
  • 11d4ab8 feat: use the first character of space name as icon if icon was removed
  • dea012f chore: update hover effect for delete workspace button
  • baf6edc chore: optimize space icon on mobile
  • 5017fa7 fix: adjust chat ui on mobile
  • 4a7d8aa fix: adjust default space icon on mobile

📊 Changes

17 files changed (+171 additions, -57 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/mobile/presentation/home/space/mobile_space_header.dart (+2 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/space/mobile_space_menu.dart (+2 -0)
📝 frontend/appflowy_flutter/lib/plugins/ai_chat/presentation/chat_input/chat_input.dart (+5 -6)
📝 frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_picker_header.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/string_extension.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/heading/heading_toolbar_item.dart (+10 -3)
📝 frontend/appflowy_flutter/lib/shared/icon_emoji_picker/icon_picker.dart (+46 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/create_space_popup.dart (+3 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/manage_space_popup.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/shared_widget.dart (+7 -11)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/sidebar_space_menu.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/space_icon.dart (+60 -19)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/space_icon_popup.dart (+17 -5)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/space_more_popup.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_actions.dart (+8 -6)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/widget/flowy_tooltip.dart (+2 -1)
📝 frontend/resources/translations/en.json (+3 -2)

📄 Description

Feature Preview

  • use home-3 as default icon when creating new space
    Screenshot 2024-08-08 at 17 12 10

  • use the first character of space name as default icon if icon was removed.
    Screenshot 2024-08-08 at 17 11 58

  • unable to switch heading style with different level

  • capitalize the group name for icon picker and emoji picker.

  • add Streamline open source icons notice and link
    Screenshot 2024-08-08 at 16 30 07

  • adjust tooltip height calculation
    Screenshot 2024-08-08 at 16 15 23


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/5903 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 8/8/2024 **Status:** ✅ Merged **Merged:** 8/8/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_launch_review_issues_067` --- ### 📝 Commits (10+) - [`8e59e20`](https://github.com/AppFlowy-IO/AppFlowy/commit/8e59e20e336f5e23faec7c35cf5cb05126a3ca07) feat: add capitalize extension for string and apply it in emoji picker header and icon picker - [`828e3c0`](https://github.com/AppFlowy-IO/AppFlowy/commit/828e3c09b903628b2fadad58e96c4ccf1ad3489c) fix: adjust tooltip height calculation - [`7c11e98`](https://github.com/AppFlowy-IO/AppFlowy/commit/7c11e98ab86434f5da12059e91cf0f49ea803b83) feat: add Streamline open source icons notice and link - [`7fd1d7e`](https://github.com/AppFlowy-IO/AppFlowy/commit/7fd1d7ecbcde0b667f9dc5ccb2731ef8d30a6c10) feat: enhance heading toolbar item to toggle heading level and cancel on same level selection - [`ef1dcc6`](https://github.com/AppFlowy-IO/AppFlowy/commit/ef1dcc6e9b70341cf46e541c4208386f4d4e494b) feat: use home-3 as default space icon - [`11d4ab8`](https://github.com/AppFlowy-IO/AppFlowy/commit/11d4ab8292c9d98a832ed3a97e718171d2837819) feat: use the first character of space name as icon if icon was removed - [`dea012f`](https://github.com/AppFlowy-IO/AppFlowy/commit/dea012f43eadcbf8b3c71472496b53e311994168) chore: update hover effect for delete workspace button - [`baf6edc`](https://github.com/AppFlowy-IO/AppFlowy/commit/baf6edc94deba2f8e3eceffa77ed3a7da486f6b9) chore: optimize space icon on mobile - [`5017fa7`](https://github.com/AppFlowy-IO/AppFlowy/commit/5017fa7cfb7f6802d87e8a9ffd522119133b845e) fix: adjust chat ui on mobile - [`4a7d8aa`](https://github.com/AppFlowy-IO/AppFlowy/commit/4a7d8aa2f3fccd551533ef30dfe09cf19aa5f08c) fix: adjust default space icon on mobile ### 📊 Changes **17 files changed** (+171 additions, -57 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/space/mobile_space_header.dart` (+2 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/space/mobile_space_menu.dart` (+2 -0) 📝 `frontend/appflowy_flutter/lib/plugins/ai_chat/presentation/chat_input/chat_input.dart` (+5 -6) 📝 `frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_picker_header.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/string_extension.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/heading/heading_toolbar_item.dart` (+10 -3) 📝 `frontend/appflowy_flutter/lib/shared/icon_emoji_picker/icon_picker.dart` (+46 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/create_space_popup.dart` (+3 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/manage_space_popup.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/shared_widget.dart` (+7 -11) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/sidebar_space_menu.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/space_icon.dart` (+60 -19) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/space_icon_popup.dart` (+17 -5) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/space_more_popup.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_actions.dart` (+8 -6) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/widget/flowy_tooltip.dart` (+2 -1) 📝 `frontend/resources/translations/en.json` (+3 -2) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview - [x] use home-3 as default icon when creating new space <img width="620" alt="Screenshot 2024-08-08 at 17 12 10" src="https://github.com/user-attachments/assets/2d7dcb25-b4f7-4fe4-84c8-65d15fc810db"> - [x] use the first character of space name as default icon if icon was removed. <img width="297" alt="Screenshot 2024-08-08 at 17 11 58" src="https://github.com/user-attachments/assets/12d6d515-2db9-4b25-9754-af7d4cf56efe"> - [x] unable to switch heading style with different level - [x] capitalize the group name for icon picker and emoji picker. - [x] add Streamline open source icons notice and link <img width="427" alt="Screenshot 2024-08-08 at 16 30 07" src="https://github.com/user-attachments/assets/8b0a4c75-c292-4f5d-b25b-d8a30979895c"> - [x] adjust tooltip height calculation <img width="344" alt="Screenshot 2024-08-08 at 16 15 23" src="https://github.com/user-attachments/assets/aaef20bd-7a67-4e33-924c-1f8f49f59263"> <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:18:00 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7075
No description provided.