[PR #6090] [MERGED] feat: media type option #7187

New issue

Closed

opened 2026-03-23 23:18:29 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:18:29 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6090
Author: @Xazin
Created: 8/27/2024
Status: ✅ Merged
Merged: 9/5/2024
Merged by: @Xazin

Base: main ← Head: feat/media-type-option

📝 Commits (10+)

4793d29 feat: media type option
06b4205 feat: rename files + more media types
1d595a3 chore: merge branch 'upstream/main' into feat/media-type-option
d00189c feat: add basic style for cards on desktop
d25ec4b test: add media
4e3edea chore: clippy
9b103ad feat: row detail ux improvement
64a1163 feat: show all media attachments as one count on card
debd277 chore: localization
de42e8c fix: overlay issue + disable filter for option

📊 Changes

112 files changed (+3823 additions, -209 deletions)

View changed files

➕ frontend/appflowy_flutter/integration_test/desktop/database/database_media_test.dart (+96 -0)
📝 frontend/appflowy_flutter/integration_test/shared/database_test_op.dart (+9 -0)
📝 frontend/appflowy_flutter/ios/Runner/Info.plist (+2 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/card/card_detail/mobile_card_detail_screen.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/card/card_detail/widgets/mobile_row_property_list.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/card/mobile_card_content.dart (+45 -10)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_edit_field_screen.dart (+4 -3)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_bottom_sheets.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_quick_field_editor.dart (+4 -3)
➕ frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/media_cell_bloc.dart (+220 -0)
📝 frontend/appflowy_flutter/lib/plugins/database/application/cell/cell_controller_builder.dart (+13 -0)
📝 frontend/appflowy_flutter/lib/plugins/database/application/cell/cell_data_loader.dart (+16 -0)
📝 frontend/appflowy_flutter/lib/plugins/database/board/presentation/board_page.dart (+4 -2)
📝 frontend/appflowy_flutter/lib/plugins/database/calendar/presentation/calendar_event_editor.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/domain/filter_service.dart (+24 -0)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/filter_create_bloc.dart (+6 -7)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/grid_page.dart (+10 -4)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/filter/create_filter_list.dart (+3 -6)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/header/field_type_extension.dart (+7 -0)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/row/mobile_row.dart (+2 -1)

...and 80 more files

📄 Description

Todo

Localization
Filter bug
Integration tests
Rewrite cell styles, should be reusable across all platforms

Feature Preview

Desktop

Grid View	Board View	Calendar

Row Detail View	File menu

Mobile

Grid View	Board View	Calendar

Cell Editor	File menu	Row Detail View

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6090 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 8/27/2024 **Status:** ✅ Merged **Merged:** 9/5/2024 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `feat/media-type-option` --- ### 📝 Commits (10+) - [`4793d29`](https://github.com/AppFlowy-IO/AppFlowy/commit/4793d29de2a131d62da5562513593dc0cfdbd1f0) feat: media type option - [`06b4205`](https://github.com/AppFlowy-IO/AppFlowy/commit/06b42059448e39cefc42712e5784c3ca42904967) feat: rename files + more media types - [`1d595a3`](https://github.com/AppFlowy-IO/AppFlowy/commit/1d595a3d01700ed33a5258c4b91a4fe31e739c31) chore: merge branch 'upstream/main' into feat/media-type-option - [`d00189c`](https://github.com/AppFlowy-IO/AppFlowy/commit/d00189c891b8bf9d64d5083993f21dbca7f62744) feat: add basic style for cards on desktop - [`d25ec4b`](https://github.com/AppFlowy-IO/AppFlowy/commit/d25ec4ba3cd1eee7f64a7e55a806c42a74ca56ba) test: add media - [`4e3edea`](https://github.com/AppFlowy-IO/AppFlowy/commit/4e3edeac46e68e5ff62cf5c1bb7bc247817be869) chore: clippy - [`9b103ad`](https://github.com/AppFlowy-IO/AppFlowy/commit/9b103adb4b34ff523546c83195c0e29adc6fe512) feat: row detail ux improvement - [`64a1163`](https://github.com/AppFlowy-IO/AppFlowy/commit/64a11636fd6f6d68df69332176e38bade0880046) feat: show all media attachments as one count on card - [`debd277`](https://github.com/AppFlowy-IO/AppFlowy/commit/debd2773bade147b6aeaed2ebc71e654512f3813) chore: localization - [`de42e8c`](https://github.com/AppFlowy-IO/AppFlowy/commit/de42e8c7646663ae2f62b12f9b572ac2fa429f17) fix: overlay issue + disable filter for option ### 📊 Changes **112 files changed** (+3823 additions, -209 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/integration_test/desktop/database/database_media_test.dart` (+96 -0) 📝 `frontend/appflowy_flutter/integration_test/shared/database_test_op.dart` (+9 -0) 📝 `frontend/appflowy_flutter/ios/Runner/Info.plist` (+2 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/card/card_detail/mobile_card_detail_screen.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/card/card_detail/widgets/mobile_row_property_list.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/card/mobile_card_content.dart` (+45 -10) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_edit_field_screen.dart` (+4 -3) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_bottom_sheets.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_quick_field_editor.dart` (+4 -3) ➕ `frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/media_cell_bloc.dart` (+220 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/cell/cell_controller_builder.dart` (+13 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/cell/cell_data_loader.dart` (+16 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database/board/presentation/board_page.dart` (+4 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database/calendar/presentation/calendar_event_editor.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/domain/filter_service.dart` (+24 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/filter_create_bloc.dart` (+6 -7) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/grid_page.dart` (+10 -4) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/filter/create_filter_list.dart` (+3 -6) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/header/field_type_extension.dart` (+7 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/row/mobile_row.dart` (+2 -1) _...and 80 more files_ </details> ### 📄 Description ### Todo - [x] Localization - [x] Filter bug - [x] Integration tests - [x] Rewrite cell styles, should be reusable across all platforms ## Feature Preview ### Desktop | Grid View | Board View | Calendar | | ---------- | ----------- | --------- | | <img src="https://github.com/user-attachments/assets/b85795de-d42a-486b-bc2a-31137ddc3781" width="200"> | <img src="https://github.com/user-attachments/assets/589ca536-96a5-469b-9716-3a595c55a6c9" width="200"> | <img src="https://github.com/user-attachments/assets/15b989fc-e2ce-47aa-a203-1e89df2b17bd" width="200"> | Row Detail View | File menu | | | <img src="https://github.com/user-attachments/assets/5fe322c3-3112-4918-9655-bb33fcdb2098" width="200"> | <img src="https://github.com/user-attachments/assets/55580c7a-69df-49e1-85d5-0d1ce4f2aaa3" width="200"> | ### Mobile | Grid View | Board View | Calendar | | ---------- | ----------- | --------- | | <img src="https://github.com/user-attachments/assets/7d057c7b-86a5-4eae-8178-145262a555ec" width="200"> | <img src="https://github.com/user-attachments/assets/7f7f409a-40b0-4625-9e46-5df245fd4bfd" width="200"> | <img src="https://github.com/user-attachments/assets/a085a4b6-8def-4da9-9d53-466b686772a0" width="200"> | Cell Editor | File menu | Row Detail View | | <img src="https://github.com/user-attachments/assets/fcbead36-364b-4b9e-8792-fe39267aaa14" width="200"> | <img src="https://github.com/user-attachments/assets/a0a2d601-1c97-4143-aea3-c3a2957f9055" width="200"> | <img src="https://github.com/user-attachments/assets/3011729e-1445-4e76-b188-5f04cf16e41d" width="200"> --- #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>