[PR #6156] [MERGED] fix: edit group title + rebuild improvement #7218

New issue

Closed

opened 2026-03-23 23:18:38 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:18:38 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6156
Author: @Xazin
Created: 9/1/2024
Status: ✅ Merged
Merged: 9/5/2024
Merged by: @Xazin

Base: main ← Head: fix/edit-group-improve

📝 Commits (9)

166847d fix: edit group title + rebuild improvement
4dfa5f9 chore: fix clippy
f1b75d9 chore: fix clippy
e71d61f chore: merge 'upstream/main' into fix/edit-group-improve
e980e97 fix: stop widget replacement causing perf issues
a385a2f fix: after merge main
f69e835 chore: merge branch 'upstream/main' into fix/edit-group-improve
7449b1f chore: minor cleanup in view_editor
7d1d7e9 fix: attempt to fix hover issue in tests

📊 Changes

25 files changed (+592 additions, -200 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/shared/common_operations.dart (+5 -4)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/board/widgets/mobile_hidden_groups_column.dart (+4 -2)
📝 frontend/appflowy_flutter/lib/plugins/database/board/application/board_bloc.dart (+11 -106)
➕ frontend/appflowy_flutter/lib/plugins/database/board/application/column_header_bloc.dart (+113 -0)
➕ frontend/appflowy_flutter/lib/plugins/database/board/group_ext.dart (+106 -0)
📝 frontend/appflowy_flutter/lib/plugins/database/board/presentation/board_page.dart (+17 -2)
📝 frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_column_header.dart (+19 -15)
📝 frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_hidden_groups.dart (+8 -4)
📝 frontend/appflowy_flutter/lib/plugins/database/domain/group_service.dart (+14 -0)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/card/card.dart (+5 -7)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/card_cell_skeleton/text_card_cell.dart (+10 -10)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/editable_cell_builder.dart (+6 -0)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/hover.dart (+16 -39)
📝 frontend/rust-lib/flowy-database2/src/entities/group_entities/group.rs (+63 -0)
📝 frontend/rust-lib/flowy-database2/src/entities/group_entities/group_changeset.rs (+9 -0)
📝 frontend/rust-lib/flowy-database2/src/event_handler.rs (+16 -0)
📝 frontend/rust-lib/flowy-database2/src/event_map.rs (+4 -0)
📝 frontend/rust-lib/flowy-database2/src/notification.rs (+3 -0)
📝 frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs (+6 -0)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/notifier.rs (+12 -2)

...and 5 more files

📄 Description

Fix an issue where the end editing event returned before changing the state to not-editing
Fix a rebuild issue with groups generally, where renaming a group caused the whole board to rebuild.
Fix a rebuild issue with FlowyHover causing eg. Board Cards to completely rebuild (new lifecycle) meaning the BLoCs would also reinstantiate causing a lot of backend requests on hover.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6156 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 9/1/2024 **Status:** ✅ Merged **Merged:** 9/5/2024 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `fix/edit-group-improve` --- ### 📝 Commits (9) - [`166847d`](https://github.com/AppFlowy-IO/AppFlowy/commit/166847d97a15c80430811d377a590ee7585cecab) fix: edit group title + rebuild improvement - [`4dfa5f9`](https://github.com/AppFlowy-IO/AppFlowy/commit/4dfa5f9affa12f98c21ca3179f0d5e70b04fb477) chore: fix clippy - [`f1b75d9`](https://github.com/AppFlowy-IO/AppFlowy/commit/f1b75d9e67cb6dfcc12833931faf9e64daeabde4) chore: fix clippy - [`e71d61f`](https://github.com/AppFlowy-IO/AppFlowy/commit/e71d61f5fdf8cb84d49219e37e4d8edee4ea8161) chore: merge 'upstream/main' into fix/edit-group-improve - [`e980e97`](https://github.com/AppFlowy-IO/AppFlowy/commit/e980e97d15213c2fdd060bd9206f1c08fc92d058) fix: stop widget replacement causing perf issues - [`a385a2f`](https://github.com/AppFlowy-IO/AppFlowy/commit/a385a2fc6eedce7fdfd5401d973afa06c1adefb8) fix: after merge main - [`f69e835`](https://github.com/AppFlowy-IO/AppFlowy/commit/f69e8356d1808947ea70154fbdfcb40e412b1934) chore: merge branch 'upstream/main' into fix/edit-group-improve - [`7449b1f`](https://github.com/AppFlowy-IO/AppFlowy/commit/7449b1f4da6cc1bf413ee3fd82dd17a3be771ada) chore: minor cleanup in view_editor - [`7d1d7e9`](https://github.com/AppFlowy-IO/AppFlowy/commit/7d1d7e96a1fe0ddd7bff0e516cc656f49816ffeb) fix: attempt to fix hover issue in tests ### 📊 Changes **25 files changed** (+592 additions, -200 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/shared/common_operations.dart` (+5 -4) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/board/widgets/mobile_hidden_groups_column.dart` (+4 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database/board/application/board_bloc.dart` (+11 -106) ➕ `frontend/appflowy_flutter/lib/plugins/database/board/application/column_header_bloc.dart` (+113 -0) ➕ `frontend/appflowy_flutter/lib/plugins/database/board/group_ext.dart` (+106 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database/board/presentation/board_page.dart` (+17 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_column_header.dart` (+19 -15) 📝 `frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_hidden_groups.dart` (+8 -4) 📝 `frontend/appflowy_flutter/lib/plugins/database/domain/group_service.dart` (+14 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/card/card.dart` (+5 -7) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/card_cell_skeleton/text_card_cell.dart` (+10 -10) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/editable_cell_builder.dart` (+6 -0) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/hover.dart` (+16 -39) 📝 `frontend/rust-lib/flowy-database2/src/entities/group_entities/group.rs` (+63 -0) 📝 `frontend/rust-lib/flowy-database2/src/entities/group_entities/group_changeset.rs` (+9 -0) 📝 `frontend/rust-lib/flowy-database2/src/event_handler.rs` (+16 -0) 📝 `frontend/rust-lib/flowy-database2/src/event_map.rs` (+4 -0) 📝 `frontend/rust-lib/flowy-database2/src/notification.rs` (+3 -0) 📝 `frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs` (+6 -0) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/notifier.rs` (+12 -2) _...and 5 more files_ </details> ### 📄 Description - Fix an issue where the end editing event returned before changing the state to not-editing - Fix a rebuild issue with groups generally, where renaming a group caused the whole board to rebuild. - Fix a rebuild issue with FlowyHover causing eg. Board Cards to completely rebuild (new lifecycle) meaning the BLoCs would also reinstantiate causing a lot of backend requests on hover. #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>