[PR #6182] [MERGED] fix(flutter): various grid ui issues #7234

New issue

Closed

opened 2026-03-23 23:18:42 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:18:42 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6182
Author: @richardshiue
Created: 9/4/2024
Status: ✅ Merged
Merged: 9/5/2024
Merged by: @LucasXu0

Base: main ← Head: fix/database-misc-issues

📝 Commits (10+)

882736d fix: delete field confirmation dialog only closes top most popover
2c835df fix: prioritize single-line checklist items
d5ec69a chore: wrap text toggle persist
25d4bba test: update integration tests
e13c442 chore: delete conflicting outputs on freezed
bd7185a chore: slightly make field editor faster
199bcf5 chore: use standard dialog componet
a8b561d chore: enable multiline checklist tasks on mobile
0d289d6 chore: Update frontend/appflowy_flutter/lib/plugins/database/application/field/field_editor_bloc.dart
82d71ea chore: code cleanup

📊 Changes

23 files changed (+325 additions, -307 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/board/board_field_test.dart (+1 -1)
📝 frontend/appflowy_flutter/integration_test/desktop/database/database_cell_test.dart (+8 -7)
📝 frontend/appflowy_flutter/integration_test/desktop/database/database_field_test.dart (+26 -61)
📝 frontend/appflowy_flutter/integration_test/desktop/database/database_row_page_test.dart (+14 -2)
📝 frontend/appflowy_flutter/integration_test/shared/database_test_op.dart (+8 -13)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_quick_field_editor.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/application/field/field_editor_bloc.dart (+13 -12)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/application/row/row_detail_bloc.dart (+23 -0)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/header/desktop_field_cell.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/header/grid_header.dart (+3 -8)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/checklist_cell_editor.dart (+2 -0)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/mobile_checklist_cell_editor.dart (+3 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/relation_cell_editor.dart (+46 -12)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/field/field_editor.dart (+42 -36)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/row/row_property.dart (+118 -135)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/setting/setting_property_list.dart (+1 -1)
📝 frontend/appflowy_flutter/pubspec.lock (+2 -2)
📝 frontend/appflowy_flutter/test/bloc_test/board_test/create_or_edit_field_test.dart (+1 -1)
📝 frontend/appflowy_flutter/test/bloc_test/board_test/util.dart (+7 -9)
📝 frontend/appflowy_flutter/test/bloc_test/grid_test/field/edit_field_test.dart (+1 -1)

...and 3 more files

📄 Description

fix this monstrosity
On desktop, make enter on checklist items end editing, only allow shift + enter to go to a new line
don't animate the wrap text toggle when opening it
add integration test for when changing field type during creation
allow opening a related database from the popover

https://github.com/user-attachments/assets/31e94760-de5d-40a4-a2c0-0db0838e9c40

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6182 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 9/4/2024 **Status:** ✅ Merged **Merged:** 9/5/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/database-misc-issues` --- ### 📝 Commits (10+) - [`882736d`](https://github.com/AppFlowy-IO/AppFlowy/commit/882736d0707320dd391dd2e27a47e57becfeb8e4) fix: delete field confirmation dialog only closes top most popover - [`2c835df`](https://github.com/AppFlowy-IO/AppFlowy/commit/2c835dff48298b4797e722bc224601812a438e91) fix: prioritize single-line checklist items - [`d5ec69a`](https://github.com/AppFlowy-IO/AppFlowy/commit/d5ec69a4b5d3b6fa0eee286de6d685187ebde9b1) chore: wrap text toggle persist - [`25d4bba`](https://github.com/AppFlowy-IO/AppFlowy/commit/25d4bbaa2b156f251d58d5a4d3d0724631d2f4c4) test: update integration tests - [`e13c442`](https://github.com/AppFlowy-IO/AppFlowy/commit/e13c442a023780df2b67d23bde841a32cee393d0) chore: delete conflicting outputs on freezed - [`bd7185a`](https://github.com/AppFlowy-IO/AppFlowy/commit/bd7185adb925be1599150fbacfeeb8f26b1a7766) chore: slightly make field editor faster - [`199bcf5`](https://github.com/AppFlowy-IO/AppFlowy/commit/199bcf5cbbeff4dfa1ac092bbe59070c365dfc21) chore: use standard dialog componet - [`a8b561d`](https://github.com/AppFlowy-IO/AppFlowy/commit/a8b561d09517c1a3acd03070bee3238793130f65) chore: enable multiline checklist tasks on mobile - [`0d289d6`](https://github.com/AppFlowy-IO/AppFlowy/commit/0d289d698b67182ed06eac7b19ac88773dda3eb3) chore: Update frontend/appflowy_flutter/lib/plugins/database/application/field/field_editor_bloc.dart - [`82d71ea`](https://github.com/AppFlowy-IO/AppFlowy/commit/82d71ea871e46804a17e986aeb9fa87dec5c424e) chore: code cleanup ### 📊 Changes **23 files changed** (+325 additions, -307 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/board/board_field_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/integration_test/desktop/database/database_cell_test.dart` (+8 -7) 📝 `frontend/appflowy_flutter/integration_test/desktop/database/database_field_test.dart` (+26 -61) 📝 `frontend/appflowy_flutter/integration_test/desktop/database/database_row_page_test.dart` (+14 -2) 📝 `frontend/appflowy_flutter/integration_test/shared/database_test_op.dart` (+8 -13) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_quick_field_editor.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/field/field_editor_bloc.dart` (+13 -12) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/application/row/row_detail_bloc.dart` (+23 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/header/desktop_field_cell.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/header/grid_header.dart` (+3 -8) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/checklist_cell_editor.dart` (+2 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/mobile_checklist_cell_editor.dart` (+3 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/relation_cell_editor.dart` (+46 -12) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/field/field_editor.dart` (+42 -36) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/row/row_property.dart` (+118 -135) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/setting/setting_property_list.dart` (+1 -1) 📝 `frontend/appflowy_flutter/pubspec.lock` (+2 -2) 📝 `frontend/appflowy_flutter/test/bloc_test/board_test/create_or_edit_field_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/test/bloc_test/board_test/util.dart` (+7 -9) 📝 `frontend/appflowy_flutter/test/bloc_test/grid_test/field/edit_field_test.dart` (+1 -1) _...and 3 more files_ </details> ### 📄 Description 1. fix this monstrosity ![Screenshot 2024-09-04 at 11 48 39 AM](https://github.com/user-attachments/assets/c676f66b-2d3e-4c23-855a-cc3106724d80) ![Screenshot 2024-09-04 at 5 18 26 PM](https://github.com/user-attachments/assets/ea138ac1-bdb9-4816-a616-1caa068751cd) 3. On desktop, make enter on checklist items end editing, only allow shift + enter to go to a new line 4. don't animate the wrap text toggle when opening it 5. add integration test for when changing field type during creation 6. allow opening a related database from the popover https://github.com/user-attachments/assets/31e94760-de5d-40a4-a2c0-0db0838e9c40 ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>