[PR #6212] [MERGED] fix: newly-created group rows appear out of order #7253

New issue

Closed

opened 2026-03-23 23:18:47 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:18:47 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6212
Author: @richardshiue
Created: 9/6/2024
Status: ✅ Merged
Merged: 9/8/2024
Merged by: @appflowy

Base: main ← Head: fix/group-row-order

📝 Commits (5)

267d432 fix: newly-created group rows appear out of order
bcc4181 test: fix tests
55b9e99 fix: dont re-insert nor insert into no-status
58c1d65 fix: clippy
40a604c fix: clippy

📊 Changes

8 files changed (+195 additions, -52 deletions)

View changed files

📝 frontend/appflowy_flutter/macos/Podfile.lock (+1 -1)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs (+6 -3)
📝 frontend/rust-lib/flowy-database2/src/services/group/action.rs (+5 -1)
📝 frontend/rust-lib/flowy-database2/src/services/group/controller.rs (+98 -30)
📝 frontend/rust-lib/flowy-database2/src/services/group/controller_impls/default_controller.rs (+8 -4)
📝 frontend/rust-lib/flowy-database2/src/services/group/entities.rs (+2 -4)
📝 frontend/rust-lib/flowy-database2/tests/database/group_test/script.rs (+9 -4)
📝 frontend/rust-lib/flowy-database2/tests/database/group_test/test.rs (+66 -5)

📄 Description

https://github.com/user-attachments/assets/d7c9a1ba-c7f3-4f4d-984a-90f86f848465

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6212 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 9/6/2024 **Status:** ✅ Merged **Merged:** 9/8/2024 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `fix/group-row-order` --- ### 📝 Commits (5) - [`267d432`](https://github.com/AppFlowy-IO/AppFlowy/commit/267d432a32a2d609c7029077a7e3b06e97871947) fix: newly-created group rows appear out of order - [`bcc4181`](https://github.com/AppFlowy-IO/AppFlowy/commit/bcc4181756045de833599d34e8f46dbf52e2721d) test: fix tests - [`55b9e99`](https://github.com/AppFlowy-IO/AppFlowy/commit/55b9e9904f010ab60c5b37e1acdd91fde621bd79) fix: dont re-insert nor insert into no-status - [`58c1d65`](https://github.com/AppFlowy-IO/AppFlowy/commit/58c1d65d0e332a2d7edf87d1f121280e8c361d8d) fix: clippy - [`40a604c`](https://github.com/AppFlowy-IO/AppFlowy/commit/40a604c3c0fe80b0a64f7529e3ab3ac001a87405) fix: clippy ### 📊 Changes **8 files changed** (+195 additions, -52 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/macos/Podfile.lock` (+1 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs` (+6 -3) 📝 `frontend/rust-lib/flowy-database2/src/services/group/action.rs` (+5 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/group/controller.rs` (+98 -30) 📝 `frontend/rust-lib/flowy-database2/src/services/group/controller_impls/default_controller.rs` (+8 -4) 📝 `frontend/rust-lib/flowy-database2/src/services/group/entities.rs` (+2 -4) 📝 `frontend/rust-lib/flowy-database2/tests/database/group_test/script.rs` (+9 -4) 📝 `frontend/rust-lib/flowy-database2/tests/database/group_test/test.rs` (+66 -5) </details> ### 📄 Description https://github.com/user-attachments/assets/d7c9a1ba-c7f3-4f4d-984a-90f86f848465 ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>