AppFlowy-IO/AppFlowy

Fork

You've already forked AppFlowy

mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2026-03-24 12:56:59 +00:00

Code Issues 952 Projects Packages Wiki Activity

[PR #6260] [MERGED] fix: media option improvements #7279

New issue

Closed

opened 2026-03-23 23:18:53 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:18:53 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6260
Author: @Xazin
Created: 9/9/2024
Status: ✅ Merged
Merged: 9/12/2024
Merged by: @Xazin

Base: main ← Head: fix/media-option-improvements

📝 Commits (10+)

6c67bae feat: hide file names option
5125aa9 chore: copywriting fixes
7a11096 fix: mobile cell
a97bc0b feat: browse all images in a cell in viewer
0039fc1 chore: unused variable
c0c1fdc fix: dialogs on download file
d68eb9f feat: upload multiple files at once
72deee7 chore: merge branch 'upstream/main' into fix/media-option-improvements
97800ef chore: merge branch 'upstream/main' into fix/media-option-improvements
8963368 test: improve test coverage

📊 Changes

19 files changed (+615 additions, -134 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/database/database_media_test.dart (+217 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/media_cell_bloc.dart (+14 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/application/field/type_option/type_option_data_parser.dart (+7 -0)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_grid/desktop_grid_media_cell.dart (+3 -2)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_row_detail/desktop_row_detail_media_cell.dart (+101 -63)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/media_cell_editor.dart (+50 -22)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/mobile_media_cell_editor.dart (+4 -4)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/field/type_option_editor/media.dart (+58 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/file/file_block_component.dart (+5 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/file/file_upload_menu.dart (+24 -11)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/file/file_util.dart (+76 -5)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/upload_image_menu/upload_image_menu.dart (+9 -14)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/image_viewer/interactive_image_viewer.dart (+26 -0)
📝 frontend/resources/translations/en.json (+7 -4)
📝 frontend/rust-lib/flowy-database2/src/entities/type_option_entities/media_entities.rs (+3 -0)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_group.rs (+1 -1)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_sort.rs (+1 -1)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/media_type_option/media_type_option.rs (+5 -0)
📝 frontend/rust-lib/flowy-database2/tests/database/mock_data/grid_mock_data.rs (+4 -1)

📄 Description

Hide file names
Don't display "Empty" in cell on mobile
Some copywrite fixes
Can browse all images in a field when opening the image viewer
Snackbar/toast after downloading file successfully
Upload multiple files at once

Feature Preview

Hide file names

https://github.com/user-attachments/assets/b21a339f-5eed-4d69-83d0-46ddfe7f1e3a

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6260 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 9/9/2024 **Status:** ✅ Merged **Merged:** 9/12/2024 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `fix/media-option-improvements` --- ### 📝 Commits (10+) - [`6c67bae`](https://github.com/AppFlowy-IO/AppFlowy/commit/6c67bae2beac3bf939dfad0f93e9b5861345ace7) feat: hide file names option - [`5125aa9`](https://github.com/AppFlowy-IO/AppFlowy/commit/5125aa97bc8f98612bff24f9285d0c166e1ed254) chore: copywriting fixes - [`7a11096`](https://github.com/AppFlowy-IO/AppFlowy/commit/7a11096f977e7b651ad226a6f8ec3c8d5129de52) fix: mobile cell - [`a97bc0b`](https://github.com/AppFlowy-IO/AppFlowy/commit/a97bc0bddf5a9fe0d8a7c606d66b9ccedba866c9) feat: browse all images in a cell in viewer - [`0039fc1`](https://github.com/AppFlowy-IO/AppFlowy/commit/0039fc17a8f905fb94025683b7a4bb503c9c2501) chore: unused variable - [`c0c1fdc`](https://github.com/AppFlowy-IO/AppFlowy/commit/c0c1fdcb6dd7217cb4a8c316a094507f010b9cbb) fix: dialogs on download file - [`d68eb9f`](https://github.com/AppFlowy-IO/AppFlowy/commit/d68eb9faa5326df67ad7dfc6c364459b12f3c3a9) feat: upload multiple files at once - [`72deee7`](https://github.com/AppFlowy-IO/AppFlowy/commit/72deee7a20b6bf6e0003ceb99b6fbf92932b0383) chore: merge branch 'upstream/main' into fix/media-option-improvements - [`97800ef`](https://github.com/AppFlowy-IO/AppFlowy/commit/97800efbdd7afc967d84ae1f79e4553566c111b3) chore: merge branch 'upstream/main' into fix/media-option-improvements - [`8963368`](https://github.com/AppFlowy-IO/AppFlowy/commit/89633680ff46afd33d23cabcd76c5d008d82cc01) test: improve test coverage ### 📊 Changes **19 files changed** (+615 additions, -134 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/database/database_media_test.dart` (+217 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/media_cell_bloc.dart` (+14 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/field/type_option/type_option_data_parser.dart` (+7 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_grid/desktop_grid_media_cell.dart` (+3 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_row_detail/desktop_row_detail_media_cell.dart` (+101 -63) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/media_cell_editor.dart` (+50 -22) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/mobile_media_cell_editor.dart` (+4 -4) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/field/type_option_editor/media.dart` (+58 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/file/file_block_component.dart` (+5 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/file/file_upload_menu.dart` (+24 -11) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/file/file_util.dart` (+76 -5) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/upload_image_menu/upload_image_menu.dart` (+9 -14) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/image_viewer/interactive_image_viewer.dart` (+26 -0) 📝 `frontend/resources/translations/en.json` (+7 -4) 📝 `frontend/rust-lib/flowy-database2/src/entities/type_option_entities/media_entities.rs` (+3 -0) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_group.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_sort.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/media_type_option/media_type_option.rs` (+5 -0) 📝 `frontend/rust-lib/flowy-database2/tests/database/mock_data/grid_mock_data.rs` (+4 -1) </details> ### 📄 Description - [x] Hide file names - [x] Don't display "Empty" in cell on mobile - [x] Some copywrite fixes - [x] Can browse all images in a field when opening the image viewer - [x] Snackbar/toast after downloading file successfully - [x] Upload multiple files at once ### Feature Preview - Hide file names https://github.com/user-attachments/assets/b21a339f-5eed-4d69-83d0-46ddfe7f1e3a #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

mirror

2026-03-23 23:18:54 +00:00

closed this issue
added the
pull-request
label

No Branch/Tag specified

main

copilot/fix-date-format-issue

feat/mention_a_person

merge_upstream_v6

mobile/release/0.9.3

release/0.9.3

release/0.9.2

select_source

release/0.9.1

refactor_import_data

release/0.8.9.1

release/0.8.9

anon_user_mode

release/0.8.8

fix_windows_selection

release/0.8.7

annieappflowy-patch-1

windows_local_ai

release/0.8.6

release/0.8.5

release/0.8.4

chore/optional-response-format

release/0.8.3

release/0.8.2

release/0.8.1

release/0.8.0

release/0.7.9

feat/support-rename-workspace

chat_rag_only

calculate_ui_test

release/0.7.8

release/0.7.7

stringfi_cells

hotfix/0.7.5

release/0.7.4

client-api-update

feat/collab-editing

fix_calculation_bug

feat/upload-file-in-document

update-client-api

feat/support-global-comment-on-web

update-client-api-2

feat/support-duplicate-publish-on-web

feat/ai-plan-billing

chore/test-web-deploy

chore/enable-billing-for-testing

build/test

ai_tag_feature

chore/enable-billing-plan

feat/billing-client-windows

chore/support-openai-chat

fix/try-no-media-kit

sign-in-error-format

workspace-invite-ci-test

last-workspace

workspace-invite-wip

feat/date-text-input

appflowy_v1

0.11.1

0.11.0

0.10.9

0.11.2

0.10.7

0.10.6

0.10.5

0.11.3

0.11.4

0.10.8

0.10.4

0.10.3

0.10.2

0.10.0

0.10.1

0.9.9

0.9.8

0.9.7

0.9.5

0.9.6

0.9.4

0.9.3

0.9.2

0.9.1

0.9.0

0.8.9

0.8.8

0.8.7

0.8.6

0.8.5

0.8.4

0.8.3

0.8.2

0.8.1

0.8.0

0.7.9

0.7.8

0.7.7

0.7.6

0.7.5

0.7.4

0.7.3

0.7.2

0.7.1

0.7.0

0.6.9

0.6.8

0.6.7.2

0.6.7.1

0.6.7

0.6.6

0.6.5

0.6.4

0.6.3

0.6.2

0.6.1

v0.6.1

0.6.0

0.5.9

0.5.8

0.5.7

0.5.6

0.5.5

0.5.4

0.5.3

0.5.2

0.5.1

0.5.0

0.4.9

0.4.8

0.4.7

0.4.6

0.4.5

0.4.4

0.4.3

0.4.2

0.4.1

0.4.0

0.3.9.1

0.3.9

0.3.8

0.3.7

0.3.6

0.3.5

0.3.4

0.3.3

0.3.2

0.3.1

0.3.0

0.2.9

0.2.8

0.2.7

0.2.6

0.2.5

0.2.4

0.2.3

0.2.2

0.2.1

0.2.0

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.9.1

0.0.9

0.0.8.1

0.0.8

0.0.7.1

0.0.7

0.0.6.2

0.0.6.1

0.0.6

0.0.6_beta.1

0.0.5.3

0.0.5.2

0.0.5.1

0.0.5

0.0.5_beta.2

0.0.5_beta.1

0.0.4

0.0.4_beta.3

0.0.4_beta.2

0.0.4_beta.1

0.0.3

0.0.3_beta.2

0.0.3_beta.1

0.0.2

0.0.1

Labels

Clear labels

good first issue for devs

good first issue for experienced devs

grid

hacktoberfest

HACKTOBERFEST-ACCEPTED

Mirrored from GitHub Pull Request

No labels

good first issue for devs

good first issue for experienced devs

grid

hacktoberfest

HACKTOBERFEST-ACCEPTED

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

AppFlowy-IO/AppFlowy#7279

Reference in a new issue

Repository

AppFlowy-IO/AppFlowy

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns